dsn/ddclient option to force ssl (#2823)

* dsn/ddclient option to force ssl
* dns/ddclient default ssl

dns/ddclient/src/opnsense/mvc/app/controllers/OPNsense/DynDNS/forms/settings.xml

@@ -12,6 +12,13 @@
         <advanced>true</advanced>
         <help>Enable verbose logging</help>
     </field>
+    <field>
+        <id>ddclient.general.force_ssl</id>
+        <label>Force SSL</label>
+        <type>checkbox</type>
+        <advanced>true</advanced>
+        <help>Force update using HTTPS</help>
+    </field>
     <field>
         <id>ddclient.general.daemon_delay</id>
         <label>Interval</label>

dns/ddclient/src/opnsense/mvc/app/models/OPNsense/DynDNS/DynDNS.xml

@@ -1,6 +1,6 @@
 <model>
     <mount>//OPNsense/DynDNS</mount>
-    <version>1.0.0</version>
+    <version>1.1.0</version>
     <description>
         Dynamic DNS client
     </description>
@@ -14,6 +14,10 @@
                 <default>0</default>
                 <Required>Y</Required>
             </verbose>
+            <force_ssl type="BooleanField">
+                <default>1</default>
+                <Required>Y</Required>
+            </force_ssl>
             <daemon_delay type="IntegerField">
                 <default>300</default>
                 <Required>Y</Required>

dns/ddclient/src/opnsense/service/templates/OPNsense/ddclient/ddclient.conf

@@ -2,6 +2,9 @@
 daemon={{OPNsense.DynDNS.general.daemon_delay|default('300')}}
 syslog=yes                  # log update msgs to syslog
 pid=/var/run/ddclient.pid   # record PID in file.
+{% if not helpers.empty('OPNsense.DynDNS.general.force_ssl') %}
+ssl=yes
+{% endif %}
 {% if not helpers.empty('OPNsense.DynDNS.general.verbose') %}
 verbose=yes
 {% endif %}
@@ -54,34 +57,27 @@ use=if, if={{physical_interface(account.interface)}}, \
 {%            endif %}
 {%            if account.service == 'custom' %}
 protocol={{account.protocol}}, \
-ssl=yes, \
 server={{account.server}}, \
 {%            elif account.service == 'cloudflare' %}
 protocol=cloudflare, \
 zone={{account.zone}}, \
 {%            elif account.service == 'he-net' %}
 protocol=dyndns2, \
-ssl=yes, \
 server=dyn.dns.he.net, \
 {%            elif account.service == 'he-net-tunnel' %}
 protocol=dyndns2, \
-ssl=yes, \
 server=ipv4.tunnelbroker.net, \
 {%            elif account.service == 'nsupdatev4' %}
 protocol=dyndns2, \
-ssl=yes, \
 server=ipv4.nsupdate.info, \
 {%            elif account.service == 'nsupdatev6' %}
 protocol=dyndns2, \
-ssl=yes, \
 server=ipv6.nsupdate.info, \
 {%            elif account.service == 'strato' %}
 protocol=dyndns2, \
-ssl=yes, \
 server=dyndns.strato.com, \
 {%            else %}
 protocol={{account.service}}, \
-ssl=yes, \
 {%            endif %}
 {%            if account.wildcard|default('0') == '1' %}
 wildcard=yes, \