netbird/plugins
0
0
Fork 0
mirror of https://github.com/netbirdio/plugins.git synced 2026-05-22 18:44:07 -07:00
Code Issues Packages Projects Releases Wiki Activity

security/acme-client: remove all hardcoded DNS sleep times

Browse Source 
The report in #2121 made it clear that it was never a good idea to use a
hardcoded value in the first place. It is very likely a breaking change for
some users, so I've added notes to the GUI and the plugin changelog.
This commit is contained in:
Frank Wall
2020-12-13 12:53:06 +01:00
parent a37538b636
commit 0fe2422fa0
6 changed files with 24 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files
security/acme-client/pkg-descr
+4
View File
@@ -12,6 +12,10 @@ Plugin Changelog
Changed:
* BREAKING: use configured DNS sleep time for Namesilo instead of hardcoded value (#2121)
* BREAKING: use configured DNS sleep time for Lexicon/Namesilo instead of hardcoded value
* BREAKING: use configured DNS sleep time for Linode instead of hardcoded value
* BREAKING: use configured DNS sleep time for Linode v4 instead of hardcoded value
* BREAKING: use configured DNS sleep time for Netcup instead of hardcoded value
2.1
security/acme-client/src/opnsense/mvc/app/controllers/OPNsense/AcmeClient/forms/dialogValidation.xml
+20
View File
@@ -603,6 +603,11 @@
<type>header</type>
<style>table_dns table_dns_lexicon</style>
</field>
<field>
<label>NOTE: A DNS sleep time of at least 1000 may be required.</label>
<type>header</type>
<style>table_dns table_dns_lexicon</style>
</field>
<field>
<id>validation.dns_lexicon_provider</id>
<label>Provider</label>
@@ -623,6 +628,11 @@
<type>header</type>
<style>table_dns table_dns_linode</style>
</field>
<field>
<label>NOTE: A DNS sleep time of at least 1000 is recommended.</label>
<type>header</type>
<style>table_dns table_dns_linode</style>
</field>
<field>
<id>validation.dns_linode_key</id>
<label>Key</label>
@@ -633,6 +643,11 @@
<type>header</type>
<style>table_dns table_dns_linode_v4</style>
</field>
<field>
<label>NOTE: A DNS sleep time of at least 1000 is recommended.</label>
<type>header</type>
<style>table_dns table_dns_linode_v4</style>
</field>
<field>
<id>validation.dns_linode_v4_key</id>
<label>Key</label>
@@ -767,6 +782,11 @@
<type>header</type>
<style>table_dns table_dns_netcup</style>
</field>
<field>
<label>NOTE: A DNS sleep time of at least 600 is recommended.</label>
<type>header</type>
<style>table_dns table_dns_netcup</style>
</field>
<field>
<id>validation.dns_netcup_cid</id>
<label>Customer number</label>
security/acme-client/src/opnsense/mvc/app/library/OPNsense/AcmeClient/LeValidation/DnsLexicon.php
-5
View File
@@ -46,10 +46,5 @@ class DnsLexicon extends Base implements LeValidationInterface
$this->acme_env['PROVIDER'] = $provider;
$this->acme_env[$env_user] = (string)$this->config->dns_lexicon_user;
$this->acme_env[$env_token] = (string)$this->config->dns_lexicon_token;
if ((string)$this->config->dns_lexicon_provider == 'namesilo') {
// Namesilo applies changes to DNS records only every 15 minutes.
$this->acme_args[] = '--dnssleep 960';
}
}
}
security/acme-client/src/opnsense/mvc/app/library/OPNsense/AcmeClient/LeValidation/DnsLinode.php
-2
View File
@@ -40,7 +40,5 @@ class DnsLinode extends Base implements LeValidationInterface
public function prepare()
{
$this->acme_env['LINODE_API_KEY'] = (string)$this->config->dns_linode_key;
// Linode can take up to 15 to update DNS records
$this->acme_args[] = '--dnssleep 960';
}
}
security/acme-client/src/opnsense/mvc/app/library/OPNsense/AcmeClient/LeValidation/DnsLinodeV4.php
-2
View File
@@ -40,7 +40,5 @@ class DnsLinodeV4 extends Base implements LeValidationInterface
public function prepare()
{
$this->acme_env['LINODE_V4_API_KEY'] = (string)$this->config->dns_linode_v4_key;
// Linode can take up to 15 to update DNS records
$this->acme_args[] = '--dnssleep 960';
}
}
security/acme-client/src/opnsense/mvc/app/library/OPNsense/AcmeClient/LeValidation/DnsNetcup.php
-2
View File
@@ -42,7 +42,5 @@ class DnsNetcup extends Base implements LeValidationInterface
$this->acme_env['NC_CID'] = (string)$this->config->dns_netcup_cid;
$this->acme_env['NC_Apikey'] = (string)$this->config->dns_netcup_key;
$this->acme_env['NC_Apipw'] = (string)$this->config->dns_netcup_pw;
// netcup applies changes to DNS records only every 10 minutes.
$this->acme_args[] = '--dnssleep 600';
}
}