netbird/management-refactor
0
0
Fork 0
mirror of https://github.com/netbirdio/management-refactor.git synced 2026-05-22 17:12:59 -07:00
Code Issues Packages Projects Releases Wiki Activity

proper permission validate wrapper

Browse Source
This commit is contained in:
Pascal Fischer
2025-06-06 19:01:20 +02:00
parent b5853c43f2
commit a17e5a58b2
1 changed files with 10 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files
internals/shared/permissions/manager.go
+10 -14
View File
@@ -116,36 +116,32 @@ type PermissionValidator interface {
}
// WithPermission wraps an HTTP handler with permission checking logic.
func WithPermission(
func (m *managerImpl) WithPermission(
module modules.Module,
operation operations.Operation,
authExtractor UserAuthExtractor,
validator PermissionValidator,
handlerFunc func(w http.ResponseWriter, r *http.Request, auth *nbcontext.UserAuth),
) http.HandlerFunc {
return func(w http.ResponseWriter, r *http.Request) {
ctx := r.Context()
userAuth, err := authExtractor(ctx)
userAuth, err := nbcontext.GetUserAuthFromContext(r.Context())
if err != nil {
log.WithContext(ctx).Errorf("failed to get user auth from context: %v", err)
util.WriteError(ctx, err, w)
log.WithContext(r.Context()).Errorf("failed to get user auth from context: %v", err)
util.WriteError(r.Context(), err, w)
return
}
allowed, err := validator.ValidateUserPermissions(ctx, userAuth.AccountId, userAuth.UserId, module, operation)
allowed, err := m.ValidateUserPermissions(r.Context(), userAuth.AccountId, userAuth.UserId, module, operation)
if err != nil {
log.WithContext(ctx).Errorf("failed to validate permissions for user %s on account %s: %v", userAuth.UserId, userAuth.AccountId, err)
util.WriteError(ctx, status.NewPermissionValidationError(err), w)
log.WithContext(r.Context()).Errorf("failed to validate permissions for user %s on account %s: %v", userAuth.UserId, userAuth.AccountId, err)
util.WriteError(r.Context(), status.NewPermissionValidationError(err), w)
return
}
if !allowed {
log.WithContext(ctx).Tracef("user %s on account %s is not allowed to %s in %s", userAuth.UserId, userAuth.AccountId, operation, module)
util.WriteError(ctx, status.NewPermissionDeniedError(), w)
log.WithContext(r.Context()).Tracef("user %s on account %s is not allowed to %s in %s", userAuth.UserId, userAuth.AccountId, operation, module)
util.WriteError(r.Context(), status.NewPermissionDeniedError(), w)
return
}
handlerFunc(w, r, userAuth)
handlerFunc(w, r, &userAuth)
}
}