Don't dereference errors passed to panic()

These errors are always pointers; there's no sense in dereferencing them
in the panic call. Changed one false positive for clarity.

PiperOrigin-RevId: 263611579

pkg/tcpip/transport/icmp/endpoint_state.go

@@ -78,7 +78,7 @@ func (e *endpoint) Resume(s *stack.Stack) {
 	if e.state == stateConnected {
 		e.route, err = e.stack.FindRoute(e.regNICID, e.bindAddr, e.id.RemoteAddress, e.netProto, false /* multicastLoop */)
 		if err != nil {
-			panic(*err)
+			panic(err)
 		}
 
 		e.id.LocalAddress = e.route.LocalAddress
@@ -90,6 +90,6 @@ func (e *endpoint) Resume(s *stack.Stack) {
 
 	e.id, err = e.registerWithStack(e.regNICID, []tcpip.NetworkProtocolNumber{e.netProto}, e.id)
 	if err != nil {
-		panic(*err)
+		panic(err)
 	}
 }

pkg/tcpip/transport/raw/endpoint_state.go

@@ -75,7 +75,7 @@ func (ep *endpoint) Resume(s *stack.Stack) {
 		var err *tcpip.Error
 		ep.route, err = ep.stack.FindRoute(ep.registeredNIC, ep.boundAddr, ep.route.RemoteAddress, ep.netProto, false)
 		if err != nil {
-			panic(*err)
+			panic(err)
 		}
 	}
 
@@ -87,6 +87,6 @@ func (ep *endpoint) Resume(s *stack.Stack) {
 	}
 
 	if err := ep.stack.RegisterRawTransportEndpoint(ep.registeredNIC, ep.netProto, ep.transProto, ep); err != nil {
-		panic(*err)
+		panic(err)
 	}
 }

pkg/tcpip/transport/udp/endpoint_state.go

@@ -95,7 +95,7 @@ func (e *endpoint) Resume(s *stack.Stack) {
 	if e.state == stateConnected {
 		e.route, err = e.stack.FindRoute(e.regNICID, e.id.LocalAddress, e.id.RemoteAddress, netProto, e.multicastLoop)
 		if err != nil {
-			panic(*err)
+			panic(err)
 		}
 	} else if len(e.id.LocalAddress) != 0 { // stateBound
 		if e.stack.CheckLocalAddress(e.regNICID, netProto, e.id.LocalAddress) == 0 {
@@ -110,6 +110,6 @@ func (e *endpoint) Resume(s *stack.Stack) {
 	e.id.LocalPort = 0
 	e.id, err = e.registerWithStack(e.regNICID, e.effectiveNetProtos, id)
 	if err != nil {
-		panic(*err)
+		panic(err)
 	}
 }