netbird/gvisor
0
0
Fork 0
mirror of https://github.com/netbirdio/gvisor.git synced 2026-05-22 17:12:49 -07:00
Code Issues Packages Projects Releases Wiki Activity

Remove expectation that IP header ID field is non-zero

Browse Source 
This expectation doesn't match the code, which produces ID field values by
incrementing a counter which can roll over. Linux also does not guarantee
non-zero ID fields.

Fixes #8340

PiperOrigin-RevId: 499570695
This commit is contained in:
Alex Konradi
2023-01-04 13:55:27 -08:00
committed by gVisor bot
parent b096b98d6f
commit f75c1470c9
1 changed files with 0 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
test/syscalls/linux/raw_socket_hdrincl.cc
-6
View File
@@ -272,9 +272,6 @@ TEST_F(RawHDRINCL, SendAndReceive) {
// The network stack should have set the source address.
EXPECT_EQ(src.sin_family, AF_INET);
EXPECT_EQ(absl::gbswap_32(src.sin_addr.s_addr), INADDR_LOOPBACK);
// The packet ID should not be 0, as the packet has DF=0.
struct iphdr* iphdr = reinterpret_cast<struct iphdr*>(recv_buf);
EXPECT_NE(iphdr->id, 0);
}
// Send and receive a packet where the sendto address is not the same as the
@@ -324,10 +321,8 @@ TEST_F(RawHDRINCL, SendAndReceiveDifferentAddress) {
// The network stack should have set the source address.
EXPECT_EQ(src.sin_family, AF_INET);
EXPECT_EQ(absl::gbswap_32(src.sin_addr.s_addr), INADDR_LOOPBACK);
// The packet ID should not be 0, as the packet has DF=0.
struct iphdr recv_iphdr = {};
memcpy(&recv_iphdr, recv_buf, sizeof(recv_iphdr));
EXPECT_NE(recv_iphdr.id, 0);
// The destination address is kUnreachable despite arriving via loopback.
EXPECT_EQ(recv_iphdr.daddr, kUnreachable);
}
@@ -386,7 +381,6 @@ TEST_F(RawHDRINCL, SendAndReceiveIPHdrIncl) {
EXPECT_EQ(absl::gbswap_32(src.sin_addr.s_addr), INADDR_LOOPBACK);
struct iphdr iphdr = {};
memcpy(&iphdr, recv_buf, sizeof(iphdr));
EXPECT_NE(iphdr.id, 0);
// Also verify that the packet we just sent was not delivered to the
// IPPROTO_RAW socket.