netbird/gvisor
0
0
Fork 0
mirror of https://github.com/netbirdio/gvisor.git synced 2026-05-22 17:12:49 -07:00
Code Issues Packages Projects Releases Wiki Activity

Set disable_file_handle_sharing for NFS mounts.

Browse Source 
The gofer client caches remote file handles for performance reasons (to reduce
Open RPCs). However, remote filesystems like NFS rely on close(2) syscall for
flushing file data to the server. Due to remote file handle caching, the
application's close(2) syscall is not propagated to the host and file data is
not flushed.

disable_file_handle_sharing prevents the remote file handle from being cached.

PiperOrigin-RevId: 583116138
This commit is contained in:
Ayush Ranjan
2023-11-16 11:51:47 -08:00
committed by gVisor bot
parent 7f5733ea38
commit e60464fdfa
1 changed files with 10 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
runsc/cmd/gofer.go
+10 -2
View File
@@ -656,7 +656,7 @@ func resolveSymlinksImpl(root, base, rel string, followCount uint) (string, erro
return base, nil
}
// adjustMountOptions adds 'overlayfs_stale_read' if mounting over overlayfs.
// adjustMountOptions adds filesystem-specific gofer mount options.
func adjustMountOptions(conf *config.Config, path string, opts []string) ([]string, error) {
rv := make([]string, len(opts))
copy(rv, opts)
@@ -665,8 +665,16 @@ func adjustMountOptions(conf *config.Config, path string, opts []string) ([]stri
if err := unix.Statfs(path, &statfs); err != nil {
return nil, err
}
if statfs.Type == unix.OVERLAYFS_SUPER_MAGIC {
switch statfs.Type {
case unix.OVERLAYFS_SUPER_MAGIC:
rv = append(rv, "overlayfs_stale_read")
case unix.NFS_SUPER_MAGIC:
// The gofer client implements remote file handle sharing for performance.
// However, remote filesystems like NFS rely on close(2) syscall for
// flushing file data to the server. Such handle sharing prevents the
// application's close(2) syscall from being propagated to the host. Hence
// disable file handle sharing, so NFS files are flushed correctly.
rv = append(rv, "disable_file_handle_sharing")
}
return rv, nil
}