netbird/gvisor
0
0
Fork 0
mirror of https://github.com/netbirdio/gvisor.git synced 2026-05-22 17:12:49 -07:00
Code Issues Packages Projects Releases Wiki Activity

Keep symlink target open while in test that compares inode ids.

Browse Source 
Inode ids are only guaranteed to be stable across save/restore if the file is
held open. This CL fixes a simple stat test to allow it to compare symlink and
target by inode id, as long as the link target is held open.

PiperOrigin-RevId: 244238343
Change-Id: I74c5115915b1cc032a4c16515a056a480f218f00
This commit is contained in:
Nicolas Lacasse
2019-04-18 12:39:35 -07:00
committed by Shentubot
parent 133700007a
commit ce64d9ebf0
1 changed files with 16 additions and 22 deletions
Download Patch File Download Diff File Expand all files Collapse all files
test/syscalls/linux/symlink.cc
+16 -22
View File
@@ -151,33 +151,27 @@ TEST(SymlinkTest, NewnameCannotExist) {
}
TEST(SymlinkTest, CanEvaluateLink) {
const std::string oldname = NewTempAbsPath();
const std::string newname = NewTempAbsPath();
const auto file = ASSERT_NO_ERRNO_AND_VALUE(TempPath::CreateFile());
int fd;
ASSERT_THAT(fd = open(oldname.c_str(), O_CREAT | O_RDWR, 0666),
SyscallSucceeds());
struct stat old;
EXPECT_THAT(fstat(fd, &old), SyscallSucceeds());
EXPECT_THAT(close(fd), SyscallSucceeds());
// We are going to assert that the symlink inode id is the same as the linked
// file's inode id. In order for the inode id to be stable across
// save/restore, it must be kept open. The FileDescriptor type will do that
// for us automatically.
auto fd = ASSERT_NO_ERRNO_AND_VALUE(Open(file.path(), O_RDWR));
struct stat file_st;
EXPECT_THAT(fstat(fd.get(), &file_st), SyscallSucceeds());
EXPECT_THAT(symlink(oldname.c_str(), newname.c_str()), SyscallSucceeds());
EXPECT_EQ(FilePermission(newname), 0777);
const std::string link = NewTempAbsPath();
EXPECT_THAT(symlink(file.path().c_str(), link.c_str()), SyscallSucceeds());
EXPECT_EQ(FilePermission(link), 0777);
EXPECT_THAT(fd = open(newname.c_str(), O_RDWR, 0666), SyscallSucceeds());
struct stat old_linked;
EXPECT_THAT(fstat(fd, &old_linked), SyscallSucceeds());
EXPECT_THAT(close(fd), SyscallSucceeds());
auto linkfd = ASSERT_NO_ERRNO_AND_VALUE(Open(link.c_str(), O_RDWR));
struct stat link_st;
EXPECT_THAT(fstat(linkfd.get(), &link_st), SyscallSucceeds());
// Check that in fact newname points to the file we expect.
// FIXME: use only inodes here once they are consistent,
// but this is better than nothing.
EXPECT_EQ(old.st_dev, old_linked.st_dev);
EXPECT_EQ(old.st_mode, old_linked.st_mode);
EXPECT_EQ(old.st_size, old_linked.st_size);
EXPECT_THAT(unlink(newname.c_str()), SyscallSucceeds());
EXPECT_THAT(unlink(oldname.c_str()), SyscallSucceeds());
EXPECT_EQ(file_st.st_dev, link_st.st_dev);
EXPECT_EQ(file_st.st_ino, link_st.st_ino);
}
TEST(SymlinkTest, TargetIsNotMapped) {