mirror of
https://github.com/netbirdio/gvisor.git
synced 2026-05-22 17:12:49 -07:00
Remove stale TODO
PiperOrigin-RevId: 273630282
This commit is contained in:
committed by
gVisor bot
parent
b9cdbc26bc
commit
a357fe427b
@@ -18,7 +18,6 @@ import (
|
||||
"errors"
|
||||
"fmt"
|
||||
"os"
|
||||
"path"
|
||||
"syscall"
|
||||
|
||||
specs "github.com/opencontainers/runtime-spec/specs-go"
|
||||
@@ -234,13 +233,6 @@ func (cm *containerManager) Start(args *StartArgs, _ *struct{}) error {
|
||||
if args.CID == "" {
|
||||
return errors.New("start argument missing container ID")
|
||||
}
|
||||
// Prevent CIDs containing ".." from confusing the sentry when creating
|
||||
// /containers/<cid> directory.
|
||||
// TODO(b/129293409): Once we have multiple independent roots, this
|
||||
// check won't be necessary.
|
||||
if path.Clean(args.CID) != args.CID {
|
||||
return fmt.Errorf("container ID shouldn't contain directory traversals such as \"..\": %q", args.CID)
|
||||
}
|
||||
if len(args.FilePayload.Files) < 4 {
|
||||
return fmt.Errorf("start arguments must contain stdin, stderr, and stdout followed by at least one file for the container root gofer")
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user