netbird/gvisor
0
0
Fork 0
mirror of https://github.com/netbirdio/gvisor.git synced 2026-05-22 17:12:49 -07:00
Code Issues Packages Projects Releases Wiki Activity

Combine reference count logs into one message.

Browse Source 
Otherwise, races can occur between concurrent logs.

PiperOrigin-RevId: 352086914
This commit is contained in:
Dean Deng
2021-01-15 14:40:26 -08:00
committed by gVisor bot
parent f03144d886
commit 9db126eb65
1 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
pkg/refsvfs2/refs_map.go
+4 -4
View File
@@ -109,8 +109,7 @@ func LogDecRef(obj CheckedObject, refs int64) {
// obj.LogRefs() should be checked before calling logEvent, in order to avoid
// calling any text processing needed to evaluate msg.
func logEvent(obj CheckedObject, msg string) {
log.Infof("[%s %p] %s:", obj.RefType(), obj, msg)
log.Infof(refs_vfs1.FormatStack(refs_vfs1.RecordStack()))
log.Infof("[%s %p] %s:\n%s", obj.RefType(), obj, msg, refs_vfs1.FormatStack(refs_vfs1.RecordStack()))
}
// DoLeakCheck iterates through the live object map and logs a message for each
@@ -122,10 +121,11 @@ func DoLeakCheck() {
defer liveObjectsMu.Unlock()
leaked := len(liveObjects)
if leaked > 0 {
log.Warningf("Leak checking detected %d leaked objects:", leaked)
msg := fmt.Sprintf("Leak checking detected %d leaked objects:\n", leaked)
for obj := range liveObjects {
log.Warningf(obj.LeakMessage())
msg += obj.LeakMessage() + "\n"
}
log.Warningf(msg)
}
}
}