netbird/gvisor
0
0
Fork 0
mirror of https://github.com/netbirdio/gvisor.git synced 2026-05-22 17:12:49 -07:00
Code Issues Packages Projects Releases Wiki Activity

Deflake io_uring syscall tests that depend on IORING_ENTER_GETEVENTS.

Browse Source 
Multiple io_uring syscall tests were flaky because they were expecting
io_uring_enter(2) to block until all operations were complete. But some tests
did not specify IORING_ENTER_GETEVENTS in flags. So io_uring would return early
and process requests async (as expected). The checks in the test would fail,
because they would expect the requests to have been processed and results made
available in the completion queue.

PiperOrigin-RevId: 506400433
This commit is contained in:
Ayush Ranjan
2023-02-01 13:04:13 -08:00
committed by gVisor bot
parent e0b9cf05fe
commit 97c5773564
1 changed files with 6 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
test/syscalls/linux/io_uring.cc
+6 -6
View File
@@ -767,7 +767,7 @@ TEST(IOUringTest, SingleREADVTest) {
uint32_t sq_tail = io_uring->load_sq_tail();
io_uring->store_sq_tail(sq_tail + 1);
int ret = io_uring->Enter(1, 1, 0, nullptr);
int ret = io_uring->Enter(1, 1, IORING_ENTER_GETEVENTS, nullptr);
ASSERT_EQ(ret, 1);
struct io_uring_cqe *cqe = io_uring->get_cqes();
@@ -826,7 +826,7 @@ TEST(IOUringTest, ReadvEmptyFile) {
uint32_t sq_tail = io_uring->load_sq_tail();
io_uring->store_sq_tail(sq_tail + 1);
int ret = io_uring->Enter(1, 1, 0, nullptr);
int ret = io_uring->Enter(1, 1, IORING_ENTER_GETEVENTS, nullptr);
ASSERT_EQ(ret, 1);
struct io_uring_cqe *cqe = io_uring->get_cqes();
@@ -905,7 +905,7 @@ TEST(IOUringTest, ThreeREADVSingleEnterTest) {
ASSERT_EQ(file_sz[1], 17);
ASSERT_EQ(file_sz[2], 26);
int ret = io_uring->Enter(3, 3, 0, nullptr);
int ret = io_uring->Enter(3, 3, IORING_ENTER_GETEVENTS, nullptr);
ASSERT_EQ(ret, 3);
struct io_uring_cqe *cqe = io_uring->get_cqes();
@@ -1094,7 +1094,7 @@ TEST(IOUringTest, ShortReadREADVTest) {
uint32_t sq_tail = io_uring->load_sq_tail();
io_uring->store_sq_tail(sq_tail + 1);
int ret = io_uring->Enter(1, 1, 0, nullptr);
int ret = io_uring->Enter(1, 1, IORING_ENTER_GETEVENTS, nullptr);
ASSERT_EQ(ret, 1);
struct io_uring_cqe *cqe = io_uring->get_cqes();
@@ -1167,7 +1167,7 @@ TEST(IOUringTest, NoReadPermissionsREADVTest) {
uint32_t sq_tail = io_uring->load_sq_tail();
io_uring->store_sq_tail(sq_tail + 1);
int ret = io_uring->Enter(1, 1, 0, nullptr);
int ret = io_uring->Enter(1, 1, IORING_ENTER_GETEVENTS, nullptr);
ASSERT_EQ(ret, 1);
struct io_uring_cqe *cqe = io_uring->get_cqes();
@@ -1247,7 +1247,7 @@ TEST_P(IOUringSqeFieldsTest, READVWithInvalidSqeFieldValue) {
uint32_t sq_tail = io_uring->load_sq_tail();
io_uring->store_sq_tail(sq_tail + 1);
int ret = io_uring->Enter(1, 1, 0, nullptr);
int ret = io_uring->Enter(1, 1, IORING_ENTER_GETEVENTS, nullptr);
ASSERT_EQ(ret, 1);
struct io_uring_cqe *cqe = io_uring->get_cqes();