gonet: Log an error if GetRemoteAddress() fails.

We eat the error, but we should at least log it first.

PiperOrigin-RevId: 495354937
This commit is contained in:
Nicolas Lacasse
2022-12-14 10:41:01 -08:00
committed by gVisor bot
parent e3f77dddd7
commit 92e25882bc
2 changed files with 4 additions and 0 deletions
+1
View File
@@ -7,6 +7,7 @@ go_library(
srcs = ["gonet.go"],
visibility = ["//visibility:public"],
deps = [
"//pkg/log",
"//pkg/sync",
"//pkg/tcpip",
"//pkg/tcpip/stack",
+3
View File
@@ -24,6 +24,7 @@ import (
"net"
"time"
"gvisor.dev/gvisor/pkg/log"
"gvisor.dev/gvisor/pkg/sync"
"gvisor.dev/gvisor/pkg/tcpip"
"gvisor.dev/gvisor/pkg/tcpip/stack"
@@ -453,6 +454,7 @@ func (c *TCPConn) LocalAddr() net.Addr {
func (c *TCPConn) RemoteAddr() net.Addr {
a, err := c.ep.GetRemoteAddress()
if err != nil {
log.Warningf("ep.GetRemoteAddress() failed: %v", err)
return nil
}
return fullToTCPAddr(a)
@@ -621,6 +623,7 @@ func (c *UDPConn) newRemoteOpError(op string, remote net.Addr, err error) *net.O
func (c *UDPConn) RemoteAddr() net.Addr {
a, err := c.ep.GetRemoteAddress()
if err != nil {
log.Warningf("ep.GetRemoteAddress() failed: %v", err)
return nil
}
return fullToUDPAddr(a)