netbird/gvisor
0
0
Fork 0
mirror of https://github.com/netbirdio/gvisor.git synced 2026-05-22 17:12:49 -07:00
Code Issues Packages Projects Releases Wiki Activity

Change timestamp discrepancy warnings to just print info.

Browse Source 
ARM syscall tests sometimes fail on our buildkite test runners with
errors like:

```
main.go:731: test "main.test" failed with error [W0119 17:41:24.540369      38 shared_context.go:196] likely memory tampering detected: found a condition where ackedAt (1160377308938) < startWaitingTS (1160377308943)], want nil
```

Empirically, at least on our VMs `CNTVCT_EL0` is not monotonic.
(We don't see these errors on AMD64 VMs). For now let's disable this
warning as it's leading to unnecessary test reruns.

PiperOrigin-RevId: 599935334
This commit is contained in:
Konstantin Bogomolov
2024-01-19 14:20:18 -08:00
committed by gVisor bot
parent 2de5431306
commit 7d264ac60d
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
pkg/sentry/platform/systrap/shared_context.go
+2 -2
View File
@@ -193,7 +193,7 @@ func (sc *sharedContext) isAcked() bool {
func (sc *sharedContext) getAckedTimeDiff() cpuTicks {
ackedAt := atomic.LoadUint64(&sc.shared.AckedTime)
if ackedAt < uint64(sc.startWaitingTS) {
log.Warningf("likely memory tampering detected: found a condition where ackedAt (%d) < startWaitingTS (%d)", ackedAt, uint64(sc.startWaitingTS))
log.Infof("likely memory tampering detected: found a condition where ackedAt (%d) < startWaitingTS (%d)", ackedAt, uint64(sc.startWaitingTS))
return 0
}
return cpuTicks(ackedAt - uint64(sc.startWaitingTS))
@@ -207,7 +207,7 @@ func (sc *sharedContext) getStateChangedTimeDiff() cpuTicks {
changedAt := atomic.LoadUint64(&sc.shared.StateChangedTime)
now := uint64(cputicks())
if now < changedAt {
log.Warningf("likely memory tampering detected: found a condition where now (%d) < changedAt (%d)", now, changedAt)
log.Infof("likely memory tampering detected: found a condition where now (%d) < changedAt (%d)", now, changedAt)
return 0
}
return cpuTicks(now - changedAt)