netbird/gvisor
0
0
Fork 0
mirror of https://github.com/netbirdio/gvisor.git synced 2026-05-22 17:12:49 -07:00
Code Issues Packages Projects Releases Wiki Activity

Don't log mount.root because it leads to racy access.

Browse Source 
I don't think these logs have been useful in the past anyways.

Reported-by: syzbot+73ebb3f2046b3352bb94@syzkaller.appspotmail.com
PiperOrigin-RevId: 658846904
This commit is contained in:
Nicolas Lacasse
2024-08-02 11:21:47 -07:00
committed by gVisor bot
parent ef1ca17e58
commit 742b914fcb
1 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
pkg/sentry/vfs/mount.go
+4 -4
View File
@@ -1370,7 +1370,7 @@ func (vfs *VirtualFilesystem) GenerateProcMounts(ctx context.Context, taskRootDi
if err != nil {
// For some reason we didn't get a path. Log a warning
// and run with empty path.
ctx.Warningf("VFS.GenerateProcMounts: error getting pathname for mount root %+v: %v", mnt.root, err)
ctx.Warningf("VFS.GenerateProcMounts: error getting pathname for mount root: %v", err)
path = ""
}
if path == "" {
@@ -1437,7 +1437,7 @@ func (vfs *VirtualFilesystem) GenerateProcMountInfo(ctx context.Context, taskRoo
if err != nil {
// For some reason we didn't get a path. Log a warning
// and run with empty path.
ctx.Warningf("VFS.GenerateProcMountInfo: error getting pathname for mount root %+v: %v", mnt.root, err)
ctx.Warningf("VFS.GenerateProcMountInfo: error getting pathname for mount root: %v", err)
continue
}
if pathFromRoot == "" {
@@ -1449,7 +1449,7 @@ func (vfs *VirtualFilesystem) GenerateProcMountInfo(ctx context.Context, taskRoo
if err != nil {
// For some reason we didn't get a path. Log a warning
// and run with empty path.
ctx.Warningf("VFS.GenerateProcMountInfo: error getting pathname for mount root %+v: %v", mnt.root, err)
ctx.Warningf("VFS.GenerateProcMountInfo: error getting pathname for mount root: %v", err)
continue
}
if pathFromFS == "" {
@@ -1464,7 +1464,7 @@ func (vfs *VirtualFilesystem) GenerateProcMountInfo(ctx context.Context, taskRoo
statx, err := vfs.StatAt(ctx, creds, pop, &StatOptions{})
if err != nil {
// Well that's not good. Ignore this mount.
ctx.Warningf("VFS.GenerateProcMountInfo: failed to stat mount root %+v: %v", mnt.root, err)
ctx.Warningf("VFS.GenerateProcMountInfo: failed to stat mount root: %v", err)
continue
}