netbird/gvisor
0
0
Fork 0
mirror of https://github.com/netbirdio/gvisor.git synced 2026-05-22 17:12:49 -07:00
Code Issues Packages Projects Releases Wiki Activity

Assert expected size before unmarshalling

Browse Source 
...to prevent panicking in case of failure.

PiperOrigin-RevId: 354970257
This commit is contained in:
Tamir Duberstein
2021-02-01 10:29:39 -08:00
committed by gVisor bot
parent d930def27a
commit 726100f8eb
1 changed files with 6 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
test/packetimpact/tests/tcp_info_test.go
+6
View File
@@ -55,6 +55,9 @@ func TestTCPInfo(t *testing.T) {
info := linux.TCPInfo{}
infoBytes := dut.GetSockOpt(t, acceptFD, unix.SOL_TCP, unix.TCP_INFO, int32(linux.SizeOfTCPInfo))
if got, want := len(infoBytes), linux.SizeOfTCPInfo; got != want {
t.Fatalf("expected %T, got %d bytes want %d bytes", info, got, want)
}
binary.Unmarshal(infoBytes, usermem.ByteOrder, &info)
rtt := time.Duration(info.RTT) * time.Microsecond
@@ -93,6 +96,9 @@ func TestTCPInfo(t *testing.T) {
info = linux.TCPInfo{}
infoBytes = dut.GetSockOpt(t, acceptFD, unix.SOL_TCP, unix.TCP_INFO, int32(linux.SizeOfTCPInfo))
if got, want := len(infoBytes), linux.SizeOfTCPInfo; got != want {
t.Fatalf("expected %T, got %d bytes want %d bytes", info, got, want)
}
binary.Unmarshal(infoBytes, usermem.ByteOrder, &info)
if info.CaState != linux.TCP_CA_Loss {
t.Errorf("expected the connection to be in loss recovery, got: %v want: %v", info.CaState, linux.TCP_CA_Loss)