netbird/gvisor
0
0
Fork 0
mirror of https://github.com/netbirdio/gvisor.git synced 2026-05-22 17:12:49 -07:00
Code Issues Packages Projects Releases Wiki Activity

setgid: skip tests when we can't find usable GIDs

Browse Source 
PiperOrigin-RevId: 365092320
This commit is contained in:
Kevin Krakauer
2021-03-25 12:00:24 -07:00
committed by gVisor bot
parent c27fac421b
commit 6b085ba477
1 changed files with 7 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files
test/syscalls/linux/setgid.cc
+7 -10
View File
@@ -107,16 +107,7 @@ PosixErrorOr<std::pair<gid_t, gid_t>> Groups() {
if (!capable.ValueOrDie()) {
return PosixError(EPERM, "missing CAP_SETGID");
}
gid_t gid = getegid();
auto cleanup1 = Setegid(gid);
if (!cleanup1.ok()) {
return cleanup1.error();
}
auto cleanup2 = Setegid(kNobody);
if (!cleanup2.ok()) {
return cleanup2.error();
}
return std::pair<gid_t, gid_t>(gid, kNobody);
return std::pair<gid_t, gid_t>(getegid(), kNobody);
}
class SetgidDirTest : public ::testing::Test {
@@ -132,6 +123,12 @@ class SetgidDirTest : public ::testing::Test {
SKIP_IF(!groups.ok());
groups_ = groups.ValueOrDie();
// Ensure we can actually use both groups.
auto cleanup1 = Setegid(groups_.first);
SKIP_IF(!cleanup1.ok());
auto cleanup2 = Setegid(groups_.second);
SKIP_IF(!cleanup2.ok());
auto cleanup = Setegid(groups_.first);
temp_dir_ = ASSERT_NO_ERRNO_AND_VALUE(
TempPath::CreateDirWith(GetAbsoluteTestTmpdir(), 0777 /* mode */));