netbird/gvisor
0
0
Fork 0
mirror of https://github.com/netbirdio/gvisor.git synced 2026-05-22 17:12:49 -07:00
Code Issues Packages Projects Releases Wiki Activity

Kubernetes benchmarks: Create "benchmark" namespace prior to using it.

Browse Source 
Prior to this change, in certain benchmarks, the profiling steps (which
require the existence of the `benchmark` namespace) happened before the
`benchmark` namespace is ever created. This would fail, unless prior
iterations of *other* benchmarks in the same cluster had already created
the `benchmark` namespace. So when running broken benchmarks in their
own individual clusters, they would consistently fail due to the lack of
the `benchmark` namespace.

Now all benchmarks consistently create this namespace first.

(Diffbased)

PiperOrigin-RevId: 702909244
This commit is contained in:
Etienne Perot
2024-12-04 17:03:26 -08:00
committed by gVisor bot
parent f2abd31367
commit 6abc135b3b
4 changed files with 16 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files
test/kubernetes/benchmarks/pytorch.go
+4 -4
View File
@@ -257,15 +257,15 @@ func RunPytorch(ctx context.Context, t *testing.T, k8sCtx k8sctx.KubernetesConte
// doPytorchRun runs a single PyTorch test.
func doPytorchRun(ctx context.Context, t *testing.T, k8sCtx k8sctx.KubernetesContext, cluster *testcluster.TestCluster, params pytorchTest) {
benchmarkNS := cluster.Namespace(testcluster.NamespaceBenchmark)
if err := benchmarkNS.Reset(ctx); err != nil {
t.Fatalf("Failed to reset namespace: %v", err)
}
defer benchmarkNS.Cleanup(ctx)
endProfiling, err := profiling.MaybeSetup(ctx, t, k8sCtx, cluster, benchmarkNS)
if err != nil {
t.Fatalf("Failed to setup profiling: %v", err)
}
defer endProfiling()
if err := benchmarkNS.Reset(ctx); err != nil {
t.Fatalf("Failed to reset namespace: %v", err)
}
defer benchmarkNS.Cleanup(ctx)
image, err := k8sCtx.ResolveImage(ctx, pytorchImage)
if err != nil {
test/kubernetes/benchmarks/startup.go
+4 -4
View File
@@ -48,15 +48,15 @@ func MeasureStartup(ctx context.Context, t *testing.T, k8sCtx k8sctx.KubernetesC
t.Logf("Warning: This is not a meaningful benchmark. Read the comments.")
benchmarkNS := cluster.Namespace(testcluster.NamespaceBenchmark)
if err := benchmarkNS.Reset(ctx); err != nil {
t.Fatalf("cannot reset namespace: %v", err)
}
defer benchmarkNS.Cleanup(ctx)
endProfiling, err := profiling.MaybeSetup(ctx, t, k8sCtx, cluster, benchmarkNS)
if err != nil {
t.Fatalf("Failed to setup profiling: %v", err)
}
defer endProfiling()
if err := benchmarkNS.Reset(ctx); err != nil {
t.Fatalf("cannot reset namespace: %v", err)
}
defer benchmarkNS.Cleanup(ctx)
podName := "startup"
image, err := k8sCtx.ResolveImage(ctx, "alpine")
test/kubernetes/benchmarks/tensorflow.go
+4 -4
View File
@@ -48,15 +48,15 @@ var workloads = map[string]string{
// RunTensorflowOnCPU runs the Tensorflow example workloads on CPU.
func RunTensorflowOnCPU(ctx context.Context, t *testing.T, k8sCtx k8sctx.KubernetesContext, cluster *testcluster.TestCluster) {
benchmarkNS := cluster.Namespace(testcluster.NamespaceBenchmark)
if err := benchmarkNS.Reset(ctx); err != nil {
t.Fatalf("cannot reset namespace: %v", err)
}
defer benchmarkNS.Cleanup(ctx)
endProfiling, err := profiling.MaybeSetup(ctx, t, k8sCtx, cluster, benchmarkNS)
if err != nil {
t.Fatalf("Failed to setup profiling: %v", err)
}
defer endProfiling()
if err := benchmarkNS.Reset(ctx); err != nil {
t.Fatalf("cannot reset namespace: %v", err)
}
defer benchmarkNS.Cleanup(ctx)
const name = "tensorflow"
recorder, err := benchmetric.GetRecorder(ctx)
test/kubernetes/benchmarks/wordpress.go
+4 -4
View File
@@ -60,15 +60,15 @@ var (
// BenchmarkWordpress runs a benchmark of WordPress performance.
func BenchmarkWordpress(ctx context.Context, t *testing.T, k8sCtx k8sctx.KubernetesContext, cluster *testcluster.TestCluster) {
benchmarkNS := cluster.Namespace(testcluster.NamespaceBenchmark)
if err := benchmarkNS.Reset(ctx); err != nil {
t.Fatalf("cannot reset namespace: %v", err)
}
defer benchmarkNS.Cleanup(ctx)
endProfiling, err := profiling.MaybeSetup(ctx, t, k8sCtx, cluster, benchmarkNS)
if err != nil {
t.Fatalf("Failed to setup profiling: %v", err)
}
defer endProfiling()
if err := benchmarkNS.Reset(ctx); err != nil {
t.Fatalf("cannot reset namespace: %v", err)
}
defer benchmarkNS.Cleanup(ctx)
// Create a persistent volume on which to store the database data.
dbVolume := benchmarkNS.GetPersistentVolume(mariaDBVolumeName, "30Gi")