netbird/gvisor
0
0
Fork 0
mirror of https://github.com/netbirdio/gvisor.git synced 2026-05-22 17:12:49 -07:00
Code Issues Packages Projects Releases Wiki Activity

netstack: don't limit buffer size during S/R

Browse Source 
We used to check that buffer sizes didn't exceed the stack limit. However, it's
perfectly valid for a single endpoint's buffer size to be larger than the
systemwide settings via use of forcing sock opts (SO_SNDBUFFORCE and
SO_RCVBUFFORCE).

Tested with --config=gotsan.

PiperOrigin-RevId: 528832810
This commit is contained in:
Kevin Krakauer
2023-05-02 11:05:20 -07:00
committed by gVisor bot
parent 77cf871eda
commit 5607094197
1 changed files with 1 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files
pkg/tcpip/transport/tcp/endpoint_state.go
+1 -18
View File
@@ -136,24 +136,6 @@ func (e *endpoint) Resume(s *stack.Stack) {
e.protocol = protocolFromStack(s)
e.ops.InitHandler(e, e.stack, GetTCPSendBufferLimits, GetTCPReceiveBufferLimits)
e.segmentQueue.thaw()
epState := EndpointState(e.origEndpointState)
switch epState {
case StateInitial, StateBound, StateListen, StateConnecting, StateEstablished:
var ss tcpip.TCPSendBufferSizeRangeOption
if err := e.stack.TransportProtocolOption(ProtocolNumber, &ss); err == nil {
sendBufferSize := e.getSendBufferSize()
if sendBufferSize < ss.Min || sendBufferSize > ss.Max {
panic(fmt.Sprintf("endpoint sendBufferSize %d is outside the min and max allowed [%d, %d]", sendBufferSize, ss.Min, ss.Max))
}
}
var rs tcpip.TCPReceiveBufferSizeRangeOption
if err := e.stack.TransportProtocolOption(ProtocolNumber, &rs); err == nil {
if rcvBufSize := e.ops.GetReceiveBufferSize(); rcvBufSize < int64(rs.Min) || rcvBufSize > int64(rs.Max) {
panic(fmt.Sprintf("endpoint rcvBufSize %d is outside the min and max allowed [%d, %d]", rcvBufSize, rs.Min, rs.Max))
}
}
}
bind := func() {
e.mu.Lock()
@@ -180,6 +162,7 @@ func (e *endpoint) Resume(s *stack.Stack) {
e.setEndpointState(StateBound)
}
epState := EndpointState(e.origEndpointState)
switch {
case epState.connected():
bind()