netbird/gvisor
0
0
Fork 0
mirror of https://github.com/netbirdio/gvisor.git synced 2026-05-22 17:12:49 -07:00
Code Issues Packages Projects Releases Wiki Activity

Use faster marshalling method for non primitive struct fields.

Browse Source 
In autogenerating the implementation of Marshallable.MarshalBytes(), we were
using the slower MarshalBytes(). Instead use MarshalUnsafe which is faster and
falls back to slow MarshalBytes() if the type is not packed.

Even if the outer struct is not packed, we can at least do fast marshalling on
its packed fields.

PiperOrigin-RevId: 408268469
This commit is contained in:
Ayush Ranjan
2021-11-08 00:46:16 -08:00
committed by gVisor bot
parent 4622e17bcc
commit 510bad19b6
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tools/go_marshal/gomarshal/generator_interfaces.go
+2 -2
View File
@@ -132,7 +132,7 @@ func (g *interfaceGenerator) marshalScalar(accessor, typ, bufVar string) {
g.emit("hostarch.ByteOrder.PutUint64(%s[:8], uint64(%s))\n", bufVar, accessor)
g.shift(bufVar, 8)
default:
g.emit("%s = %s.MarshalBytes(%s)\n", bufVar, accessor, bufVar)
g.emit("%s = %s.MarshalUnsafe(%s)\n", bufVar, accessor, bufVar)
}
}
@@ -158,7 +158,7 @@ func (g *interfaceGenerator) unmarshalScalar(accessor, typ, bufVar string) {
g.emit("%s = %s(hostarch.ByteOrder.Uint64(%s[:8]))\n", accessor, typ, bufVar)
g.shift(bufVar, 8)
default:
g.emit("%s = %s.UnmarshalBytes(%s)\n", bufVar, accessor, bufVar)
g.emit("%s = %s.UnmarshalUnsafe(%s)\n", bufVar, accessor, bufVar)
g.recordPotentiallyNonPackedField(accessor)
}
}