mirror of
https://github.com/netbirdio/gvisor.git
synced 2026-05-22 17:12:49 -07:00
Fix long running bazel build jobs.
- Skip the bazel clean command on the last run of the benchmark. - Use --test.benchtime=1ns to force running the benchmark once (https://github.com/golang/go/issues/32051) PiperOrigin-RevId: 347124606
This commit is contained in:
committed by
gVisor bot
parent
be5922fbd2
commit
4b697aae55
@@ -61,10 +61,10 @@ func runBuildBenchmark(b *testing.B, image, workdir, target string) {
|
||||
for _, bm := range benchmarks {
|
||||
pageCache := tools.Parameter{
|
||||
Name: "page_cache",
|
||||
Value: "clean",
|
||||
Value: "dirty",
|
||||
}
|
||||
if bm.clearCache {
|
||||
pageCache.Value = "dirty"
|
||||
pageCache.Value = "clean"
|
||||
}
|
||||
|
||||
filesystem := tools.Parameter{
|
||||
@@ -129,12 +129,14 @@ func runBuildBenchmark(b *testing.B, image, workdir, target string) {
|
||||
if !strings.Contains(got, want) {
|
||||
b.Fatalf("string %s not in: %s", want, got)
|
||||
}
|
||||
// Clean bazel in case we use b.N.
|
||||
_, err = container.Exec(ctx, dockerutil.ExecOpts{
|
||||
WorkDir: prefix + workdir,
|
||||
}, "bazel", "clean")
|
||||
if err != nil {
|
||||
b.Fatalf("build failed with: %v", err)
|
||||
|
||||
// Clean bazel in the case we are doing another run.
|
||||
if i < b.N-1 {
|
||||
if _, err = container.Exec(ctx, dockerutil.ExecOpts{
|
||||
WorkDir: prefix + workdir,
|
||||
}, "bazel", "clean"); err != nil {
|
||||
b.Fatalf("build failed with: %v", err)
|
||||
}
|
||||
}
|
||||
b.StartTimer()
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user