netbird/gvisor
0
0
Fork 0
mirror of https://github.com/netbirdio/gvisor.git synced 2026-05-22 17:12:49 -07:00
Code Issues Packages Projects Releases Wiki Activity

Don't unlink named pipes in pipe test.

Browse Source 
TempPath's destructor runs at the end of the named pipe creation functions,
deleting the named pipe. If the named pipe is backed by a "non-virtual"
filesystem (!fs.Inode.IsVirtual()), this causes the following save attempt to
fail because there are FDs holding the deleted named pipe open.

PiperOrigin-RevId: 308861999
This commit is contained in:
Jamie Liu
2020-04-28 11:28:44 -07:00
committed by gVisor bot
parent ceb3c0e062
commit 4282260355
1 changed files with 17 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files
test/syscalls/linux/pipe.cc
+17 -12
View File
@@ -631,11 +631,14 @@ INSTANTIATE_TEST_SUITE_P(
"namednonblocking",
[](int fds[2], bool* is_blocking, bool* is_namedpipe) {
// Create a new file-based pipe (non-blocking).
auto file = ASSERT_NO_ERRNO_AND_VALUE(TempPath::CreateFile());
ASSERT_THAT(unlink(file.path().c_str()), SyscallSucceeds());
SKIP_IF(mkfifo(file.path().c_str(), 0644) != 0);
fds[0] = open(file.path().c_str(), O_NONBLOCK | O_RDONLY);
fds[1] = open(file.path().c_str(), O_NONBLOCK | O_WRONLY);
std::string path;
{
auto file = ASSERT_NO_ERRNO_AND_VALUE(TempPath::CreateFile());
path = file.path();
}
SKIP_IF(mkfifo(path.c_str(), 0644) != 0);
fds[0] = open(path.c_str(), O_NONBLOCK | O_RDONLY);
fds[1] = open(path.c_str(), O_NONBLOCK | O_WRONLY);
MaybeSave();
*is_blocking = false;
*is_namedpipe = true;
@@ -645,13 +648,15 @@ INSTANTIATE_TEST_SUITE_P(
"namedblocking",
[](int fds[2], bool* is_blocking, bool* is_namedpipe) {
// Create a new file-based pipe (blocking).
auto file = ASSERT_NO_ERRNO_AND_VALUE(TempPath::CreateFile());
ASSERT_THAT(unlink(file.path().c_str()), SyscallSucceeds());
SKIP_IF(mkfifo(file.path().c_str(), 0644) != 0);
ScopedThread t([&file, &fds]() {
fds[1] = open(file.path().c_str(), O_WRONLY);
});
fds[0] = open(file.path().c_str(), O_RDONLY);
std::string path;
{
auto file = ASSERT_NO_ERRNO_AND_VALUE(TempPath::CreateFile());
path = file.path();
}
SKIP_IF(mkfifo(path.c_str(), 0644) != 0);
ScopedThread t(
[&path, &fds]() { fds[1] = open(path.c_str(), O_WRONLY); });
fds[0] = open(path.c_str(), O_RDONLY);
t.Join();
MaybeSave();
*is_blocking = true;