netbird/gvisor
0
0
Fork 0
mirror of https://github.com/netbirdio/gvisor.git synced 2026-05-22 17:12:49 -07:00
Code Issues Packages Projects Releases Wiki Activity

[vfs] Disable inode number equality check for overlayfs.

Browse Source 
Overlayfs does not persist a directory's inode number even while it is mounted.
See fs/overlayfs/inode.c:ovl_map_dev_ino(). VFS2 generates a new inode number
for directories everytime in lookup.

PiperOrigin-RevId: 331045037
This commit is contained in:
Ayush Ranjan
2020-09-10 16:50:18 -07:00
committed by gVisor bot
parent 14e0eb6e0f
commit 365545855f
1 changed files with 18 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
test/syscalls/linux/mount.cc
+18 -4
View File
@@ -147,8 +147,15 @@ TEST(MountTest, UmountDetach) {
// Unmount the tmpfs.
mount.Release()();
const struct stat after2 = ASSERT_NO_ERRNO_AND_VALUE(Stat(dir.path()));
EXPECT_EQ(before.st_ino, after2.st_ino);
// Only check for inode number equality if the directory is not in overlayfs.
// If xino option is not enabled and if all overlayfs layers do not belong to
// the same filesystem then "the value of st_ino for directory objects may not
// be persistent and could change even while the overlay filesystem is
// mounted." -- Documentation/filesystems/overlayfs.txt
if (!ASSERT_NO_ERRNO_AND_VALUE(IsOverlayfs(dir.path()))) {
const struct stat after2 = ASSERT_NO_ERRNO_AND_VALUE(Stat(dir.path()));
EXPECT_EQ(before.st_ino, after2.st_ino);
}
// Can still read file after unmounting.
std::vector<char> buf(sizeof(kContents));
@@ -213,8 +220,15 @@ TEST(MountTest, MountTmpfs) {
}
// Now that dir is unmounted again, we should have the old inode back.
const struct stat after = ASSERT_NO_ERRNO_AND_VALUE(Stat(dir.path()));
EXPECT_EQ(before.st_ino, after.st_ino);
// Only check for inode number equality if the directory is not in overlayfs.
// If xino option is not enabled and if all overlayfs layers do not belong to
// the same filesystem then "the value of st_ino for directory objects may not
// be persistent and could change even while the overlay filesystem is
// mounted." -- Documentation/filesystems/overlayfs.txt
if (!ASSERT_NO_ERRNO_AND_VALUE(IsOverlayfs(dir.path()))) {
const struct stat after = ASSERT_NO_ERRNO_AND_VALUE(Stat(dir.path()));
EXPECT_EQ(before.st_ino, after.st_ino);
}
}
TEST(MountTest, MountTmpfsMagicValIgnored) {