Internal change.

PiperOrigin-RevId: 311645222

test/packetimpact/tests/BUILD

@@ -19,7 +19,7 @@ packetimpact_go_test(
     name = "udp_recv_multicast",
     srcs = ["udp_recv_multicast_test.go"],
     # TODO(b/152813495): Fix netstack then remove the line below.
-    netstack = False,
+    expect_netstack_failure = True,
     deps = [
         "//pkg/tcpip",
         "//pkg/tcpip/header",
@@ -32,7 +32,7 @@ packetimpact_go_test(
     name = "udp_icmp_error_propagation",
     srcs = ["udp_icmp_error_propagation_test.go"],
     # TODO(b/153926291): Fix netstack then remove the line below.
-    netstack = False,
+    expect_netstack_failure = True,
     deps = [
         "//pkg/tcpip",
         "//pkg/tcpip/header",
@@ -116,7 +116,7 @@ packetimpact_go_test(
     name = "tcp_should_piggyback",
     srcs = ["tcp_should_piggyback_test.go"],
     # TODO(b/153680566): Fix netstack then remove the line below.
-    netstack = False,
+    expect_netstack_failure = True,
     deps = [
         "//pkg/tcpip/header",
         "//test/packetimpact/testbench",
@@ -149,7 +149,7 @@ packetimpact_go_test(
     name = "icmpv6_param_problem",
     srcs = ["icmpv6_param_problem_test.go"],
     # TODO(b/153485026): Fix netstack then remove the line below.
-    netstack = False,
+    expect_netstack_failure = True,
     deps = [
         "//pkg/tcpip",
         "//pkg/tcpip/header",

test/packetimpact/tests/defs.bzl

@@ -106,15 +106,15 @@ def packetimpact_netstack_test(
         **kwargs
     )
 
-def packetimpact_go_test(name, size = "small", pure = True, linux = True, netstack = True, **kwargs):
+def packetimpact_go_test(name, size = "small", pure = True, expect_linux_failure = False, expect_netstack_failure = False, **kwargs):
     """Add packetimpact tests written in go.
 
     Args:
         name: name of the test
         size: size of the test
         pure: make a static go binary
-        linux: generate a linux test
-        netstack: generate a netstack test
+        expect_linux_failure: expect the test to fail for Linux
+        expect_netstack_failure: expect the test to fail for Netstack
         **kwargs: all the other args, forwarded to go_test
     """
     testbench_binary = name + "_test"
@@ -127,11 +127,11 @@ def packetimpact_go_test(name, size = "small", pure = True, linux = True, netsta
     )
     packetimpact_linux_test(
         name = name,
-        expect_failure = not linux,
+        expect_failure = expect_linux_failure,
         testbench_binary = testbench_binary,
     )
     packetimpact_netstack_test(
         name = name,
-        expect_failure = not netstack,
+        expect_failure = expect_netstack_failure,
         testbench_binary = testbench_binary,
     )