netbird/gvisor
0
0
Fork 0
mirror of https://github.com/netbirdio/gvisor.git synced 2026-05-22 17:12:49 -07:00
Code Issues Packages Projects Releases Wiki Activity

tmpfs: Handle symlink resolution at root

Browse Source 
Previously we weren't resolving any links when walking a single
component path (i.e. the root of the FS was a symlink).

PiperOrigin-RevId: 485618692
This commit is contained in:
Rahat Mahmood
2022-11-02 09:45:48 -07:00
committed by gVisor bot
parent d4b159ae93
commit 254fedb1d6
1 changed files with 18 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
pkg/sentry/fsimpl/tmpfs/filesystem.go
+18 -4
View File
@@ -133,13 +133,27 @@ func walkParentDirLocked(ctx context.Context, rp *vfs.ResolvingPath, d *dentry)
// Preconditions: filesystem.mu must be locked.
func resolveLocked(ctx context.Context, rp *vfs.ResolvingPath) (*dentry, error) {
d := rp.Start().Impl().(*dentry)
for !rp.Done() {
next, err := stepLocked(ctx, rp, d)
if err != nil {
if symlink, ok := d.inode.impl.(*symlink); rp.Done() && ok && rp.ShouldFollowSymlink() {
// Path with a single component. We don't need to step to the next
// component, but still need to resolve any symlinks.
//
// Symlink traversal updates access time.
d.inode.touchAtime(rp.Mount())
if err := rp.HandleSymlink(symlink.target); err != nil {
return nil, err
}
d = next
} else {
// Path with multiple components, walk and resolve as required.
for !rp.Done() {
next, err := stepLocked(ctx, rp, d)
if err != nil {
return nil, err
}
d = next
}
}
if rp.MustBeDir() && !d.inode.isDir() {
return nil, linuxerr.ENOTDIR
}