netbird/gvisor
0
0
Fork 0
mirror of https://github.com/netbirdio/gvisor.git synced 2026-05-22 17:12:49 -07:00
Code Issues Packages Projects Releases Wiki Activity

Enable hostinet for socket_ipv4_udp_unbound_loopback_test.

Browse Source 
...except for the multicast tests which are broken for reasons I don't yet
understand.

And update the TODO about why socket_ip_unbound_test is flaky on hostinet.

PiperOrigin-RevId: 526733431
This commit is contained in:
Nicolas Lacasse
2023-04-24 13:11:45 -07:00
committed by gVisor bot
parent 2d4ddd93ce
commit 20c0790be5
3 changed files with 51 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
test/syscalls/BUILD
+4 -1
View File
@@ -817,6 +817,7 @@ syscall_test(
syscall_test(
size = "medium",
add_hostinet = True,
test = "//test/syscalls/linux:socket_ipv4_udp_unbound_loopback_test",
)
@@ -846,7 +847,9 @@ syscall_test(
)
syscall_test(
# TODO(b/267210840): Flaky on hostinet.
# TODO(b/275742272): IP_TOS behaves strange on some new kernels, causing
# this to be very flaky on hostinet. Enable this once the strangeness is
# resolved..
# add_hostinet = True,
shard_count = more_shards,
test = "//test/syscalls/linux:socket_ip_unbound_test",
test/syscalls/linux/BUILD
+1
View File
@@ -2653,6 +2653,7 @@ cc_library(
deps = [
":ip_socket_test_util",
"//test/util:socket_util",
"//test/util:test_util",
"@com_google_absl//absl/memory",
gtest,
],
test/syscalls/linux/socket_ipv4_udp_unbound.cc
+46
View File
@@ -25,6 +25,7 @@
#include "gtest/gtest.h"
#include "absl/memory/memory.h"
#include "test/syscalls/linux/ip_socket_test_util.h"
#include "test/util/test_util.h"
namespace gvisor {
namespace testing {
@@ -318,6 +319,9 @@ TEST_P(IPv4UDPUnboundSocketTest, IpMulticastLoopbackIfaceIndexAndAddr) {
// IP_MULTICAST_IF, the send address is specified in sendto, and the group
// membership is configured by address.
TEST_P(IPv4UDPUnboundSocketTest, IpMulticastLoopbackIfAddr) {
// TODO(b/267210840): Get multicast working with hostinet.
SKIP_IF(IsRunningWithHostinet());
auto socket1 = ASSERT_NO_ERRNO_AND_VALUE(NewSocket());
auto socket2 = ASSERT_NO_ERRNO_AND_VALUE(NewSocket());
@@ -372,6 +376,9 @@ TEST_P(IPv4UDPUnboundSocketTest, IpMulticastLoopbackIfAddr) {
// IP_MULTICAST_IF, the send address is specified in sendto, and the group
// membership is configured by NIC ID.
TEST_P(IPv4UDPUnboundSocketTest, IpMulticastLoopbackIfNic) {
// TODO(b/267210840): Get multicast working with hostinet.
SKIP_IF(IsRunningWithHostinet());
auto socket1 = ASSERT_NO_ERRNO_AND_VALUE(NewSocket());
auto socket2 = ASSERT_NO_ERRNO_AND_VALUE(NewSocket());
@@ -426,6 +433,9 @@ TEST_P(IPv4UDPUnboundSocketTest, IpMulticastLoopbackIfNic) {
// IP_MULTICAST_IF, the send address is specified in connect, and the group
// membership is configured by address.
TEST_P(IPv4UDPUnboundSocketTest, IpMulticastLoopbackIfAddrConnect) {
// TODO(b/267210840): Get multicast working with hostinet.
SKIP_IF(IsRunningWithHostinet());
auto socket1 = ASSERT_NO_ERRNO_AND_VALUE(NewSocket());
auto socket2 = ASSERT_NO_ERRNO_AND_VALUE(NewSocket());
@@ -483,6 +493,9 @@ TEST_P(IPv4UDPUnboundSocketTest, IpMulticastLoopbackIfAddrConnect) {
// IP_MULTICAST_IF, the send address is specified in connect, and the group
// membership is configured by NIC ID.
TEST_P(IPv4UDPUnboundSocketTest, IpMulticastLoopbackIfNicConnect) {
// TODO(b/267210840): Get multicast working with hostinet.
SKIP_IF(IsRunningWithHostinet());
auto socket1 = ASSERT_NO_ERRNO_AND_VALUE(NewSocket());
auto socket2 = ASSERT_NO_ERRNO_AND_VALUE(NewSocket());
@@ -540,6 +553,9 @@ TEST_P(IPv4UDPUnboundSocketTest, IpMulticastLoopbackIfNicConnect) {
// IP_MULTICAST_IF, the send address is specified in sendto, and the group
// membership is configured by address.
TEST_P(IPv4UDPUnboundSocketTest, IpMulticastLoopbackIfAddrSelf) {
// TODO(b/267210840): Get multicast working with hostinet.
SKIP_IF(IsRunningWithHostinet());
auto socket1 = ASSERT_NO_ERRNO_AND_VALUE(NewSocket());
auto socket2 = ASSERT_NO_ERRNO_AND_VALUE(NewSocket());
@@ -594,6 +610,9 @@ TEST_P(IPv4UDPUnboundSocketTest, IpMulticastLoopbackIfAddrSelf) {
// IP_MULTICAST_IF, the send address is specified in sendto, and the group
// membership is configured by NIC ID.
TEST_P(IPv4UDPUnboundSocketTest, IpMulticastLoopbackIfNicSelf) {
// TODO(b/267210840): Get multicast working with hostinet.
SKIP_IF(IsRunningWithHostinet());
auto socket1 = ASSERT_NO_ERRNO_AND_VALUE(NewSocket());
auto socket2 = ASSERT_NO_ERRNO_AND_VALUE(NewSocket());
@@ -648,6 +667,9 @@ TEST_P(IPv4UDPUnboundSocketTest, IpMulticastLoopbackIfNicSelf) {
// IP_MULTICAST_IF, the send address is specified in connect, and the group
// membership is configured by address.
TEST_P(IPv4UDPUnboundSocketTest, IpMulticastLoopbackIfAddrSelfConnect) {
// TODO(b/267210840): Get multicast working with hostinet.
SKIP_IF(IsRunningWithHostinet());
auto socket1 = ASSERT_NO_ERRNO_AND_VALUE(NewSocket());
auto socket2 = ASSERT_NO_ERRNO_AND_VALUE(NewSocket());
@@ -703,6 +725,9 @@ TEST_P(IPv4UDPUnboundSocketTest, IpMulticastLoopbackIfAddrSelfConnect) {
// IP_MULTICAST_IF, the send address is specified in connect, and the group
// membership is configured by NIC ID.
TEST_P(IPv4UDPUnboundSocketTest, IpMulticastLoopbackIfNicSelfConnect) {
// TODO(b/267210840): Get multicast working with hostinet.
SKIP_IF(IsRunningWithHostinet());
auto socket1 = ASSERT_NO_ERRNO_AND_VALUE(NewSocket());
auto socket2 = ASSERT_NO_ERRNO_AND_VALUE(NewSocket());
@@ -758,6 +783,9 @@ TEST_P(IPv4UDPUnboundSocketTest, IpMulticastLoopbackIfNicSelfConnect) {
// IP_MULTICAST_IF, the send address is specified in sendto, and the group
// membership is configured by address.
TEST_P(IPv4UDPUnboundSocketTest, IpMulticastLoopbackIfAddrSelfNoLoop) {
// TODO(b/267210840): Get multicast working with hostinet.
SKIP_IF(IsRunningWithHostinet());
auto socket1 = ASSERT_NO_ERRNO_AND_VALUE(NewSocket());
auto socket2 = ASSERT_NO_ERRNO_AND_VALUE(NewSocket());
@@ -816,6 +844,9 @@ TEST_P(IPv4UDPUnboundSocketTest, IpMulticastLoopbackIfAddrSelfNoLoop) {
// IP_MULTICAST_IF, the send address is specified in sendto, and the group
// membership is configured by NIC ID.
TEST_P(IPv4UDPUnboundSocketTest, IpMulticastLoopbackIfNicSelfNoLoop) {
// TODO(b/267210840): Get multicast working with hostinet.
SKIP_IF(IsRunningWithHostinet());
auto socket1 = ASSERT_NO_ERRNO_AND_VALUE(NewSocket());
auto socket2 = ASSERT_NO_ERRNO_AND_VALUE(NewSocket());
@@ -1014,6 +1045,9 @@ TEST_P(IPv4UDPUnboundSocketTest, TestTwoSocketsJoinSameMulticastGroup) {
// Check that two sockets can join the same multicast group at the same time,
// and both will receive data on it.
TEST_P(IPv4UDPUnboundSocketTest, TestMcastReceptionOnTwoSockets) {
// TODO(b/267210840): Get multicast working with hostinet.
SKIP_IF(IsRunningWithHostinet());
std::unique_ptr<SocketPair> socket_pairs[2] = {
std::make_unique<FDSocketPair>(ASSERT_NO_ERRNO_AND_VALUE(NewSocket()),
ASSERT_NO_ERRNO_AND_VALUE(NewSocket())),
@@ -1087,6 +1121,9 @@ TEST_P(IPv4UDPUnboundSocketTest, TestMcastReceptionOnTwoSockets) {
// memberships one by one will continue to deliver packets to both sockets until
// both memberships have been dropped.
TEST_P(IPv4UDPUnboundSocketTest, TestMcastReceptionWhenDroppingMemberships) {
// TODO(b/267210840): Get multicast working with hostinet.
SKIP_IF(IsRunningWithHostinet());
std::unique_ptr<SocketPair> socket_pairs[2] = {
std::make_unique<FDSocketPair>(ASSERT_NO_ERRNO_AND_VALUE(NewSocket()),
ASSERT_NO_ERRNO_AND_VALUE(NewSocket())),
@@ -1184,6 +1221,9 @@ TEST_P(IPv4UDPUnboundSocketTest, TestMcastReceptionWhenDroppingMemberships) {
// Check that a receiving socket can bind to the multicast address before
// joining the group and receive data once the group has been joined.
TEST_P(IPv4UDPUnboundSocketTest, TestBindToMcastThenJoinThenReceive) {
// TODO(b/267210840): Get multicast working with hostinet.
SKIP_IF(IsRunningWithHostinet());
auto socket1 = ASSERT_NO_ERRNO_AND_VALUE(NewSocket());
auto socket2 = ASSERT_NO_ERRNO_AND_VALUE(NewSocket());
@@ -1234,6 +1274,9 @@ TEST_P(IPv4UDPUnboundSocketTest, TestBindToMcastThenJoinThenReceive) {
// Check that a receiving socket can bind to the multicast address and won't
// receive multicast data if it hasn't joined the group.
TEST_P(IPv4UDPUnboundSocketTest, TestBindToMcastThenNoJoinThenNoReceive) {
// TODO(b/267210840): Get multicast working with hostinet.
SKIP_IF(IsRunningWithHostinet());
auto socket1 = ASSERT_NO_ERRNO_AND_VALUE(NewSocket());
auto socket2 = ASSERT_NO_ERRNO_AND_VALUE(NewSocket());
@@ -2192,6 +2235,9 @@ TEST_P(IPv4UDPUnboundSocketTest, SetSocketSendBuf) {
}
TEST_P(IPv4UDPUnboundSocketTest, IpMulticastIPPacketInfo) {
// TODO(b/267210840): Get multicast working with hostinet.
SKIP_IF(IsRunningWithHostinet());
auto sender_socket = ASSERT_NO_ERRNO_AND_VALUE(NewSocket());
auto receiver_socket = ASSERT_NO_ERRNO_AND_VALUE(NewSocket());