netbird/gvisor
0
0
Fork 0
mirror of https://github.com/netbirdio/gvisor.git synced 2026-05-22 17:12:49 -07:00
Code Issues Packages Projects Releases Wiki Activity

Fix rename error handling for VFS2 kernfs.

Browse Source 
The non-errno error was causing panics before.

PiperOrigin-RevId: 339969348
This commit is contained in:
Dean Deng
2020-10-30 17:42:57 -07:00
committed by gVisor bot
parent ba05c6845d
commit 1f25697cfe
1 changed files with 1 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files
pkg/sentry/fsimpl/kernfs/inode_impl_util.go
+1 -8
View File
@@ -568,13 +568,6 @@ func (o *OrderedChildren) RmDir(ctx context.Context, name string, child Inode) e
return o.Unlink(ctx, name, child)
}
// +stateify savable
type renameAcrossDifferentImplementationsError struct{}
func (renameAcrossDifferentImplementationsError) Error() string {
return "rename across inodes with different implementations"
}
// Rename implements Inode.Rename.
//
// Precondition: Rename may only be called across two directory inodes with
@@ -587,7 +580,7 @@ func (renameAcrossDifferentImplementationsError) Error() string {
func (o *OrderedChildren) Rename(ctx context.Context, oldname, newname string, child, dstDir Inode) error {
dst, ok := dstDir.(interface{}).(*OrderedChildren)
if !ok {
return renameAcrossDifferentImplementationsError{}
return syserror.ENODEV
}
if !o.writable || !dst.writable {
return syserror.EPERM