netbird/gvisor
0
0
Fork 0
mirror of https://github.com/netbirdio/gvisor.git synced 2026-05-22 17:12:49 -07:00
Code Issues Packages Projects Releases Wiki Activity

Decommit huge-page-aligned regions during reclaim under manual zeroing.

Browse Source 
PiperOrigin-RevId: 378546551
This commit is contained in:
Jamie Liu
2021-06-09 18:25:17 -07:00
committed by gVisor bot
parent 3fb646ed10
commit 0c37626a07
1 changed files with 14 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
pkg/sentry/pgalloc/pgalloc.go
+14 -4
View File
@@ -1062,10 +1062,20 @@ func (f *MemoryFile) runReclaim() {
break
}
// If ManualZeroing is in effect, pages will be zeroed on allocation
// and may not be freed by decommitFile, so calling decommitFile is
// unnecessary.
if !f.opts.ManualZeroing {
if f.opts.ManualZeroing {
// If ManualZeroing is in effect, only hugepage-aligned regions may
// be safely passed to decommitFile. Pages will be zeroed on
// reallocation, so we don't need to perform any manual zeroing
// here, whether or not decommitFile succeeds.
if startAddr, ok := hostarch.Addr(fr.Start).HugeRoundUp(); ok {
if endAddr := hostarch.Addr(fr.End).HugeRoundDown(); startAddr < endAddr {
decommitFR := memmap.FileRange{uint64(startAddr), uint64(endAddr)}
if err := f.decommitFile(decommitFR); err != nil {
log.Warningf("Reclaim failed to decommit %v: %v", decommitFR, err)
}
}
}
} else {
if err := f.decommitFile(fr); err != nil {
log.Warningf("Reclaim failed to decommit %v: %v", fr, err)
// Zero the pages manually. This won't reduce memory usage, but at