netbird/gvisor
0
0
Fork 0
mirror of https://github.com/netbirdio/gvisor.git synced 2026-05-22 17:12:49 -07:00
Code Issues Packages Projects Releases Wiki Activity

sentry: allow saving of unlinked files with open fds on virtual fs.

Browse Source 
PiperOrigin-RevId: 216733414
Change-Id: I33cd3eb818f0c39717d6656fcdfff6050b37ebb0
This commit is contained in:
Zhaozhong Ni
2018-10-11 11:41:44 -07:00
committed by Shentubot
parent 463e73d46d
commit 0bfa03d61c
1 changed files with 9 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
pkg/sentry/fs/dirent_state.go
+9 -5
View File
@@ -23,16 +23,20 @@ import (
// beforeSave is invoked by stateify.
func (d *Dirent) beforeSave() {
// Refuse to save if the file has already been deleted (but still has
// open fds, which is why the Dirent is still accessible). We know the
// the restore opening of the file will always fail. This condition will
// last until all the open fds and this Dirent are closed and released.
// Refuse to save if the file is on a non-virtual file system and has
// already been deleted (but still has open fds, which is why the Dirent
// is still accessible). We know the the restore re-opening of the file
// will always fail. This condition will last until all the open fds and
// this Dirent are closed and released.
//
// Such "dangling" open files on virtual file systems (e.g., tmpfs) is
// OK to save as their restore does not require re-opening the files.
//
// Note that this is rejection rather than failure---it would be
// perfectly OK to save---we are simply disallowing it here to prevent
// generating non-restorable state dumps. As the program continues its
// execution, it may become allowed to save again.
if atomic.LoadInt32(&d.deleted) != 0 {
if !d.Inode.IsVirtual() && atomic.LoadInt32(&d.deleted) != 0 {
n, _ := d.FullName(nil /* root */)
panic(ErrSaveRejection{fmt.Errorf("deleted file %q still has open fds", n)})
}