netbird/gvisor
0
0
Fork 0
mirror of https://github.com/netbirdio/gvisor.git synced 2026-05-22 17:12:49 -07:00
Code Issues Packages Projects Releases Wiki Activity

Remove error message about max_user_namespaces.

Browse Source 
It has not been the real cause of recent failures.

If it turns out to result in new bug reports that do end up being caused by
`max_user_namespaces` being too low, then IMO the proper fix would be to add
a check for this at `runsc` startup time instead of here at process fork/exec
time.

Updates #5964

PiperOrigin-RevId: 659712753
This commit is contained in:
Etienne Perot
2024-08-05 16:07:18 -07:00
committed by gVisor bot
parent dc3506fbee
commit 0237df2fda
1 changed files with 1 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
runsc/specutils/namespace.go
+1 -5
View File
@@ -183,11 +183,7 @@ func startInNS(cmd *exec.Cmd, nss []specs.LinuxNamespace) ([]func() error, error
deferFuncs = append(deferFuncs, restoreNS)
}
err := cmd.Start()
if err != nil && cmd.SysProcAttr.Cloneflags&unix.CLONE_NEWUSER != 0 {
err = fmt.Errorf("%v: check whether /proc/sys/user/max_user_namespaces is set too low (gvisor.dev/issue/5964)", err)
}
return deferFuncs, err
return deferFuncs, cmd.Start()
}
// SetUIDGIDMappings sets the given uid/gid mappings from the spec on the cmd.