netbird/dex
0
0
Fork 0
mirror of https://github.com/netbirdio/dex.git synced 2026-05-22 18:43:53 -07:00
Code Issues Packages Projects Releases Wiki Activity

saml connector: fix nil pointer on validate saml (#3793)

Browse Source 
Signed-off-by: Siarhei Haurylau <siarhei.haurylau@point-devel.com>
This commit is contained in:
siarhei-haurylau
2024-10-14 15:33:59 +02:00
committed by GitHub
parent 749bbd5d98
commit fe08a08923
1 changed files with 4 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
connector/saml/saml.go
+4 -1
View File
@@ -597,6 +597,9 @@ func verifyResponseSig(validator *dsig.ValidationContext, data []byte) (signed [
}
response := doc.Root()
if response == nil {
return nil, false, fmt.Errorf("parse document: empty root")
}
transformedResponse, err := validator.Validate(response)
if err == nil {
// Root element is verified, return it.
@@ -609,7 +612,7 @@ func verifyResponseSig(validator *dsig.ValidationContext, data []byte) (signed [
//
// TODO: Only select from child elements of the root.
assertion, err := etreeutils.NSSelectOne(response, "urn:oasis:names:tc:SAML:2.0:assertion", "Assertion")
if err != nil {
if err != nil || assertion == nil {
return nil, false, fmt.Errorf("response does not contain an Assertion element")
}
transformedAssertion, err := validator.Validate(assertion)