netbird/dex
0
0
Fork 0
mirror of https://github.com/netbirdio/dex.git synced 2026-05-22 18:43:53 -07:00
Code Issues Packages Projects Releases Wiki Activity

fix: always retrieve github emails when preferredEmailDomain is set (#3584)

Browse Source 
Signed-off-by: Mathew Wicks <5735406+thesuperzapper@users.noreply.github.com>
This commit is contained in:
Mathew Wicks
2024-07-15 20:18:26 +02:00
committed by GitHub
parent bd73825eda
commit fb20f3fa32
1 changed files with 4 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
connector/github/github.go
+4 -3
View File
@@ -531,9 +531,10 @@ func (c *githubConnector) user(ctx context.Context, client *http.Client) (user,
return u, err
}
// Only public user emails are returned by 'GET /user'. u.Email will be empty
// if a users' email is private. We must retrieve private emails explicitly.
if u.Email == "" {
// Only public user emails are returned by 'GET /user'.
// If a user has no public email, we must retrieve private emails explicitly.
// If preferredEmailDomain is set, we always need to retrieve all emails.
if u.Email == "" || c.preferredEmailDomain != "" {
var err error
if u.Email, err = c.userEmail(ctx, client); err != nil {
return u, err