netbird/dex
0
0
Fork 0
mirror of https://github.com/netbirdio/dex.git synced 2026-05-22 18:43:53 -07:00
Code Issues Packages Projects Releases Wiki Activity

Do not escape password for LDAP connectors (#3470)

Browse Source 
With the change introduced in https://github.com/dexidp/dex/pull/3372 Dex declines passwords that contain special characters. Since password is not passed to any kind of filters, it is safe to pass a password as is. No LDAP query injections are possible.

This commit is a revert of password escaping.

Signed-off-by: m.nabokikh <maksim.nabokikh@flant.com>
This commit is contained in:
Maksim Nabokikh
2024-04-09 13:05:06 +02:00
committed by GitHub
parent 98980cad79
commit 3705207f01
1 changed files with 0 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
connector/ldap/ldap.go
-1
View File
@@ -473,7 +473,6 @@ func (c *ldapConnector) Login(ctx context.Context, s connector.Scopes, username,
)
username = ldap.EscapeFilter(username)
password = ldap.EscapeFilter(password)
err = c.do(ctx, func(conn *ldap.Conn) error {
entry, found, err := c.userEntry(conn, username)