netbird/android-client
0
0
Fork 0
mirror of https://github.com/netbirdio/android-client.git synced 2026-05-22 17:10:49 -07:00
Code Issues Packages Projects Releases Wiki Activity

bug: bottom dialog fragment attached not attached to activity (#117)

Browse Source 
* Remove onClickListener from peersBtn

When HomeFragment is destroyed

* Remove unused imports

* Check if BottomDialogFragment is attached to Activity

When setting its onShowListener
This commit is contained in:
Diego Romar
2025-12-01 16:41:22 -03:00
committed by GitHub
parent f9376e3991
commit bf4ece69cd
2 changed files with 7 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
app/src/main/java/io/netbird/client/ui/home/BottomDialogFragment.java
+5
View File
@@ -45,6 +45,11 @@ public class BottomDialogFragment extends com.google.android.material.bottomshee
// Apply transparent background theme to the dialog
BottomSheetDialog dialog = new BottomSheetDialog(requireContext(), R.style.BottomSheetDialogTheme);
dialog.setOnShowListener(dialogInterface -> {
// Check if the fragment is still attached to avoid IllegalStateException
if (getActivity() == null || !isAdded()) {
return;
}
FrameLayout bottomSheet = dialog.findViewById(com.google.android.material.R.id.design_bottom_sheet);
if (bottomSheet != null) {
// Set the bottom sheet to be full screen
app/src/main/java/io/netbird/client/ui/home/HomeFragment.java
+2 -2
View File
@@ -11,7 +11,6 @@ import android.widget.FrameLayout;
import android.widget.TextView;
import androidx.annotation.NonNull;
import androidx.appcompat.app.AlertDialog;
import androidx.fragment.app.Fragment;
import com.airbnb.lottie.LottieAnimationView;
@@ -22,7 +21,6 @@ import io.netbird.client.ServiceAccessor;
import io.netbird.client.StateListener;
import io.netbird.client.StateListenerRegistry;
import io.netbird.client.databinding.FragmentHomeBinding;
import io.netbird.client.ui.PreferenceUI;
import io.netbird.gomobile.android.PeerInfo;
import io.netbird.gomobile.android.PeerInfoArray;
@@ -126,6 +124,8 @@ public class HomeFragment extends Fragment implements StateListener {
super.onDestroyView();
buttonAnimation.destroy();
stateListenerRegistry.unregisterServiceStateListener(this);
FrameLayout openPanelCardView = binding.peersBtn;
openPanelCardView.setOnClickListener(null);
binding = null;
}