Publish GHSA-733v-p3h5-qpq7

2026-05-22 18:04:22 -07:00 · 2025-04-25 15:16:31 +00:00
parent 3a55309f56
commit 82322b1ecd
1 changed files with 64 additions and 0 deletions
@@ -0,0 +1,64 @@
+{
+  "schema_version": "1.4.0",
+  "id": "GHSA-733v-p3h5-qpq7",
+  "modified": "2025-04-25T15:14:36Z",
+  "published": "2025-04-25T15:14:36Z",
+  "aliases": [],
+  "summary": "GraphQL Armor Cost-Limit Plugin Bypass via Introspection Query Obfuscation",
+  "details": "### Summary\nA query cost restriction using the `cost-limit` can be bypassed if `ignoreIntrospection` is enabled (which is the default configuration) by naming your query/fragment `__schema`.\n\n### Details\nAt the start of the `computeComplexity` function, we have the following check for `ignoreIntrospection` option:\n\n```ts\n    if (this.config.ignoreIntrospection && 'name' in node && node.name?.value === '__schema') {\n      return 0;\n    }\n```\n\nHowever, the `node` can be `FieldNode | FragmentDefinitionNode | InlineFragmentNode | OperationDefinitionNode | FragmentSpreadNode`\n\nSo, for example, sending the following query\n\n```gql\nquery hello {\n  books {\n    title\n  }\n}\n```\n\nwould create an `OperationDefinitionNode` with `node.name.value == 'hello'`\n\nThe proper way to handle this would be to check for the `__schema` field, which would create a `FieldNode`.\n\nThe fix is\n\n```ts\n    if (\n      this.config.ignoreIntrospection &&\n      'name' in node &&\n      node.name?.value === '__schema' &&\n      node.kind === Kind.FIELD\n    ) {\n      return 0;\n    }\n```\n\nto assert that the node must be a `FieldNode`\n\n### PoC\n```gql\nquery  {\n  ...__schema\n}\n\nfragment __schema on Query {\n  books {\n    title\n    author\n  }\n}\n```\n\n```gql\nquery __schema {\n  books {\n    title\n    author\n  }\n}\n```\n\n### Impact\nApplications using GraphQL Armor Cost Limit plugin with `ignoreIntrospection` enabled.\n\n### Fix:\nFixed on [772](https://github.com/Escape-Technologies/graphql-armor/pull/772). A quick patch would be to set `ignoreIntrospection` to false.",
+  "severity": [
+    {
+      "type": "CVSS_V3",
+      "score": "CVSS:3.0/AV:N/AC:L/PR:N/UI:N/S:U/C:N/I:N/A:L"
+    }
+  ],
+  "affected": [
+    {
+      "package": {
+        "ecosystem": "npm",
+        "name": "@escape.tech/graphql-armor-cost-limit"
+      },
+      "ranges": [
+        {
+          "type": "ECOSYSTEM",
+          "events": [
+            {
+              "introduced": "0"
+            },
+            {
+              "last_affected": "2.4.0"
+            }
+          ]
+        }
+      ]
+    }
+  ],
+  "references": [
+    {
+      "type": "WEB",
+      "url": "https://github.com/Escape-Technologies/graphql-armor/security/advisories/GHSA-733v-p3h5-qpq7"
+    },
+    {
+      "type": "WEB",
+      "url": "https://github.com/Escape-Technologies/graphql-armor/pull/772"
+    },
+    {
+      "type": "WEB",
+      "url": "https://github.com/Escape-Technologies/graphql-armor/commit/5a329541cf32a359ee1f69748738f91231b26eba"
+    },
+    {
+      "type": "PACKAGE",
+      "url": "https://github.com/Escape-Technologies/graphql-armor"
+    }
+  ],
+  "database_specific": {
+    "cwe_ids": [
+      "CWE-400",
+      "CWE-770"
+    ],
+    "severity": "MODERATE",
+    "github_reviewed": true,
+    "github_reviewed_at": "2025-04-25T15:14:36Z",
+    "nvd_published_at": null
+  }
+}