fix: run typos check (#120)

- Fixes a bunch of typos
- Moves gigantic HEX-string represented binaries to separate `*.bin` files in crates\graphics\src\zgfx\mod.rs (it was messing with typos check)

Cargo.lock

@@ -1294,12 +1294,6 @@ version = "0.4.3"
 source = "registry+https://github.com/rust-lang/crates.io-index"
 checksum = "7f24254aa9a54b5c858eaee2f5bccdb46aaf0e486a595ed5fd8f86ba55232a70"
 
-[[package]]
-name = "hex-literal"
-version = "0.3.4"
-source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "7ebdb29d2ea9ed0083cd8cece49bbd968021bd99b0849edb4a9a7ee0fdf6a4e0"
-
 [[package]]
 name = "hmac"
 version = "0.7.1"
@@ -1572,7 +1566,6 @@ dependencies = [
  "bmp",
  "byteorder",
  "expect-test",
- "hex-literal",
  "ironrdp-pdu",
  "lazy_static",
  "num-derive 0.3.3",

crates/client-glutin/src/gui.rs

@@ -119,13 +119,13 @@ pub fn launch_gui(
                     // layout_pdu.to_buffer(&mut data_buffer)?;
                     // if let (Some(x224_processor), Some(stream)) = (x224_processor.as_ref(), stream.as_mut()) {
                     //     let mut x224_processor = x224_processor.lock()?;
-                    //     // Ignorable eror in case of display channel is not connected
+                    //     // Ignorable error in case of display channel is not connected
                     //     let result =
                     //         x224_processor.send_dynamic(&mut *stream, x224::RDP8_DISPLAY_PIPELINE_NAME, data_buffer);
                     //     if result.is_err() {
-                    //         error!("Monitor layour {:?}", result);
+                    //         error!("Monitor layout {:?}", result);
                     //     } else {
-                    //         error!("Monitor layour success");
+                    //         error!("Monitor layout success");
                     //     }
                     // }
                 }

crates/connector/src/connection.rs

@@ -652,7 +652,7 @@ impl Sequence for ClientConnector {
             }
 
             //== Optional Multitransport Bootstrapping ==//
-            // NOTE: our implemention is not expecting the Auto-Detect Request PDU from server
+            // NOTE: our implementation is not expecting the Auto-Detect Request PDU from server
             ClientConnectorState::MultitransportBootstrapping {
                 io_channel_id,
                 user_channel_id,

crates/glutin-renderer/src/draw.rs

@@ -460,7 +460,7 @@ impl AvcShaderProgram {
             ShaderType::Avc420 => None,
             ShaderType::TextureShader => unreachable!(),
         };
-        // Set parameters that are not going to change accross different programs.
+        // Set parameters that are not going to change across different programs.
         // All shaders within a context share parameters and must be of the same type
         // The paraemters here are going to remain constant
 
@@ -514,7 +514,7 @@ impl AvcShaderProgram {
         if stride_1 != stride_0 / 2 {
             panic!("Program cannot handle stride mismatch");
         }
-        // Each region is 6 verticies (two triangles)
+        // Each region is 6 vertices (two triangles)
         gl.draw_arrays(glow::TRIANGLES, 0, regions.len() as i32 * 6);
     }
 }

crates/glutin-renderer/src/renderer.rs

@@ -48,7 +48,7 @@ fn handle_gfx_pdu(
     loop {
         let message = graphic_receiver
             .recv()
-            .map_err(|e| RendererError::RecieveError(e.to_string()))?;
+            .map_err(|e| RendererError::ReceiveError(e.to_string()))?;
 
         if let Some(file) = file.as_mut() {
             let _result = message.to_buffer(file);
@@ -170,8 +170,8 @@ impl Renderer {
 pub enum RendererError {
     #[error("Unable to send message on channel {0}")]
     SendError(String),
-    #[error("Unable to recieve message on channel {0}")]
-    RecieveError(String),
+    #[error("Unable to receive message on channel {0}")]
+    ReceiveError(String),
     #[error("errored to decode openh264 stream {0}")]
     OpenH264Error(#[from] openh264::Error),
     #[error("Graphics pipeline protocol error: {0}")]
@@ -194,7 +194,7 @@ impl<T> From<SendError<T>> for RendererError {
 
 impl From<RecvError> for RendererError {
     fn from(e: RecvError) -> Self {
-        RendererError::RecieveError(e.to_string())
+        RendererError::ReceiveError(e.to_string())
     }
 }
 

crates/graphics/Cargo.toml

@@ -25,7 +25,6 @@ lazy_static = "1.4.0"
 [dev-dependencies]
 bmp = "0.5"
 expect-test.workspace = true
-hex-literal = "0.3.4"
 proptest = "1.1.0"
 rdp-rs = { git = "https://github.com/citronneur/rdp-rs", rev = "7ac880d7efb7f05efef3c84476f7c24f4053e0ea" }
 rstest = "0.17.0"

crates/graphics/src/quantization.rs

@@ -4,11 +4,11 @@ const FIRST_LEVEL_SIZE: usize = 1024;
 const SECOND_LEVEL_SIZE: usize = 256;
 const THIRD_LEVEL_SIZE: usize = 64;
 
-const FISRT_LEVEL_SUBBANDS_COUNT: usize = 3;
+const FIRST_LEVEL_SUBBANDS_COUNT: usize = 3;
 const SECOND_LEVEL_SUBBANDS_COUNT: usize = 3;
 
 pub fn decode(buffer: &mut [i16], quant: &Quant) {
-    let (first_level, buffer) = buffer.split_at_mut(FISRT_LEVEL_SUBBANDS_COUNT * FIRST_LEVEL_SIZE);
+    let (first_level, buffer) = buffer.split_at_mut(FIRST_LEVEL_SUBBANDS_COUNT * FIRST_LEVEL_SIZE);
     let (second_level, third_level) = buffer.split_at_mut(SECOND_LEVEL_SUBBANDS_COUNT * SECOND_LEVEL_SIZE);
 
     let decode_chunk = |a: (&mut [i16], u8)| decode_block(a.0, a.1 as i16 - 1);

crates/graphics/src/rectangle_processing.rs

@@ -175,13 +175,13 @@ fn handle_rectangle_that_overlaps_band(rectangle: &Rectangle, band: &[Rectangle]
                                  |    |  |    |
 
         possible cases:
-        1) no top split, merge zone then a bottom split. The band will be splitted
+        1) no top split, merge zone then a bottom split. The band will be split
            in two
-        2) not band split, only the merge zone, band merged with rect but not splitted
+        2) not band split, only the merge zone, band merged with rect but not split
         3) a top split, the merge zone and no bottom split. The band will be split
            in two
         4) a top split, the merge zone and also a bottom split. The band will be
-           splitted in 3, but the coalesce algorithm may merge the created bands
+           split in 3, but the coalesce algorithm may merge the created bands
     */
 
     let band_top = band[0].top;
@@ -289,7 +289,7 @@ fn copy_band_with_union(
      *
      *  We first copy as-is items that are before Item2, the first overlapping
      *  item.
-     *  Then we find the last one that overlap unionRect to agregate Item2, Item3
+     *  Then we find the last one that overlap unionRect to aggregate Item2, Item3
      *  and Item4 to create Item2.
      *  Finally Item5 is copied as Item3.
      *

crates/graphics/src/zgfx/test_assets/encoded.0.bin

@@ -0,0 +1,2 @@
+�$	�
+D�7���� �0

crates/graphics/src/zgfx/test_assets/encoded.1.bin

@@ -0,0 +1 @@
+à$E¦bTcã\EÈŽvŒimŒE¿Ä]fž"DGXGäR‰",€

crates/pdu/src/lib.rs

@@ -200,7 +200,7 @@ pub fn decode_cursor<'de, T: PduDecode<'de>>(src: &mut ReadCursor<'de>) -> Resul
     T::decode(src)
 }
 
-/// Similar to `PduDecode` but unconditionnaly returns an owned type.
+/// Similar to `PduDecode` but unconditionally returns an owned type.
 pub trait PduDecodeOwned: Sized {
     fn decode_owned(src: &mut ReadCursor<'_>) -> Result<Self>;
 }