Merge pull request #343 from Modorganizer2/Develop

Better error message when archives can't be extracted

.editorconfig

@@ -1,16 +0,0 @@
-root = true
-
-[*.cpp]
-indent_style = space
-indent_size = 2
-insert_final_newline = true
-
-[*.h]
-indent_style = space
-indent_size = 2
-insert_final_newline = true
-
-[*.ui]
-indent_style = space
-indent_size = 2
-insert_final_newline = true

.github/ISSUE_TEMPLATE.md

@@ -0,0 +1,25 @@
+# The problem
+
+Briefly describe the issue you are experiencing (or the feature you want to see added to Mod Organizer). Tell us what you were trying to do and what happened instead. Remember, this is _not_ a place to ask questions. For that, go to our discord channel
+
+# Environment
+
+* Mod Organizer Version that exhibits the issue:
+* Last Mod Organizer Verison that did not exhibit the issue (if applicable):
+* Desktop OS/version used to run Mod Organizer:
+
+# Details
+
+If necessary, describe the problem you have been experiencing in more detail.
+
+# Link to Mod Organizer logs
+
+## USVFS
+Create a [GIST](https://gist.github.com) which is a paste of your USVFS logs, and link them here.
+Do _NOT_ paste your full USVFS logs here, as it will make this issue very long and hard to read!
+If you are reporting a bug, _always_ include the USVFS logs!
+
+## MO Interface
+Create a [GIST](https://gist.github.com) which is a paste of your mo_interface logs, and link them here.
+Do _NOT_ paste your full mo_interface logs here, as it will make this issue very long and hard to read!
+If you are reporting a bug, _always_ include the mo_interface logs!

.github/ISSUE_TEMPLATE/dev-ticket.md

@@ -1,10 +0,0 @@
----
-name: Dev Ticket
-about: Reserved for development tasks and management.
-title: ''
-labels: Dev Ticket
-assignees: ''
-
----
-
-Task:

.github/ISSUE_TEMPLATE/feature_request.md

@@ -1,20 +0,0 @@
----
-name: Feature request
-about: Suggest an idea for this project
-title: ''
-labels: Feature Request
-assignees: ''
-
----
-
-**Is your feature request related to a problem? Please describe.**
-A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
-
-**Describe the solution you'd like**
-A clear and concise description of what you want to happen.
-
-**Describe alternatives you've considered**
-A clear and concise description of any alternative solutions or features you've considered.
-
-**Additional context**
-Add any other context or screenshots about the feature request here.

.github/ISSUE_TEMPLATE/issue-report.md

@@ -1,41 +0,0 @@
----
-name: Issue Report
-about: Create an issue report.
-title: ''
-labels: issue report
-assignees: ''
-
----
-
-## The problem:
-Briefly describe the issue you are experiencing. Tell us what you were trying to do and what happened instead. Remember, this is _not_ a place to ask questions. For that, go to our [discord channel](https://discord.gg/5tCqt6V)
-
-
-## To Reproduce:
-Steps to reproduce the behavior:
-
-1. Go to '...'
-2. Click on '....'
-
-## Environment:
-
-* Mod Organizer Version that exhibits the issue:
-* Last Mod Organizer Verison that did not exhibit the issue (if applicable):
-* Desktop OS/version used to run Mod Organizer:
-
-## Details:
-If necessary, describe the problem you have been experiencing with more details and pictures.
-
-
-## Link to Mod Organizer logs:
-To access the log files you can press the Open folder icon over the modlist and select "Open MO2 Logs folder". You should close MO2 before sending or examining the logs as they are finished writing only after the program is closed.
-
-### USVFS:
-Create a [GIST](https://gist.github.com) which is a paste of your USVFS logs, and link them here.
-Do _NOT_ paste your full USVFS logs here, as it will make this issue very long and hard to read!
-If you are reporting a bug, _always_ include the USVFS logs!
-
-### MO Interface:
-Create a [GIST](https://gist.github.com) which is a paste of your mo_interface logs, and link them here.
-Do _NOT_ paste your full mo_interface logs here, as it will make this issue very long and hard to read!
-If you are reporting a bug, _always_ include the mo_interface logs!

readme.md

@@ -20,7 +20,7 @@ Through the work of a few people of the community MO2 has come quite far, now it
 ## Reporting Issues:
 Issues should be reported to the GitHub page or on the open discord server: [ModOrganizerDevs](https://discord.gg/vD2ZbfX). Here is also where dev builds are tested, bugs are reported and investigated, suggestions are discussed and a lot more.
 
-Credits to Tannin, LePresidente, Silarn, erasmux, AL12, LostDragonist, AnyOldName3 and many others for the development.
+Credits to Tannin, LePresidente, Silarn, erasmux, AL12 and many others for the development.
 
 ## Download Location
 
@@ -49,7 +49,6 @@ Here is a complete list:
 * https://github.com/Modorganizer2/modorganizer-check_fnis
 * https://github.com/Modorganizer2/modorganizer-diagnose_basic
 * https://github.com/Modorganizer2/modorganizer-esptk
-* https://github.com/ModOrganizer2/modorganizer-fnistool
 * https://github.com/Modorganizer2/modorganizer-helper
 * https://github.com/Modorganizer2/modorganizer-game_fallout3
 * https://github.com/Modorganizer2/modorganizer-game_fallout4
@@ -61,7 +60,6 @@ Here is a complete list:
 * https://github.com/Modorganizer2/modorganizer-game_oblivion
 * https://github.com/Modorganizer2/modorganizer-game_skyrim
 * https://github.com/Modorganizer2/modorganizer-game_skyrimSE
-* https://github.com/ModOrganizer2/modorganizer-game_skyrimVR
 * https://github.com/Modorganizer2/modorganizer-game_ttw
 * https://github.com/Modorganizer2/modorganizer-installer_bain
 * https://github.com/Modorganizer2/modorganizer-installer_bundle

src/CMakeLists.txt

@@ -37,7 +37,6 @@ SET(organizer_SRCS
     modinfoforeign.cpp
     modinfooverwrite.cpp
     modinforegular.cpp
-    modinfoseparator.cpp
     modinfowithconflictinfo.cpp
     messagedialog.cpp
     mainwindow.cpp
@@ -54,6 +53,7 @@ SET(organizer_SRCS
     executableslist.cpp
     editexecutablesdialog.cpp
     downloadmanager.cpp
+    downloadlistwidgetcompact.cpp
     downloadlistwidget.cpp
     downloadlistsortproxy.cpp
     downloadlist.cpp
@@ -90,10 +90,6 @@ SET(organizer_SRCS
     usvfsconnector.cpp
     eventfilter.cpp
     moshortcut.cpp
-    listdialog.cpp
-    lcdnumber.cpp
-    forcedloaddialog.cpp
-    forcedloaddialogwidget.cpp
 
     shared/windows_error.cpp
     shared/error_report.cpp
@@ -132,7 +128,6 @@ SET(organizer_HDRS
     modinfoforeign.h
     modinfooverwrite.h
     modinforegular.h
-    modinfoseparator.h
     modinfowithconflictinfo.h
     messagedialog.h
     mainwindow.h
@@ -148,6 +143,7 @@ SET(organizer_HDRS
     executableslist.h
     editexecutablesdialog.h
     downloadmanager.h
+    downloadlistwidgetcompact.h
     downloadlistwidget.h
     downloadlistsortproxy.h
     downloadlist.h
@@ -187,10 +183,6 @@ SET(organizer_HDRS
     eventfilter.h
     descriptionpage.h
     moshortcut.h
-    listdialog.h
-    lcdnumber.h
-    forcedloaddialog.h
-    forcedloaddialogwidget.h
 
     shared/windows_error.h
     shared/error_report.h
@@ -220,6 +212,8 @@ SET(organizer_UIS
     installdialog.ui
     finddialog.ui
     editexecutablesdialog.ui
+    downloadlistwidgetcompact.ui
+    downloadlistwidget.ui
     credentialsdialog.ui
     categoriesdialog.ui
     activatemodsdialog.ui
@@ -229,9 +223,6 @@ SET(organizer_UIS
     previewdialog.ui
     browserdialog.ui
     aboutdialog.ui
-    listdialog.ui
-    forcedloaddialog.ui
-    forcedloaddialogwidget.ui
   )
 
 SET(organizer_QRCS
@@ -297,8 +288,7 @@ INCLUDE_DIRECTORIES(${project_path}/uibase/src
                     ${project_path}/esptk/src
                     ${project_path}/archive/src
                     ${project_path}/../usvfs/include
-                    ${project_path}/game_gamebryo/src/gamebryo
-                    ${project_path}/game_gamebryo/src/creation
+                    ${project_path}/game_gamebryo/src
                     ${project_path}/game_features/src
                     ${project_path}/githubpp/src
                     ${LZ4_ROOT}/include)

src/aboutdialog.ui

@@ -157,7 +157,7 @@
          <item row="0" column="0">
           <widget class="QGroupBox" name="groupBox">
            <property name="title">
-            <string>Lead Developers/ Maintainers</string>
+            <string>Current Maintainers</string>
            </property>
            <layout class="QVBoxLayout" name="verticalLayout_6">
             <item>
@@ -175,6 +175,11 @@
                 <string notr="true">AL12</string>
                </property>
               </item>
+              <item>
+               <property name="text">
+                <string notr="true">Diana</string>
+               </property>
+              </item>
               <item>
                <property name="text">
                 <string notr="true">erasmux</string>
@@ -185,11 +190,6 @@
                 <string notr="true">Silarn</string>
                </property>
               </item>
-              <item>
-               <property name="text">
-                <string notr="true">LostDragonist</string>
-               </property>
-              </item>
              </widget>
             </item>
            </layout>
@@ -198,27 +198,17 @@
          <item row="1" column="0">
           <widget class="QGroupBox" name="groupBox_2">
            <property name="title">
-            <string>Mo2 devs and Contributors</string>
+            <string>Major Contributors</string>
            </property>
            <layout class="QVBoxLayout" name="verticalLayout_7" stretch="0">
             <item>
-             <widget class="QListWidget" name="listWidget_3">
+             <widget class="QListWidget" name="listWidget_2">
               <property name="selectionMode">
                <enum>QAbstractItemView::NoSelection</enum>
               </property>
               <item>
                <property name="text">
-                <string notr="true">AnyOldName3</string>
-               </property>
-              </item>
-              <item>
-               <property name="text">
-                <string>Project579</string>
-               </property>
-              </item>
-              <item>
-               <property name="text">
-                <string>przester</string>
+                <string notr="true">AnyOldName3 (Python Plugins)</string>
                </property>
               </item>
              </widget>
@@ -231,9 +221,9 @@
            <property name="title">
             <string>Translators</string>
            </property>
-           <layout class="QVBoxLayout" name="verticalLayout_61">
+           <layout class="QVBoxLayout" name="verticalLayout_6">
             <item>
-             <widget class="QListWidget" name="listWidget_4">
+             <widget class="QListWidget" name="listWidget_2">
               <property name="selectionMode">
                <enum>QAbstractItemView::NoSelection</enum>
               </property>
@@ -315,11 +305,6 @@
                 <string>Brgodfx (Portuguese)</string>
                </property>
               </item>
-              <item>
-               <property name="text">
-                <string>zDas (Portuguese)</string>
-               </property>
-              </item>
               <item>
                <property name="text">
                 <string notr="true">tokcdk  (Russian)</string>
@@ -340,11 +325,6 @@
                 <string>Jax (Swedish)</string>
                </property>
               </item>
-              <item>
-               <property name="text">
-                <string>yohru (Japanese)</string>
-               </property>
-              </item>
               <item>
                <property name="text">
                 <string>...and all other Transifex contributors!</string>
@@ -363,17 +343,12 @@
            <property name="title">
             <string>Other Supporters &amp;&amp; Contributors</string>
            </property>
-           <layout class="QVBoxLayout" name="verticalLayout_71">
+           <layout class="QVBoxLayout" name="verticalLayout_7">
             <item>
              <widget class="QListWidget" name="listWidget">
               <property name="selectionMode">
                <enum>QAbstractItemView::NoSelection</enum>
               </property>
-              <item>
-               <property name="text">
-                <string>Tannin (Original Creator)</string>
-               </property>
-              </item>
               <item>
                <property name="text">
                 <string notr="true">blacksol</string>

src/bbcode.cpp

@@ -88,7 +88,7 @@ public:
                 return temp.replace(tagIter->second.first, QString("<font style=\"color: #%1;\">%2</font>").arg(color, content));
               }
             } else {
-              qWarning("don't know how to deal with tag %s", qUtf8Printable(tagName));
+              qWarning("don't know how to deal with tag %s", qPrintable(tagName));
             }
           } else {
             if (tagName == "*") {
@@ -100,7 +100,7 @@ public:
           // expression doesn't match. either the input string is invalid
           // or the expression is
           qWarning("%s doesn't match the expression for %s",
-                   qUtf8Printable(temp), qUtf8Printable(tagName));
+                   temp.toUtf8().constData(), tagName.toUtf8().constData());
           length = 0;
           return QString();
         }

src/categories.cpp

@@ -72,7 +72,7 @@ void CategoryFactory::loadCategories()
             bool ok = false;
             int temp = iter->toInt(&ok);
             if (!ok) {
-              qCritical("invalid category id %s", iter->constData());
+              qCritical("invalid id %s", iter->constData());
             }
             nexusIDs.push_back(temp);
           }
@@ -268,7 +268,7 @@ void CategoryFactory::loadDefaultCategories()
 int CategoryFactory::getParentID(unsigned int index) const
 {
   if (index >= m_Categories.size()) {
-    throw MyException(QObject::tr("invalid category index: %1").arg(index));
+    throw MyException(QObject::tr("invalid index %1").arg(index));
   }
 
   return m_Categories[index].m_ParentID;
@@ -303,7 +303,7 @@ bool CategoryFactory::isDecendantOf(int id, int parentID) const
 bool CategoryFactory::hasChildren(unsigned int index) const
 {
   if (index >= m_Categories.size()) {
-    throw MyException(QObject::tr("invalid category index: %1").arg(index));
+    throw MyException(QObject::tr("invalid index %1").arg(index));
   }
 
   return m_Categories[index].m_HasChildren;
@@ -313,7 +313,7 @@ bool CategoryFactory::hasChildren(unsigned int index) const
 QString CategoryFactory::getCategoryName(unsigned int index) const
 {
   if (index >= m_Categories.size()) {
-    throw MyException(QObject::tr("invalid category index: %1").arg(index));
+    throw MyException(QObject::tr("invalid index %1").arg(index));
   }
 
   return m_Categories[index].m_Name;
@@ -323,7 +323,7 @@ QString CategoryFactory::getCategoryName(unsigned int index) const
 int CategoryFactory::getCategoryID(unsigned int index) const
 {
   if (index >= m_Categories.size()) {
-    throw MyException(QObject::tr("invalid category index: %1").arg(index));
+    throw MyException(QObject::tr("invalid index %1").arg(index));
   }
 
   return m_Categories[index].m_ID;
@@ -334,7 +334,7 @@ int CategoryFactory::getCategoryIndex(int ID) const
 {
   std::map<int, unsigned int>::const_iterator iter = m_IDMap.find(ID);
   if (iter == m_IDMap.end()) {
-    throw MyException(QObject::tr("invalid category id: %1").arg(ID));
+    throw MyException(QObject::tr("invalid category id %1").arg(ID));
   }
   return iter->second;
 }

src/categories.h

@@ -47,10 +47,8 @@ public:
   static const int CATEGORY_SPECIAL_NOCATEGORY = 10003;
   static const int CATEGORY_SPECIAL_CONFLICT = 10004;
   static const int CATEGORY_SPECIAL_NOTENDORSED = 10005;
-  static const int CATEGORY_SPECIAL_BACKUP = 10006;
-  static const int CATEGORY_SPECIAL_MANAGED = 10007;
-  static const int CATEGORY_SPECIAL_UNMANAGED = 10008;
-
+  static const int CATEGORY_SPECIAL_MANAGED = 10006;
+  static const int CATEGORY_SPECIAL_UNMANAGED = 10007;
 
 public:
 

src/directoryrefresher.cpp

@@ -23,13 +23,10 @@ along with Mod Organizer.  If not, see <http://www.gnu.org/licenses/>.
 #include "utility.h"
 #include "report.h"
 #include "modinfo.h"
-#include "settings.h"
 
 #include <QApplication>
 #include <QDir>
 #include <QString>
-#include <QTextCodec>
-#include <gameplugins.h>
 
 
 using namespace MOBase;
@@ -86,29 +83,13 @@ void DirectoryRefresher::addModBSAToStructure(DirectoryEntry *directoryStructure
                                               int priority, const QString &directory, const QStringList &archives)
 {
   std::wstring directoryW = ToWString(QDir::toNativeSeparators(directory));
-  IPluginGame *game = qApp->property("managed_game").value<IPluginGame*>();
-
-  GamePlugins *gamePlugins = game->feature<GamePlugins>();
-  QStringList loadOrder = QStringList();
-  gamePlugins->getLoadOrder(loadOrder);
 
   for (const QString &archive : archives) {
     QFileInfo fileInfo(archive);
     if (m_EnabledArchives.find(fileInfo.fileName()) != m_EnabledArchives.end()) {
-
-      int order = -1;
-
-      for (auto plugin : loadOrder)
-      {
-        QString name = plugin.left(plugin.size() - 4);
-        if (fileInfo.fileName().startsWith(name + " - ", Qt::CaseInsensitive) || fileInfo.fileName().startsWith(name + ".", Qt::CaseInsensitive)) {
-          order = loadOrder.indexOf(plugin);
-        }
-      }
-
       try {
-        IPluginGame *game = qApp->property("managed_game").value<IPluginGame*>();
-        directoryStructure->addFromBSA(ToWString(modName), directoryW, ToWString(QDir::toNativeSeparators(fileInfo.absoluteFilePath())), priority, order);
+        //directoryStructure->addFromBSA(ToWString(modName), directoryW,
+        //                                ToWString(QDir::toNativeSeparators(fileInfo.absoluteFilePath())), priority);
       } catch (const std::exception &e) {
         throw MyException(tr("failed to parse bsa %1: %2").arg(archive, e.what()));
       }
@@ -126,10 +107,6 @@ void DirectoryRefresher::addModFilesToStructure(DirectoryEntry *directoryStructu
     // files to this mod
     FilesOrigin &origin = directoryStructure->createOrigin(ToWString(modName), directoryW, priority);
     for (const QString &filename : stealFiles) {
-      if (filename.isEmpty()) {
-        qWarning("Trying to find file with no name");
-        continue;
-      }
       QFileInfo fileInfo(filename);
       FileEntry::Ptr file = directoryStructure->findFile(ToWString(fileInfo.fileName()));
       if (file.get() != nullptr) {
@@ -138,12 +115,9 @@ void DirectoryRefresher::addModFilesToStructure(DirectoryEntry *directoryStructu
           file->removeOrigin(0);
         }
         origin.addFile(file->getIndex());
-        file->addOrigin(origin.getID(), file->getFileTime(), L"", -1);
+        file->addOrigin(origin.getID(), file->getFileTime(), L"");
       } else {
-        QString warnStr = fileInfo.absolutePath();
-        if (warnStr.isEmpty())
-          warnStr = filename;
-        qWarning("file not found: %s", qUtf8Printable(warnStr));
+        qWarning("%s not found", qPrintable(fileInfo.fileName()));
       }
     }
   } else {
@@ -159,10 +133,7 @@ void DirectoryRefresher::addModToStructure(DirectoryEntry *directoryStructure
                                            , const QStringList &archives)
 {
   addModFilesToStructure(directoryStructure, modName, priority, directory, stealFiles);
-  
-  if (Settings::instance().archiveParsing()) {
-    addModBSAToStructure(directoryStructure, modName, priority, directory, archives);
-  }
+  addModBSAToStructure(directoryStructure, modName, priority, directory, archives);
 }
 
 void DirectoryRefresher::refresh()
@@ -191,8 +162,6 @@ void DirectoryRefresher::refresh()
     emit progress((i * 100) / static_cast<int>(m_Mods.size()) + 1);
   }
 
-  m_DirectoryStructure->getFileRegister()->sortOrigins();
-
   emit progress(100);
 
   cleanStructure(m_DirectoryStructure);

src/directoryrefresher.h

@@ -27,7 +27,6 @@ along with Mod Organizer.  If not, see <http://www.gnu.org/licenses/>.
 #include <vector>
 #include <set>
 #include <tuple>
-#include "profile.h"
 
 
 /**

src/downloadlist.cpp

@@ -20,8 +20,6 @@ along with Mod Organizer.  If not, see <http://www.gnu.org/licenses/>.
 #include "downloadlist.h"
 #include "downloadmanager.h"
 #include <QEvent>
-#include <QColor>
-#include <QIcon>
 
 #include <QSortFilterProxyModel>
 
@@ -33,11 +31,6 @@ DownloadList::DownloadList(DownloadManager *manager, QObject *parent)
   connect(m_Manager, SIGNAL(aboutToUpdate()), this, SLOT(aboutToUpdate()));
 }
 
-void DownloadList::setMetaDisplay(bool metaDisplay)
-{
-  m_MetaDisplay = metaDisplay;
-}
-
 
 int DownloadList::rowCount(const QModelIndex&) const
 {
@@ -47,7 +40,7 @@ int DownloadList::rowCount(const QModelIndex&) const
 
 int DownloadList::columnCount(const QModelIndex&) const
 {
-  return 4;
+  return 3;
 }
 
 
@@ -69,65 +62,21 @@ QVariant DownloadList::headerData(int section, Qt::Orientation orientation, int
       (orientation == Qt::Horizontal)) {
     switch (section) {
       case COL_NAME: return tr("Name");
-      case COL_SIZE: return tr("Size");
-      case COL_STATUS: return tr("Status");
       case COL_FILETIME: return tr("Filetime");
-      default: return QVariant();
+      default: return tr("Done");
     }
   } else {
     return QAbstractItemModel::headerData(section, orientation, role);
   }
 }
 
+
 QVariant DownloadList::data(const QModelIndex &index, int role) const
 {
-  bool pendingDownload = index.row() >= m_Manager->numTotalDownloads();
   if (role == Qt::DisplayRole) {
-    if (pendingDownload) {
-      std::tuple<QString, int, int> nexusids = m_Manager->getPendingDownload(index.row() - m_Manager->numTotalDownloads());
-      switch (index.column()) {
-        case COL_NAME: return tr("< game %1 mod %2 file %3 >").arg(std::get<0>(nexusids)).arg(std::get<1>(nexusids)).arg(std::get<2>(nexusids));
-        case COL_SIZE: return tr("Unknown");
-        case COL_STATUS: return tr("Pending");
-      }
-    } else {
-      switch (index.column()) {
-        case COL_NAME: return m_MetaDisplay ? m_Manager->getDisplayName(index.row()) : m_Manager->getFileName(index.row());
-        case COL_SIZE: return sizeFormat(m_Manager->getFileSize(index.row()));
-        case COL_FILETIME: return m_Manager->getFileTime(index.row());
-        case COL_STATUS:
-          switch (m_Manager->getState(index.row())) {
-            // STATE_DOWNLOADING handled by DownloadProgressDelegate
-            case DownloadManager::STATE_STARTED: return tr("Started");
-            case DownloadManager::STATE_CANCELING: return tr("Canceling");
-            case DownloadManager::STATE_PAUSING: return tr("Pausing");
-            case DownloadManager::STATE_CANCELED: return tr("Canceled");
-            case DownloadManager::STATE_PAUSED: return tr("Paused");
-            case DownloadManager::STATE_ERROR: return tr("Error");
-            case DownloadManager::STATE_FETCHINGMODINFO: return tr("Fetching Info 1");
-            case DownloadManager::STATE_FETCHINGFILEINFO: return tr("Fetching Info 2");
-            case DownloadManager::STATE_READY: return tr("Downloaded");
-            case DownloadManager::STATE_INSTALLED: return tr("Installed");
-            case DownloadManager::STATE_UNINSTALLED: return tr("Uninstalled");
-          }
-      }
-    }
-  } else if (role == Qt::ForegroundRole && index.column() == COL_STATUS) {
-    if (pendingDownload) {
-      return QColor(Qt::darkBlue);
-    } else {
-      DownloadManager::DownloadState state = m_Manager->getState(index.row());
-      if (state == DownloadManager::STATE_READY)
-        return QColor(Qt::darkGreen);
-      else if (state == DownloadManager::STATE_UNINSTALLED)
-        return QColor(Qt::darkYellow);
-      else if (state == DownloadManager::STATE_PAUSED)
-        return QColor(Qt::darkRed);
-    }
+    return index.row();
   } else if (role == Qt::ToolTipRole) {
-    if (pendingDownload) {
-      return tr("Pending download");
-    } else {
+    if (index.row() < m_Manager->numTotalDownloads()) {
       QString text = m_Manager->getFileName(index.row()) + "\n";
       if (m_Manager->isInfoIncomplete(index.row())) {
         text += tr("Information missing, please select \"Query Info\" from the context menu to re-retrieve.");
@@ -136,18 +85,12 @@ QVariant DownloadList::data(const QModelIndex &index, int role) const
         return QString("%1 (ID %2) %3<br><span>%4</span>").arg(info->modName).arg(m_Manager->getModID(index.row())).arg(info->version.canonicalString()).arg(info->description);
       }
       return text;
+    } else {
+      return tr("pending download");
     }
-  } else if (role == Qt::DecorationRole && index.column() == COL_NAME) {
-    if (!pendingDownload && m_Manager->getState(index.row()) >= DownloadManager::STATE_READY
-        && m_Manager->isInfoIncomplete(index.row()))
-      return QIcon(":/MO/gui/warning_16");
-  } else if (role == Qt::TextAlignmentRole) {
-    if (index.column() == COL_NAME)
-      return QVariant(Qt::AlignVCenter | Qt::AlignLeft);
-    else
-      return QVariant(Qt::AlignVCenter | Qt::AlignRight);
+  } else {
+    return QVariant();
   }
-  return QVariant();
 }
 
 
@@ -159,28 +102,13 @@ void DownloadList::aboutToUpdate()
 
 void DownloadList::update(int row)
 {
-  if (row < 0)
+  if (row < 0) {
     emit endResetModel();
-  else if (row < this->rowCount())
-    emit dataChanged(this->index(row, 0, QModelIndex()), this->index(row, this->columnCount(QModelIndex())-1, QModelIndex()));
-  else
+  } else if (row < this->rowCount()) {
+#pragma message("updating only the one column is a hack")
+    emit dataChanged(this->index(row, 2, QModelIndex()), this->index(row, 2, QModelIndex()));
+  } else {
     qCritical("invalid row %d in download list, update failed", row);
-}
-
-QString DownloadList::sizeFormat(quint64 size) const
-{
-  qreal calc = size;
-  QStringList list;
-  list << "MB" << "GB" << "TB";
-
-  QStringListIterator i(list);
-  QString unit("KB");
-
-  calc /= 1024.0;
-  while (calc >= 1024.0 && i.hasNext()) {
-    unit = i.next();
-    calc /= 1024.0;
   }
-
-  return QString().setNum(calc, 'f', 2) + " " + unit;
 }
+

src/downloadlist.h

@@ -22,6 +22,7 @@ along with Mod Organizer.  If not, see <http://www.gnu.org/licenses/>.
 
 #include <QAbstractTableModel>
 
+
 class DownloadManager;
 
 
@@ -37,9 +38,8 @@ public:
 
   enum EColumn {
     COL_NAME = 0,
-    COL_STATUS,
-    COL_SIZE,
-    COL_FILETIME
+    COL_FILETIME,
+    COL_STATUS
   };
 
 public:
@@ -52,8 +52,6 @@ public:
    **/
   explicit DownloadList(DownloadManager *manager, QObject *parent = 0);
 
-  void setMetaDisplay(bool metaDisplay);
-
   /**
    * @brief retrieve the number of rows to display. Invoked by Qt
    *
@@ -92,9 +90,7 @@ public slots:
 private:
 
   DownloadManager *m_Manager;
-  bool m_MetaDisplay;
 
-  QString sizeFormat(quint64 size) const;
 };
 
 #endif // DOWNLOADLIST_H

src/downloadlistsortproxy.cpp

@@ -37,23 +37,16 @@ void DownloadListSortProxy::updateFilter(const QString &filter)
 bool DownloadListSortProxy::lessThan(const QModelIndex &left,
                                      const QModelIndex &right) const
 {
-  int leftIndex  = left.row();
-  int rightIndex = right.row();
+  int leftIndex  = left.data().toInt();
+  int rightIndex = right.data().toInt();
   if ((leftIndex < m_Manager->numTotalDownloads())
       && (rightIndex < m_Manager->numTotalDownloads())) {
     if (left.column() == DownloadList::COL_NAME) {
-      return m_Manager->getFileName(left.row()).compare(m_Manager->getFileName(right.row()), Qt::CaseInsensitive) < 0;
-    } else if (left.column() == DownloadList::COL_STATUS) {
-      DownloadManager::DownloadState leftState = m_Manager->getState(left.row());
-      DownloadManager::DownloadState rightState = m_Manager->getState(right.row());
-      if (leftState == rightState)
-        return m_Manager->getFileTime(left.row()) < m_Manager->getFileTime(right.row());
-      else
-        return leftState > rightState;
-    } else if (left.column() == DownloadList::COL_SIZE) {
-      return m_Manager->getFileSize(left.row()) < m_Manager->getFileSize(right.row());
+      return m_Manager->getFileName(leftIndex).compare(m_Manager->getFileName(rightIndex), Qt::CaseInsensitive) < 0;
     } else if (left.column() == DownloadList::COL_FILETIME) {
-      return m_Manager->getFileTime(left.row()) < m_Manager->getFileTime(right.row());
+      return m_Manager->getFileTime(leftIndex) < m_Manager->getFileTime(rightIndex);
+    } else if (left.column() == DownloadList::COL_STATUS) {
+      return m_Manager->getState(leftIndex) < m_Manager->getState(rightIndex);
     } else {
       return leftIndex < rightIndex;
     }
@@ -68,9 +61,11 @@ bool DownloadListSortProxy::filterAcceptsRow(int sourceRow, const QModelIndex&)
   if (m_CurrentFilter.length() == 0) {
     return true;
   } else if (sourceRow < m_Manager->numTotalDownloads()) {
+    int downloadIndex = sourceModel()->index(sourceRow, 0).data().toInt();
+
     QString displayedName = Settings::instance().metaDownloads()
-        ? m_Manager->getDisplayName(sourceRow)
-        : m_Manager->getFileName(sourceRow);
+        ? m_Manager->getDisplayName(downloadIndex)
+        : m_Manager->getFileName(downloadIndex);
     return displayedName.contains(m_CurrentFilter, Qt::CaseInsensitive);
   } else {
     return false;

src/downloadlistwidget.h

@@ -21,61 +21,49 @@ along with Mod Organizer.  If not, see <http://www.gnu.org/licenses/>.
 #define DOWNLOADLISTWIDGET_H
 
 #include "downloadmanager.h"
-#include "downloadlist.h"
-#include "downloadlistsortproxy.h"
 #include <QWidget>
 #include <QItemDelegate>
 #include <QLabel>
 #include <QProgressBar>
 #include <QTreeView>
-#include <QHeaderView>
-#include <QStyledItemDelegate>
-
 
 namespace Ui {
-  class DownloadListWidget;
+    class DownloadListWidget;
 }
 
-class DownloadProgressDelegate : public QStyledItemDelegate
+class DownloadListWidget : public QWidget
 {
-  Q_OBJECT
+    Q_OBJECT
 
 public:
-  DownloadProgressDelegate(DownloadManager *manager, DownloadListSortProxy *sortProxy, QWidget *parent = 0) : QStyledItemDelegate(parent), m_Manager(manager), m_SortProxy(sortProxy) {}
+    explicit DownloadListWidget(QWidget *parent = 0);
+    ~DownloadListWidget();
 
-  void paint(QPainter *painter, const QStyleOptionViewItem &option,
-    const QModelIndex &index) const override;
 
 private:
-  DownloadManager *m_Manager;
-  DownloadListSortProxy *m_SortProxy;
+    Ui::DownloadListWidget *ui;
 };
 
-class DownloadListHeader : public QHeaderView
+class DownloadManager;
+
+class DownloadListWidgetDelegate : public QItemDelegate
 {
+
   Q_OBJECT
 
 public:
-  explicit DownloadListHeader(Qt::Orientation orientation, QWidget *parent = nullptr) : QHeaderView(orientation, parent) {}
-  void customResizeSections();
 
-private:
-  void mouseReleaseEvent(QMouseEvent *event) override;
-};
+  DownloadListWidgetDelegate(DownloadManager *manager, bool metaDisplay, QTreeView *view, QObject *parent = 0);
+  ~DownloadListWidgetDelegate();
 
-class DownloadListWidget : public QTreeView
-{
-  Q_OBJECT
+  virtual void paint(QPainter *painter, const QStyleOptionViewItem &option, const QModelIndex &index) const;
+  virtual QSize sizeHint(const QStyleOptionViewItem &option, const QModelIndex &index) const;
 
-public:
-  explicit DownloadListWidget(QWidget *parent = 0);
-  ~DownloadListWidget();
-
-  void setManager(DownloadManager *manager);
-  void setSourceModel(DownloadList *sourceModel);
-  void setMetaDisplay(bool metaDisplay);
+  void paintPendingDownload(int downloadIndex) const;
+  void paintRegularDownload(int downloadIndex) const;
 
 signals:
+
   void installDownload(int index);
   void queryInfo(int index);
   void removeDownload(int index, bool deleteFile);
@@ -83,39 +71,50 @@ signals:
   void cancelDownload(int index);
   void pauseDownload(int index);
   void resumeDownload(int index);
-  void visitOnNexus(int index);
-  void openFile(int index);
-  void openInDownloadsFolder(int index);
+
+protected:
+
+  bool editorEvent(QEvent *event, QAbstractItemModel *model,
+                   const QStyleOptionViewItem &option, const QModelIndex &index);
+
+private:
+
+  void drawCache(QPainter *painter, const QStyleOptionViewItem &option, const QPixmap &cache) const;
 
 private slots:
-  void onDoubleClick(const QModelIndex &index);
-  void onCustomContextMenu(const QPoint &point);
-  void onHeaderCustomContextMenu(const QPoint &point);
+
   void issueInstall();
   void issueDelete();
   void issueRemoveFromView();
   void issueRestoreToView();
-  void issueRestoreToViewAll();
-  void issueVisitOnNexus();
-  void issueOpenFile();
-  void issueOpenInDownloadsFolder();
   void issueCancel();
   void issuePause();
   void issueResume();
   void issueDeleteAll();
   void issueDeleteCompleted();
-  void issueDeleteUninstalled();
   void issueRemoveFromViewAll();
   void issueRemoveFromViewCompleted();
-  void issueRemoveFromViewUninstalled();
   void issueQueryInfo();
 
+  void stateChanged(int row, DownloadManager::DownloadState);
+  void resetCache(int);
+
 private:
+
+  DownloadListWidget *m_ItemWidget;
   DownloadManager *m_Manager;
-  DownloadList *m_SourceModel = 0;
+
+  bool m_MetaDisplay;
+
+  QLabel *m_NameLabel;
+  QLabel *m_SizeLabel;
+  QProgressBar *m_Progress;
+  QLabel *m_InstallLabel;
   int m_ContextRow;
 
-  void resizeEvent(QResizeEvent *event);
+  QTreeView *m_View;
+
+  mutable QMap<int, QPixmap> m_Cache;
 };
 
 #endif // DOWNLOADLISTWIDGET_H

src/downloadlistwidget.ui

@@ -0,0 +1,137 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<ui version="4.0">
+ <class>DownloadListWidget</class>
+ <widget class="QWidget" name="DownloadListWidget">
+  <property name="geometry">
+   <rect>
+    <x>0</x>
+    <y>0</y>
+    <width>315</width>
+    <height>81</height>
+   </rect>
+  </property>
+  <property name="contextMenuPolicy">
+   <enum>Qt::CustomContextMenu</enum>
+  </property>
+  <property name="windowTitle">
+   <string>Placeholder</string>
+  </property>
+  <property name="autoFillBackground">
+   <bool>false</bool>
+  </property>
+  <layout class="QVBoxLayout" name="verticalLayout">
+   <property name="leftMargin">
+    <number>0</number>
+   </property>
+   <property name="topMargin">
+    <number>1</number>
+   </property>
+   <property name="rightMargin">
+    <number>0</number>
+   </property>
+   <property name="bottomMargin">
+    <number>1</number>
+   </property>
+   <item>
+    <widget class="QFrame" name="frame">
+     <property name="frameShape">
+      <enum>QFrame::Box</enum>
+     </property>
+     <property name="frameShadow">
+      <enum>QFrame::Raised</enum>
+     </property>
+     <layout class="QVBoxLayout" name="verticalLayout_2">
+      <item>
+       <layout class="QHBoxLayout" name="horizontalLayout_2">
+        <item>
+         <widget class="QLabel" name="nameLabel">
+          <property name="sizePolicy">
+           <sizepolicy hsizetype="Preferred" vsizetype="Preferred">
+            <horstretch>1</horstretch>
+            <verstretch>0</verstretch>
+           </sizepolicy>
+          </property>
+          <property name="maximumSize">
+           <size>
+            <width>323</width>
+            <height>16777215</height>
+           </size>
+          </property>
+          <property name="text">
+           <string>Placeholder</string>
+          </property>
+         </widget>
+        </item>
+        <item>
+         <spacer name="horizontalSpacer">
+          <property name="orientation">
+           <enum>Qt::Horizontal</enum>
+          </property>
+          <property name="sizeHint" stdset="0">
+           <size>
+            <width>40</width>
+            <height>20</height>
+           </size>
+          </property>
+         </spacer>
+        </item>
+        <item>
+         <widget class="QLabel" name="sizeLabel">
+          <property name="text">
+           <string notr="true">0</string>
+          </property>
+         </widget>
+        </item>
+        <item>
+         <widget class="QLabel" name="label_2">
+          <property name="text">
+           <string notr="true">KB</string>
+          </property>
+         </widget>
+        </item>
+       </layout>
+      </item>
+      <item>
+       <layout class="QHBoxLayout" name="horizontalLayout">
+        <item>
+         <widget class="QLabel" name="installLabel">
+          <property name="text">
+           <string>Done - Double Click to install</string>
+          </property>
+         </widget>
+        </item>
+        <item>
+         <widget class="QProgressBar" name="downloadProgress">
+          <property name="sizePolicy">
+           <sizepolicy hsizetype="Preferred" vsizetype="Fixed">
+            <horstretch>0</horstretch>
+            <verstretch>0</verstretch>
+           </sizepolicy>
+          </property>
+          <property name="minimumSize">
+           <size>
+            <width>0</width>
+            <height>0</height>
+           </size>
+          </property>
+          <property name="maximumSize">
+           <size>
+            <width>16777215</width>
+            <height>16777215</height>
+           </size>
+          </property>
+          <property name="value">
+           <number>0</number>
+          </property>
+         </widget>
+        </item>
+       </layout>
+      </item>
+     </layout>
+    </widget>
+   </item>
+  </layout>
+ </widget>
+ <resources/>
+ <connections/>
+</ui>

src/downloadlistwidgetcompact.cpp

@@ -0,0 +1,338 @@
+/*
+Copyright (C) 2012 Sebastian Herbord. All rights reserved.
+
+This file is part of Mod Organizer.
+
+Mod Organizer is free software: you can redistribute it and/or modify
+it under the terms of the GNU General Public License as published by
+the Free Software Foundation, either version 3 of the License, or
+(at your option) any later version.
+
+Mod Organizer is distributed in the hope that it will be useful,
+but WITHOUT ANY WARRANTY; without even the implied warranty of
+MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+GNU General Public License for more details.
+
+You should have received a copy of the GNU General Public License
+along with Mod Organizer.  If not, see <http://www.gnu.org/licenses/>.
+*/
+
+#include "downloadlistwidgetcompact.h"
+#include "ui_downloadlistwidgetcompact.h"
+#include <QPainter>
+#include <QMouseEvent>
+#include <QMenu>
+#include <QMessageBox>
+#include <QSortFilterProxyModel>
+
+
+DownloadListWidgetCompact::DownloadListWidgetCompact(QWidget *parent) :
+  QWidget(parent),
+  ui(new Ui::DownloadListWidgetCompact)
+{
+  ui->setupUi(this);
+}
+
+DownloadListWidgetCompact::~DownloadListWidgetCompact()
+{
+  delete ui;
+}
+
+
+DownloadListWidgetCompactDelegate::DownloadListWidgetCompactDelegate(DownloadManager *manager, bool metaDisplay, QTreeView *view, QObject *parent)
+  : QItemDelegate(parent)
+  , m_Manager(manager)
+  , m_MetaDisplay(metaDisplay)
+  , m_ItemWidget(new DownloadListWidgetCompact)
+  , m_View(view)
+{
+  m_NameLabel = m_ItemWidget->findChild<QLabel*>("nameLabel");
+  m_SizeLabel = m_ItemWidget->findChild<QLabel*>("sizeLabel");
+  m_Progress = m_ItemWidget->findChild<QProgressBar*>("downloadProgress");
+  m_DoneLabel = m_ItemWidget->findChild<QLabel*>("doneLabel");
+
+  m_DoneLabel->setVisible(false);
+
+  connect(manager, SIGNAL(stateChanged(int,DownloadManager::DownloadState)),
+          this, SLOT(stateChanged(int,DownloadManager::DownloadState)));
+  connect(manager, SIGNAL(downloadRemoved(int)), this, SLOT(resetCache(int)));
+}
+
+
+DownloadListWidgetCompactDelegate::~DownloadListWidgetCompactDelegate()
+{
+  delete m_ItemWidget;
+}
+
+
+void DownloadListWidgetCompactDelegate::stateChanged(int row,DownloadManager::DownloadState)
+{
+  m_Cache.remove(row);
+}
+
+
+void DownloadListWidgetCompactDelegate::resetCache(int)
+{
+  m_Cache.clear();
+}
+
+
+void DownloadListWidgetCompactDelegate::drawCache(QPainter *painter, const QStyleOptionViewItem &option, const QPixmap &cache) const
+{
+  QRect rect = option.rect;
+  rect.setLeft(0);
+  rect.setWidth(m_View->columnWidth(0) + m_View->columnWidth(1) + m_View->columnWidth(2));
+  painter->drawPixmap(rect, cache);
+}
+
+
+void DownloadListWidgetCompactDelegate::paintPendingDownload(int downloadIndex) const
+{
+  std::tuple<QString, int, int> nexusids = m_Manager->getPendingDownload(downloadIndex);
+  m_NameLabel->setText(tr("< game %1 mod %2 file %3 >").arg(std::get<0>(nexusids)).arg(std::get<1>(nexusids)).arg(std::get<2>(nexusids)));
+  if (m_SizeLabel != nullptr) {
+    m_SizeLabel->setText("???");
+  }
+  m_DoneLabel->setVisible(true);
+  m_DoneLabel->setText(tr("Pending"));
+  m_Progress->setVisible(false);
+}
+
+
+void DownloadListWidgetCompactDelegate::paintRegularDownload(int downloadIndex) const
+{
+  QString name = m_MetaDisplay ? m_Manager->getDisplayName(downloadIndex) : m_Manager->getFileName(downloadIndex);
+  if (name.length() > 53) {
+    name.truncate(50);
+    name.append("...");
+  }
+  m_NameLabel->setText(name);
+
+  DownloadManager::DownloadState state = m_Manager->getState(downloadIndex);
+
+  if ((m_SizeLabel != nullptr) && (state >= DownloadManager::STATE_READY)) {
+    m_SizeLabel->setText(QString::number(m_Manager->getFileSize(downloadIndex) / 1048576));
+  }
+
+  if ((state == DownloadManager::STATE_PAUSED) || (state == DownloadManager::STATE_ERROR)) {
+    m_DoneLabel->setVisible(true);
+    m_Progress->setVisible(false);
+    m_DoneLabel->setText(QString("%1<img src=\":/MO/gui/inactive\">").arg(tr("Paused")));
+  } else if (state == DownloadManager::STATE_FETCHINGMODINFO) {
+    m_DoneLabel->setText(QString("%1").arg(tr("Fetching Info 1")));
+  } else if (state == DownloadManager::STATE_FETCHINGFILEINFO) {
+    m_DoneLabel->setText(QString("%1").arg(tr("Fetching Info 2")));
+  } else if (state >= DownloadManager::STATE_READY) {
+    m_DoneLabel->setVisible(true);
+    m_Progress->setVisible(false);
+    if (state == DownloadManager::STATE_INSTALLED) {
+      m_DoneLabel->setText(QString("%1<img src=\":/MO/gui/check\">").arg(tr("Installed")));
+    } else if (state == DownloadManager::STATE_UNINSTALLED) {
+      m_DoneLabel->setText(QString("%1<img src=\":/MO/gui/awaiting\">").arg(tr("Uninstalled")));
+    } else {
+      m_DoneLabel->setText(QString("%1<img src=\":/MO/gui/active\">").arg(tr("Done")));
+    }
+    if (m_Manager->isInfoIncomplete(downloadIndex)) {
+      m_NameLabel->setText("<img src=\":/MO/gui/warning_16\"/> " + m_NameLabel->text());
+    }
+  } else {
+    m_DoneLabel->setVisible(false);
+    m_Progress->setVisible(true);
+    m_Progress->setValue(m_Manager->getProgress(downloadIndex).first);
+    m_Progress->setFormat(m_Manager->getProgress(downloadIndex).second);
+  }
+}
+
+void DownloadListWidgetCompactDelegate::paint(QPainter *painter, const QStyleOptionViewItem &option, const QModelIndex &index) const
+{
+#pragma message("This is quite costy - room for optimization?")
+  try {
+    auto iter = m_Cache.find(index.row());
+    if (iter != m_Cache.end()) {
+      drawCache(painter, option, *iter);
+      return;
+    }
+
+    m_ItemWidget->resize(QSize(m_View->columnWidth(0) + m_View->columnWidth(1) + m_View->columnWidth(2), option.rect.height()));
+    if (index.row() % 2 == 1) {
+      m_ItemWidget->setBackgroundRole(QPalette::AlternateBase);
+    } else {
+      m_ItemWidget->setBackgroundRole(QPalette::Base);
+    }
+
+    int downloadIndex = index.data().toInt();
+    if (downloadIndex >= m_Manager->numTotalDownloads()) {
+      paintPendingDownload(downloadIndex - m_Manager->numTotalDownloads());
+    } else {
+      paintRegularDownload(downloadIndex);
+    }
+
+#pragma message("caching disabled because changes in the list (including resorting) doesn't work correctly")
+    if (false) {
+//    if (state >= DownloadManager::STATE_READY) {
+#if QT_VERSION >= QT_VERSION_CHECK(5,0,0)
+      QPixmap cache = m_ItemWidget->grab();
+#else
+      QPixmap cache = QPixmap::grabWidget(m_ItemWidget);
+#endif
+      m_Cache[index.row()] = cache;
+      drawCache(painter, option, cache);
+    } else {
+      painter->save();
+      painter->translate(QPoint(0, option.rect.topLeft().y()));
+
+      m_ItemWidget->render(painter);
+      painter->restore();
+    }
+  } catch (const std::exception &e) {
+    qCritical("failed to paint download list item %d: %s", index.row(), e.what());
+  }
+}
+
+QSize DownloadListWidgetCompactDelegate::sizeHint(const QStyleOptionViewItem&, const QModelIndex&) const
+{
+  const int width = m_ItemWidget->minimumWidth();
+  const int height = m_ItemWidget->height();
+  return QSize(width, height);
+}
+
+
+void DownloadListWidgetCompactDelegate::issueInstall()
+{
+  emit installDownload(m_ContextIndex.row());
+}
+
+void DownloadListWidgetCompactDelegate::issueQueryInfo()
+{
+  emit queryInfo(m_ContextIndex.row());
+}
+
+void DownloadListWidgetCompactDelegate::issueDelete()
+{
+  emit removeDownload(m_ContextIndex.row(), true);
+}
+
+void DownloadListWidgetCompactDelegate::issueRemoveFromView()
+{
+  emit removeDownload(m_ContextIndex.row(), false);
+}
+
+void DownloadListWidgetCompactDelegate::issueRestoreToView()
+{
+  emit restoreDownload(m_ContextIndex.row());
+}
+
+void DownloadListWidgetCompactDelegate::issueCancel()
+{
+  emit cancelDownload(m_ContextIndex.row());
+}
+
+void DownloadListWidgetCompactDelegate::issuePause()
+{
+  emit pauseDownload(m_ContextIndex.row());
+}
+
+void DownloadListWidgetCompactDelegate::issueResume()
+{
+  emit resumeDownload(m_ContextIndex.row());
+}
+
+void DownloadListWidgetCompactDelegate::issueDeleteAll()
+{
+  if (QMessageBox::question(nullptr, tr("Are you sure?"),
+                            tr("This will remove all finished downloads from this list and from disk."),
+                            QMessageBox::Yes | QMessageBox::No) == QMessageBox::Yes) {
+    emit removeDownload(-1, true);
+  }
+}
+
+void DownloadListWidgetCompactDelegate::issueDeleteCompleted()
+{
+  if (QMessageBox::question(nullptr, tr("Are you sure?"),
+                            tr("This will remove all installed downloads from this list and from disk."),
+                            QMessageBox::Yes | QMessageBox::No) == QMessageBox::Yes) {
+    emit removeDownload(-2, true);
+  }
+}
+
+void DownloadListWidgetCompactDelegate::issueRemoveFromViewAll()
+{
+  if (QMessageBox::question(nullptr, tr("Are you sure?"),
+                            tr("This will permanently remove all finished downloads from this list (but NOT from disk)."),
+                            QMessageBox::Yes | QMessageBox::No) == QMessageBox::Yes) {
+    emit removeDownload(-1, false);
+  }
+}
+
+void DownloadListWidgetCompactDelegate::issueRemoveFromViewCompleted()
+{
+  if (QMessageBox::question(nullptr, tr("Are you sure?"),
+                            tr("This will permanently remove all installed downloads from this list (but NOT from disk)."),
+                            QMessageBox::Yes | QMessageBox::No) == QMessageBox::Yes) {
+    emit removeDownload(-2, false);
+  }
+}
+
+
+bool DownloadListWidgetCompactDelegate::editorEvent(QEvent *event, QAbstractItemModel *model,
+                                   const QStyleOptionViewItem &option, const QModelIndex &index)
+{
+  try {
+    if (event->type() == QEvent::MouseButtonDblClick) {
+      QModelIndex sourceIndex = qobject_cast<QSortFilterProxyModel*>(model)->mapToSource(index);
+      if (m_Manager->getState(sourceIndex.row()) >= DownloadManager::STATE_READY) {
+        emit installDownload(sourceIndex.row());
+      } else if (m_Manager->getState(sourceIndex.row()) >= DownloadManager::STATE_PAUSED) {
+        emit resumeDownload(sourceIndex.row());
+      }
+      return true;
+    } else if (event->type() == QEvent::MouseButtonRelease) {
+      QMouseEvent *mouseEvent = static_cast<QMouseEvent*>(event);
+      if (mouseEvent->button() == Qt::RightButton) {
+        QMenu menu;
+        bool hidden = false;
+        m_ContextIndex = qobject_cast<QSortFilterProxyModel*>(model)->mapToSource(index);
+        if (m_ContextIndex.row() < m_Manager->numTotalDownloads()) {
+          DownloadManager::DownloadState state = m_Manager->getState(m_ContextIndex.row());
+          hidden = m_Manager->isHidden(m_ContextIndex.row());
+          if (state >= DownloadManager::STATE_READY) {
+            menu.addAction(tr("Install"), this, SLOT(issueInstall()));
+            if (m_Manager->isInfoIncomplete(m_ContextIndex.row())) {
+              menu.addAction(tr("Query Info"), this, SLOT(issueQueryInfo()));
+            }
+            menu.addAction(tr("Delete"), this, SLOT(issueDelete()));
+            if (hidden) {
+              menu.addAction(tr("Un-Hide"), this, SLOT(issueRestoreToView()));
+            } else {
+              menu.addAction(tr("Hide"), this, SLOT(issueRemoveFromView()));
+            }
+          } else if (state == DownloadManager::STATE_DOWNLOADING){
+            menu.addAction(tr("Cancel"), this, SLOT(issueCancel()));
+            menu.addAction(tr("Pause"), this, SLOT(issuePause()));
+          } else if ((state == DownloadManager::STATE_PAUSED) || (state == DownloadManager::STATE_ERROR)) {
+            menu.addAction(tr("Remove"), this, SLOT(issueDelete()));
+            menu.addAction(tr("Resume"), this, SLOT(issueResume()));
+          }
+
+          menu.addSeparator();
+        }
+        menu.addAction(tr("Delete Installed..."), this, SLOT(issueDeleteCompleted()));
+        menu.addAction(tr("Delete All..."), this, SLOT(issueDeleteAll()));
+        if (!hidden) {
+          menu.addSeparator();
+          menu.addAction(tr("Hide Installed..."), this, SLOT(issueRemoveFromViewCompleted()));
+          menu.addAction(tr("Hide All..."), this, SLOT(issueRemoveFromViewAll()));
+        }
+        menu.exec(mouseEvent->globalPos());
+
+        event->accept();
+        return false;
+      }
+    }
+  } catch (const std::exception &e) {
+    qCritical("failed to handle editor event: %s", e.what());
+  }
+
+  return QItemDelegate::editorEvent(event, model, option, index);
+}
+