Merge pull request #2 from Holt59/fix-optional-plugins

Fix not-selected plugins

src/dialog.py

@@ -1,10 +1,11 @@
 # -*- encoding: utf-8 -*-
 
 from pathlib import Path
-from typing import Any, List, Mapping, Optional, Tuple
+from typing import Any, Dict, List, Mapping, Optional, Set, Tuple
 
 from PyQt5.QtCore import Qt, pyqtSignal
 from PyQt5.QtGui import QPixmap, QKeySequence, QFontDatabase
+from PyQt5.QtWidgets import QApplication
 from PyQt5 import QtWidgets
 
 import mobase
@@ -278,7 +279,7 @@ class WizardInstallerCompletePage(QtWidgets.QWidget):
         kvisitor: WizardRunnerKeywordVisitor = context.factory.kvisitor  # type: ignore
 
         # The list of plugins in selected sub-packages:
-        plugins: List[str] = []
+        plugins: Set[str] = set()
 
         # SubPackages:
         for sp in kvisitor.subpackages:
@@ -289,9 +290,15 @@ class WizardInstallerCompletePage(QtWidgets.QWidget):
             else:
                 item.setCheckState(Qt.Unchecked)
             item.setFlags(item.flags() & ~Qt.ItemIsUserCheckable)  # type: ignore
-            plugins.extend(kvisitor.plugins_for(sp))
+            plugins.update(kvisitor.plugins_for(sp))
             self.ui.subpackagesList.addItem(item)
 
+        # Switch the renamed plugins:
+        for plugin in list(plugins):
+            if plugin in self.state.renames:
+                plugins.remove(plugin)
+                plugins.add(self.state.renames[plugin])
+
         # Plugins:
         for plugin in sorted(plugins):
             item = QtWidgets.QListWidgetItem()
@@ -353,17 +360,16 @@ class WizardInstallerCompletePage(QtWidgets.QWidget):
                 sp.append(item.text())
         return sp
 
-    def plugins(self) -> List[str]:
+    def plugins(self) -> Dict[str, bool]:
         """
         Returns:
             The list of plugins selected in the UI (either automatically by the
             interpreter or by the user).
         """
-        sp: List[str] = []
+        sp: Dict[str, bool] = {}
         for i in range(self.ui.pluginsList.count()):
             item = self.ui.pluginsList.item(i)
-            if item.checkState() == Qt.Checked:
-                sp.append(item.text())
+            sp[item.text()] = item.checkState() == Qt.Checked
         return sp
 
     def tweaks(self) -> Mapping[str, List[WizardINISetting]]:
@@ -524,7 +530,7 @@ class WizardInstallerDialog(QtWidgets.QDialog):
         assert isinstance(widget, WizardInstallerCompletePage)
         return widget.subpackages()
 
-    def plugins(self):
+    def plugins(self) -> Dict[str, bool]:
         """
         Returns:
             The list of plugins to install and enable. Only valid if exec() returned
@@ -624,13 +630,13 @@ class WizardInstallerDialog(QtWidgets.QDialog):
 
         name: str = self.ui.nextBtn.text()
         if isinstance(widget, WizardInstallerSelectPage):
-            name = self._tr("Next")
+            name = self.__tr("Next")
         elif isinstance(widget, WizardInstallerRequiresVersionPage):
-            name = self._tr("Install anyway")
+            name = self.__tr("Install anyway")
         elif isinstance(widget, (WizardInstallerCancelPage, WizardInstallerErrorPage)):
             self.ui.nextBtn.setDisabled(True)
         else:
-            name = self._tr("Install")
+            name = self.__tr("Install")
 
         self.ui.nextBtn.setText(name)
 
@@ -683,5 +689,5 @@ class WizardInstallerDialog(QtWidgets.QDialog):
         self._update_focus()
         return super().exec()
 
-    def _tr(self, txt: str) -> str:
-        return QtWidgets.QApplication.translate("WizardInstaller", txt)
+    def __tr(self, str):
+        return QApplication.translate("WizardInstallerDialog", str)

src/installer.py

@@ -53,11 +53,14 @@ class WizardInstaller(mobase.IPluginInstallerSimple):
     def name(self):
         return "BAIN Wizard Installer"
 
+    def localizedName(self) -> str:
+        return self.__tr("BAIN Wizard Installer")
+
     def author(self):
         return "Holt59"
 
     def description(self):
-        return self._tr("Installer for BAIN archive containing wizard scripts.")
+        return self.__tr("Installer for BAIN archive containing wizard scripts.")
 
     def version(self):
         return mobase.VersionInfo(1, 0, 2)
@@ -134,10 +137,10 @@ class WizardInstaller(mobase.IPluginInstallerSimple):
 
     def _hasFomodInstaller(self) -> bool:
         # Do not consider the NCC installer.
-        return bool(self._organizer.pluginSetting("Fomod Installer", "enabled"))
+        return self._organizer.isPluginEnabled("Fomod Installer")
 
     def _hasOmodInstaller(self) -> bool:
-        return bool(self._organizer.pluginSetting("Omod Installer", "enabled"))
+        return self._organizer.isPluginEnabled("Omod Installer")
 
     def _getWizardArchiveBase(
         self, tree: mobase.IFileTree, data_name: str, checker: mobase.ModDataChecker
@@ -332,6 +335,14 @@ class WizardInstaller(mobase.IPluginInstallerSimple):
 
                 tree.move(entry, new)
 
+            # Move not selected plugins to optional:
+            for plugin, enabled in dialog.plugins().items():
+                if not enabled:
+                    entry = tree.find(plugin)
+                    if not entry:
+                        continue  # silently fail since the plugin should be disabled
+                    tree.addDirectory("optional").insert(entry)
+
             # TODO: INI Tweaks:
             alltweaks = dialog.tweaks()
 
@@ -385,7 +396,7 @@ class WizardInstaller(mobase.IPluginInstallerSimple):
         else:
             return mobase.InstallResult.CANCELED
 
-    def _tr(self, str):
+    def __tr(self, str) -> str:
         # We need this to translate string in Python. Check the common documentation
         # for more details:
         return QApplication.translate("WizardInstaller", str)

src/installer_wizard_en.ts

@@ -1,12 +1,20 @@
 <?xml version="1.0" encoding="utf-8"?>
 <!DOCTYPE TS><TS version="2.0">
 <context>
-    <name>WizardInstallerComplete</name>
+    <name>WizardInstaller</name>
     <message>
-        <location filename="ui/wizardinstallercomplete.ui" line="14"/>
-        <source>Form</source>
+        <location filename="installer.py" line="63"/>
+        <source>Installer for BAIN archive containing wizard scripts.</source>
         <translation type="unfinished"></translation>
     </message>
+    <message>
+        <location filename="installer.py" line="57"/>
+        <source>BAIN Wizard Installer</source>
+        <translation type="unfinished"></translation>
+    </message>
+</context>
+<context>
+    <name>WizardInstallerComplete</name>
     <message>
         <location filename="ui/wizardinstallercomplete.ui" line="40"/>
         <source>The installer script has finished. The following sub-packages and plugins will be installed.</source>
@@ -35,6 +43,21 @@
 </context>
 <context>
     <name>WizardInstallerDialog</name>
+    <message>
+        <location filename="ui/wizardinstallerdialog.ui" line="102"/>
+        <source>Next</source>
+        <translation type="unfinished"></translation>
+    </message>
+    <message>
+        <location filename="dialog.py" line="635"/>
+        <source>Install anyway</source>
+        <translation type="unfinished"></translation>
+    </message>
+    <message>
+        <location filename="dialog.py" line="639"/>
+        <source>Install</source>
+        <translation type="unfinished"></translation>
+    </message>
     <message>
         <location filename="ui/wizardinstallerdialog.ui" line="14"/>
         <source>BAIN Wizard Installer</source>
@@ -60,42 +83,14 @@
         <source>Back</source>
         <translation type="unfinished"></translation>
     </message>
-    <message>
-        <location filename="ui/wizardinstallerdialog.ui" line="102"/>
-        <source>Next</source>
-        <translation type="unfinished"></translation>
-    </message>
     <message>
         <location filename="ui/wizardinstallerdialog.ui" line="109"/>
         <source>Cancel</source>
         <translation type="unfinished"></translation>
     </message>
 </context>
-<context>
-    <name>WizardInstallerError</name>
-    <message>
-        <location filename="ui/wizardinstallererror.ui" line="14"/>
-        <source>Form</source>
-        <translation type="unfinished"></translation>
-    </message>
-    <message>
-        <location filename="ui/wizardinstallererror.ui" line="71"/>
-        <source>TextLabel</source>
-        <translation type="unfinished"></translation>
-    </message>
-</context>
 <context>
     <name>WizardInstallerPage</name>
-    <message>
-        <location filename="ui/wizardinstallerpage.ui" line="14"/>
-        <source>Form</source>
-        <translation type="unfinished"></translation>
-    </message>
-    <message>
-        <location filename="ui/wizardinstallerpage.ui" line="96"/>
-        <source>TextLabel</source>
-        <translation type="unfinished"></translation>
-    </message>
     <message>
         <location filename="ui/wizardinstallerpage.ui" line="114"/>
         <source>Options:</source>
@@ -109,11 +104,6 @@
 </context>
 <context>
     <name>WizardInstallerRequires</name>
-    <message>
-        <location filename="ui/wizardinstallerrequires.ui" line="14"/>
-        <source>Form</source>
-        <translation type="unfinished"></translation>
-    </message>
     <message>
         <location filename="ui/wizardinstallerrequires.ui" line="34"/>
         <source>&lt;html&gt;&lt;head/&gt;&lt;body&gt;&lt;p&gt;&lt;span style=&quot; font-weight:600;&quot;&gt;Warning:&lt;/span&gt; The following version requirements are not met for using this installer.&lt;/p&gt;&lt;/body&gt;&lt;/html&gt;</source>

src/ui/wizardinstallercomplete.ui

@@ -11,7 +11,7 @@
    </rect>
   </property>
   <property name="windowTitle">
-   <string>Form</string>
+   <string notr="true"/>
   </property>
   <layout class="QVBoxLayout" name="verticalLayout_2">
    <property name="leftMargin">

src/ui/wizardinstallererror.ui

@@ -11,7 +11,7 @@
    </rect>
   </property>
   <property name="windowTitle">
-   <string>Form</string>
+   <string notr="true"/>
   </property>
   <layout class="QVBoxLayout" name="verticalLayout_2">
    <property name="leftMargin">
@@ -45,7 +45,7 @@
           </size>
          </property>
          <property name="text">
-          <string>TextLabel</string>
+          <string notr="true"/>
          </property>
         </widget>
        </item>
@@ -68,7 +68,7 @@
        <item>
         <widget class="QLabel" name="titleLabel">
          <property name="text">
-          <string>TextLabel</string>
+          <string notr="true"/>
          </property>
          <property name="wordWrap">
           <bool>true</bool>
@@ -82,6 +82,16 @@
        <property name="readOnly">
         <bool>true</bool>
        </property>
+       <property name="markdown">
+        <string notr="true"/>
+       </property>
+       <property name="html">
+        <string notr="true">&lt;!DOCTYPE HTML PUBLIC &quot;-//W3C//DTD HTML 4.0//EN&quot; &quot;http://www.w3.org/TR/REC-html40/strict.dtd&quot;&gt;
+&lt;html&gt;&lt;head&gt;&lt;meta name=&quot;qrichtext&quot; content=&quot;1&quot; /&gt;&lt;style type=&quot;text/css&quot;&gt;
+p, li { white-space: pre-wrap; }
+&lt;/style&gt;&lt;/head&gt;&lt;body style=&quot; font-family:'MS Shell Dlg 2'; font-size:8.25pt; font-weight:400; font-style:normal;&quot;&gt;
+&lt;p style=&quot;-qt-paragraph-type:empty; margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; -qt-block-indent:0; text-indent:0px;&quot;&gt;&lt;br /&gt;&lt;/p&gt;&lt;/body&gt;&lt;/html&gt;</string>
+       </property>
       </widget>
      </item>
     </layout>

src/ui/wizardinstallerpage.ui

@@ -11,7 +11,7 @@
    </rect>
   </property>
   <property name="windowTitle">
-   <string>Form</string>
+   <string notr="true"/>
   </property>
   <layout class="QVBoxLayout" name="verticalLayout_2">
    <property name="leftMargin">
@@ -93,7 +93,7 @@
              <enum>QFrame::Sunken</enum>
             </property>
             <property name="text">
-             <string>TextLabel</string>
+             <string notr="true"/>
             </property>
             <property name="wordWrap">
              <bool>true</bool>

src/ui/wizardinstallerrequires.ui

@@ -11,7 +11,7 @@
    </rect>
   </property>
   <property name="windowTitle">
-   <string>Form</string>
+   <string notr="true"/>
   </property>
   <layout class="QVBoxLayout" name="verticalLayout_2">
    <property name="leftMargin">