Skip empty mod dirs when evaluating overwrite

Update translations. (#18 )
Merge pull request #16 from Liderate/SSE_InvalidFontConfig
2026-07-27 14:03:10 -07:00 · 2025-05-03 02:47:57 -05:00 · 2024-07-21 15:56:54 +02:00 · 2024-05-25 14:32:39 +02:00 · 2023-11-29 14:24:14 -05:00 · 2023-10-13 18:59:06 +02:00
2 changed files with 39 additions and 26 deletions
@@ -204,10 +204,22 @@ bool DiagnoseBasic::overwriteFiles() const
  //QString dirname(qApp->property("dataPath").toString() + "/overwrite");
  QString dirname(m_MOInfo->overwritePath());
  if (m_MOInfo->pluginSetting(name(), "ow_ignore_empty").toBool() ||
-      m_MOInfo->pluginSetting(name(), "ow_ignore_log").toBool()) {
+    m_MOInfo->pluginSetting(name(), "ow_ignore_log").toBool()) {
    return !checkEmpty(dirname);
  }
  QDir dir(dirname);
+  bool checkDirs = m_MOInfo->managedGame()->getModMappings().keys().size() > 1 || m_MOInfo->managedGame()->getModMappings().keys().first() != "";
+  if (checkDirs) {
+      bool empty = true;
+      for (auto dir : m_MOInfo->managedGame()->getModMappings().keys()) {
+          auto mapDir = QDir(dirname).filePath(dir);
+          if (QDir(mapDir).exists()) {
+              empty = QDir(mapDir).count() == 2; // account for . and ..
+          }
+          if (!empty) break;
+      }
+      return !empty;
+  }
  return dir.count() != 2; // account for . and ..
 }

@@ -256,6 +268,7 @@ bool DiagnoseBasic::missingMasters() const
  }

  m_MissingMasters.clear();
+  m_PluginChildren.clear();
  // for each required master in each esp, test if it's in the list of enabled masters.
  for (const QString &esp : esps) {
    QString baseName = QFileInfo(esp).fileName();
@@ -283,7 +296,7 @@ bool DiagnoseBasic::alternateGame() const

 bool DiagnoseBasic::invalidFontConfig() const
 {
-  if ((m_MOInfo->managedGame()->gameName() != "Skyrim") && (m_MOInfo->managedGame()->gameName() != "SkyrimSE"))  {
+  if ((m_MOInfo->managedGame()->gameName() != "Skyrim") && (m_MOInfo->managedGame()->gameShortName() != "SkyrimSE"))  {
    // this check is only for skyrim
    return false;
  }
Author	SHA1	Message	Date
Jeremy Rimpo	9531efe2f0	Skip empty mod dirs when evaluating overwrite	2025-05-03 02:47:57 -05:00
Mikaël Capelle	7fc98c5d4e	Update translations. (#18 )	2024-07-21 15:56:54 +02:00
Mikaël Capelle	3b0e5c44ed	Merge pull request #16 from Liderate/SSE_InvalidFontConfig Fix SSE check in invalidFontConfig	2024-05-25 14:32:39 +02:00
Liderate	cde4731e5e	Fix SSE check in invalidFontConfig	2023-11-29 14:24:14 -05:00
Mikaël Capelle	51099bed28	Merge pull request #15 from Liderate/master Clear m_PluginChildren to prevent stale entries.	2023-10-13 18:59:06 +02:00
Liderate	5b3d2adac5	Clear m_PluginChildren to prevent stale entries.	2023-10-12 02:17:06 -04:00