diagnosis plugin now warns when nitpick is installed

- files moved will now also be treated as "deleted" in the old location so a newly created file with that same name is not created in overwrite
- introduced a mechanism by which MO can recognize if it crashed before when attempting to load a plugin. That plugin can be blacklisted so it doesn't get loaded again
- plugins can now programaticaly change their settings
- plugins can now store data persistently without exposing that data as settings
- requesting an unset-setting from a plugin is no longer treated as a bug
- clarified warning message for when files are in overwrite directory
- the proxyPython plugin will now discover if python initialization crashed MO on a previous session and give the user a chance to fix it or disable the plugin
- bugfix: GetModuleFileName modified the buffer past the zero termination. While this doesn't violate the API documentation it is different from the regular windows implementation
- bugfix: proxy plugins couldn't access the parent widget
- bugfix: when moving a file from overwrite to a mod the in-memory file structure wasn't updated
- bugfix: name input dialog for profiles allowed names that weren't valid directory names
- bugfix: profile dialog wasn't able to delete profiles if the name started or ended in whitespaces
- bugfix: The name-cells for plugin settings could be changed (without effect)
- removed a few obsolete files from the repository

src/diagnosebasic.cpp

@@ -108,6 +108,12 @@ bool DiagnoseBasic::overwriteFiles() const
   return dir.count() != 2; // account for . and ..
 }
 
+bool DiagnoseBasic::nitpickInstalled() const
+{
+  QString path = m_MOInfo->resolvePath("skse/plugins/nitpick.dll");
+  return !path.isEmpty();
+}
+
 bool DiagnoseBasic::invalidFontConfig() const
 {
   if (m_MOInfo->gameInfo().type() != IGameInfo::TYPE_SKYRIM) {
@@ -166,6 +172,9 @@ std::vector<unsigned int> DiagnoseBasic::activeProblems() const
   if (invalidFontConfig()) {
     result.push_back(PROBLEM_INVALIDFONT);
   }
+  if (nitpickInstalled()) {
+    result.push_back(PROBLEM_NITPICKINSTALLED);
+  }
 
   return result;
 }
@@ -179,6 +188,8 @@ QString DiagnoseBasic::shortDescription(unsigned int key) const
       return tr("There are files in your overwrite mod");
     case PROBLEM_INVALIDFONT:
       return tr("Your font configuration may be broken");
+    case PROBLEM_NITPICKINSTALLED:
+      return tr("Nitpick installed");
     default:
       throw MyException(tr("invalid problem key %1").arg(key));
   }
@@ -190,13 +201,19 @@ QString DiagnoseBasic::fullDescription(unsigned int key) const
     case PROBLEM_ERRORLOG:
       return "<code>" + m_ErrorMessage.replace("\n", "<br>") + "</code>";
     case PROBLEM_OVERWRITE:
-      return tr("Files in the <font color=\"red\"><i>Overwrite</i></font> mod are are usually files created by a foreign tool (i.e. Wrye Bash, Automatic Variants, ...).<br>"
-                "For technical reasons it's not possible to assign those files to the corresponding mod automatically, you have to deal with these "
-                "files manually.<br>Use the right-click menu on <font color=\"red\"><i>Overwrite</i></font> to create a regular mod from all the files currently in that folder or double "
-                "click it and then drag&drop files to an existing mod.");
+      return tr("Files in the <font color=\"red\"><i>Overwrite</i></font> mod are are usually files created by an external tool (i.e. Wrye Bash, Automatic Variants, ...).<br>"
+                "It is advisable you empty Overwrite directory by moving those files to an existing mod. You can do this by double-clicking the <font color=\"red\"><i>Overwrite</i></font> mod and use drag&drop to move the files to a mod.<br>"
+                "Alternatively, right-click on <font color=\"red\"><i>Overwrite</i></font> and create a new regular mod from the files there.<br>"
+                "<br>"
+                "Why is this necessary? Generated files may depend on the other mods active in a profile and may thus be incompatible with a different profile (i.e. bashed patches from Wrye Bash). "
+                "On the other hand the file may be necessary in all profiles (i.e. dlc esms after cleaning with TESVEdit)<br>"
+                "This can NOT be automated you HAVE to read up on the tools you use and make an educated decision.");
     case PROBLEM_INVALIDFONT:
       return tr("Your current configuration seems to reference a font that is not installed. You may see only boxes instead of letters.<br>"
                 "The font configuration is in Data\\interface\\fontconfig.txt. Most likely you have a broken installation of a font replacer mod.");
+    case PROBLEM_NITPICKINSTALLED:
+      return tr("You have the nitpick skse plugin installed. This plugin is not needed with Mod Organizer because MO already offers the same functionality. "
+                "Worse: The two solutions may conflict so it's strongly suggested you remove this plugin.");
     default:
       throw MyException(tr("invalid problem key %1").arg(key));
   }

src/diagnosebasic.h

@@ -42,12 +42,14 @@ private:
   bool errorReported() const;
   bool overwriteFiles() const;
   bool invalidFontConfig() const;
+  bool nitpickInstalled() const;
 
 private:
 
   static const unsigned int PROBLEM_ERRORLOG = 1;
   static const unsigned int PROBLEM_OVERWRITE = 2;
   static const unsigned int PROBLEM_INVALIDFONT = 3;
+  static const unsigned int PROBLEM_NITPICKINSTALLED = 4;
 
   static const unsigned int NUM_CONTEXT_ROWS = 5;