m5/MicroPythonOS
0
0
Fork 0
mirror of https://github.com/m5stack/MicroPythonOS.git synced 2026-05-20 11:51:27 -07:00
Code Issues Packages Projects Releases Wiki Activity

quirc_decode: back to memcpy for stability

Browse Source
This commit is contained in:
Thomas Farstrike
2025-11-28 17:55:02 +01:00
parent 8f4b3c5fbe
commit 6b8b72a7a0
1 changed files with 8 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
c_mpos/src/quirc_decode.c
+8 -5
View File
@@ -56,12 +56,15 @@ static mp_obj_t qrdecode(mp_uint_t n_args, const mp_obj_t *args) {
//QRDECODE_DEBUG_PRINT("qrdecode: Resized quirc object\n");
uint8_t *image = quirc_begin(qr, NULL, NULL);
//memcpy(image, bufinfo.buf, width * height);
uint8_t *temp_image = image;
//image = bufinfo.buf; // use existing buffer, rather than memcpy - but this doesnt find any images anymore :-/
qr->image = bufinfo.buf; // if this works then we can also eliminate quirc's ps_alloc()
memcpy(image, bufinfo.buf, width * height);
// would be nice to be able to use the existing buffer (bufinfo.buf) here, avoiding memcpy,
// but that buffer is also being filled by image capture and displayed by lvgl
// and that becomes unstable... it shows black artifacts and crashes sometimes...
//uint8_t *temp_image = image;
//image = bufinfo.buf;
//qr->image = bufinfo.buf; // if this works then we can also eliminate quirc's ps_alloc()
quirc_end(qr);
qr->image = temp_image; // restore, because quirc will try to free it
//qr->image = temp_image; // restore, because quirc will try to free it
/*
// Pointer swap - NO memcpy, NO internal.h needed