Building cbindgen takes a few minutes on Windows, so avoid that by using
the version included in the GitHub Actions runner.
The version include in the runners isn't the same as what the build
expects, but hopefully the differences aren't significant.
Windows CI builds are currently failing with the following error:
-- Checking for module 'libssh2'
-- Found libssh2, version 1.8.2
CMake Error at cmake/FindPkgLibraries.cmake:17 (MESSAGE):
could not resolve ssh2
Call Stack (most recent call first):
src/CMakeLists.txt:213 (FIND_PKGLIBRARIES)
this is odd, but can be avoided by not building in SSH support. LOOT's
masterlists are all downloaded over HTTPS, so this wouldn't break
anything (unless there are people hosting their own masterlists that
aren't accessible over HTTPS, but that's very unlikely).
AppVeyor is breaking my builds because I can't create any more artifacts
because I've hit the limit, but there's no way to have it not store
artifacts or to manually delete artifacts...
This also updates Boost from 1.67.0 to 1.69.0 due to differences between
the AppVeyor and GitHub Actions build environments.
When display_ is an empty string, GetDisplayName() returns name_, but
name_'s value might contain Markdown special characters, and
GetDisplayName() is supposed to return a Markdown string, though this
was poorly documented.
Unlike the other metadata classes, they were only comparing plugin names
not full object equality. Checking full object equality isn't very
useful, so instead the operators have been replaced by a new
NameMatches() method that takes a non-regex plugin name string.
Oliver Hamlet