Some more content derivation cleanup.

This commit is contained in:
Oliver Hamlet
2014-11-17 18:12:35 +00:00
parent 6535e46393
commit fdeb5c486f
2 changed files with 13 additions and 22 deletions
+12 -20
View File
@@ -195,7 +195,7 @@ loot-clear-metadata
},
dataChanged: function(oldValue, newValue) {
if (newValue != undefined) {
if (newValue) {
if (newValue.isEditorOpen) {
/* Share the data with the editor. */
this.shadowRoot.getElementById('editor').data = newValue;
@@ -219,32 +219,24 @@ loot-clear-metadata
},
onTagsChange: function(oldValue, newValue) {
var tags;
if (this.data) {
tags = this.data.computed.tags;
} else {
tags = {
added: [],
removed: []
};
this.getElementsByClassName('tag add')[0].classList.toggle('hidden', this.data.computed.tags.added.length == 0);
this.getElementsByClassName('tag remove')[0].classList.toggle('hidden', this.data.computed.tags.removed.length == 0);
}
this.getElementsByClassName('tag add')[0].classList.toggle('hidden', tags.added.length == 0);
this.getElementsByClassName('tag remove')[0].classList.toggle('hidden', tags.removed.length == 0);
},
onMessagesChange: function(oldValue, newValue) {
/* First clear any existing messages. */
var messageUL = this.getElementsByTagName('ul')[0];
while(messageUL.firstElementChild) {
messageUL.removeChild(messageUL.firstElementChild);
}
if (this.data) {
var messages = this.data.computed.messages;
for (var i = 0; i < messages.length; ++i) {
messageUL.appendChild(messages[i]);
/* First clear any existing messages. */
var messageUL = this.getElementsByTagName('ul')[0];
while(messageUL.firstElementChild) {
messageUL.removeChild(messageUL.firstElementChild);
}
messageUL.classList.toggle('hidden', messages.length == 0);
/* Now add new messages. */
this.data.computed.messages.forEach(function(message){
messageUL.appendChild(message);
});
messageUL.classList.toggle('hidden', this.data.computed.messages.length == 0);
}
},
+1 -2
View File
@@ -117,8 +117,7 @@ function Plugin(obj) {
var uiMessages = [];
/* Now add the new messages. */
if (this.messages && this.messages.length != 0) {
var messages = filters.applyMessageFilters(this.messages);
messages.forEach(function(message) {
filters.applyMessageFilters(this.messages).forEach(function(message) {
var messageLi = document.createElement('li');
messageLi.className = message.type;
// Use the Marked library for Markdown formatting support.