loot/libloot
0
0
Fork 0
mirror of https://github.com/loot/libloot.git synced 2026-07-27 14:16:01 -07:00
Code Issues Packages Projects Releases Wiki Activity

Fixed loot_write_minimal_list() bugs.

Browse Source 
If the output file exists but the overwrite flag is false, it's not an
invalid argument, so don't use that error code. Also fixed an uncaught
exception on write failure.
This commit is contained in:
Oliver Hamlet
2015-01-02 21:18:21 +00:00
parent afe4fdce0d
commit f26955c0d2
1 changed files with 11 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/api/api.cpp
+11 -6
View File
@@ -796,7 +796,7 @@ LOOT_API unsigned int loot_write_minimal_list(loot_db db, const char * const out
return c_error(loot_error_invalid_args, "Output directory does not exist.");
if (boost::filesystem::exists(outputFile) && !overwrite)
return c_error(loot_error_invalid_args, "Output file exists but overwrite is not set to true.");
return c_error(loot_error_file_write_fail, "Output file exists but overwrite is not set to true.");
loot::Masterlist temp = db->masterlist;
std::unordered_set<loot::Plugin> minimalPlugins;
@@ -814,11 +814,16 @@ LOOT_API unsigned int loot_write_minimal_list(loot_db db, const char * const out
<< YAML::EndMap;
boost::filesystem::path p(outputFile);
loot::ofstream out(p);
if (out.fail())
return c_error(loot_error_invalid_args, "Couldn't open output file");
out << yout.c_str();
out.close();
try {
loot::ofstream out(p);
if (out.fail())
return c_error(loot_error_invalid_args, "Couldn't open output file.");
out << yout.c_str();
out.close();
}
catch (std::exception& e) {
return c_error(loot_error_file_write_fail, e.what());
}
return loot_ok;
}