Update yaml-cpp

Now depending on a specific tag rather than a branch to avoid any
future rebases breaking anything. The tagged commit contains merge key
support on top of a revision slightly more recent than the latest
release (0.6.2), which has a few issues.

CMakeLists.txt

@@ -149,13 +149,24 @@ set(SPDLOG_INCLUDE_DIRS "${SOURCE_DIR}/include")
 
 ExternalProject_Add(yaml-cpp
                     PREFIX "external"
-                    URL "https://github.com/WrinklyNinja/yaml-cpp/archive/patched-for-loot.tar.gz"
+                    URL "https://github.com/loot/yaml-cpp/archive/yaml-cpp-0.6.2+merge-key-support.2.tar.gz"
                     CMAKE_ARGS -DMSVC_SHARED_RT=${MSVC_SHARED_RUNTIME} -DCMAKE_POSITION_INDEPENDENT_CODE=${CMAKE_POSITION_INDEPENDENT_CODE} -DCMAKE_CXX_FLAGS=${CMAKE_CXX_FLAGS}
                     BUILD_COMMAND ${CMAKE_COMMAND} --build . --target yaml-cpp --config $(CONFIGURATION)
                     INSTALL_COMMAND "")
 ExternalProject_Get_Property(yaml-cpp SOURCE_DIR BINARY_DIR)
+
+if (MSVC)
+    if (MSVC_STATIC_RUNTIME)
+      set(YAML_CPP_LIBRARY_SUFFIX "${YAML_CPP_LIBRARY_SUFFIX}mt")
+    else()
+      set(YAML_CPP_LIBRARY_SUFFIX "${YAML_CPP_LIBRARY_SUFFIX}md")
+    endif()
+endif()
+
+set(YAML_CPP_LIBRARY_SUFFIX "${LIB_SUFFIX}${YAML_CPP_LIBRARY_SUFFIX}$<$<CONFIG:Debug>:d>${CMAKE_STATIC_LIBRARY_SUFFIX}")
 set(YAML_CPP_INCLUDE_DIRS "${SOURCE_DIR}/include")
-set(YAML_CPP_LIBRARIES "${BINARY_DIR}/${CMAKE_CFG_INTDIR}/libyaml-cpp${CMAKE_STATIC_LIBRARY_SUFFIX}")
+set(YAML_CPP_LIBRARIES "${BINARY_DIR}/${CMAKE_CFG_INTDIR}/libyaml-cpp${YAML_CPP_LIBRARY_SUFFIX}")
+
 
 ##############################
 # General Settings

src/api/metadata/yaml/file.h

@@ -24,6 +24,8 @@
 #ifndef LOOT_YAML_FILE
 #define LOOT_YAML_FILE
 
+#define YAML_CPP_SUPPORT_MERGE_KEYS
+
 #include <string>
 
 #include <yaml-cpp/yaml.h>

src/api/metadata/yaml/group.h

@@ -24,6 +24,8 @@
 #ifndef LOOT_YAML_GROUP
 #define LOOT_YAML_GROUP
 
+#define YAML_CPP_SUPPORT_MERGE_KEYS
+
 #include <set>
 #include <string>
 

src/api/metadata/yaml/location.h

@@ -24,6 +24,8 @@
 #ifndef LOOT_YAML_LOCATION
 #define LOOT_YAML_LOCATION
 
+#define YAML_CPP_SUPPORT_MERGE_KEYS
+
 #include <string>
 #include <vector>
 

src/api/metadata/yaml/message.h

@@ -24,6 +24,8 @@
 #ifndef LOOT_YAML_MESSAGE
 #define LOOT_YAML_MESSAGE
 
+#define YAML_CPP_SUPPORT_MERGE_KEYS
+
 #include <string>
 #include <vector>
 

src/api/metadata/yaml/message_content.h

@@ -24,6 +24,8 @@
 #ifndef LOOT_YAML_MESSAGE_CONTENT
 #define LOOT_YAML_MESSAGE_CONTENT
 
+#define YAML_CPP_SUPPORT_MERGE_KEYS
+
 #include <string>
 
 #include <yaml-cpp/yaml.h>

src/api/metadata/yaml/plugin_cleaning_data.h

@@ -25,6 +25,8 @@
 #ifndef LOOT_YAML_PLUGIN_CLEANING_DATA
 #define LOOT_YAML_PLUGIN_CLEANING_DATA
 
+#define YAML_CPP_SUPPORT_MERGE_KEYS
+
 #include <cstdint>
 #include <string>
 

src/api/metadata/yaml/plugin_metadata.h

@@ -24,6 +24,8 @@
 #ifndef LOOT_YAML_PLUGIN_METADATA
 #define LOOT_YAML_PLUGIN_METADATA
 
+#define YAML_CPP_SUPPORT_MERGE_KEYS
+
 #include <cstdint>
 #include <list>
 #include <regex>

src/api/metadata/yaml/set.h

@@ -25,6 +25,8 @@
 #ifndef LOOT_YAML_SET
 #define LOOT_YAML_SET
 
+#define YAML_CPP_SUPPORT_MERGE_KEYS
+
 #include <set>
 #include <unordered_set>
 

src/api/metadata/yaml/tag.h

@@ -24,6 +24,8 @@
 #ifndef LOOT_YAML_TAG
 #define LOOT_YAML_TAG
 
+#define YAML_CPP_SUPPORT_MERGE_KEYS
+
 #include <string>
 
 #include <yaml-cpp/yaml.h>