loot/libloot
0
0
Fork 0
mirror of https://github.com/loot/libloot.git synced 2026-07-27 14:16:01 -07:00
Code Issues Packages Projects Releases Wiki Activity

Refactor max path component length constant

Browse Source
This commit is contained in:
Oliver Hamlet
2026-01-31 15:29:33 +00:00
parent 832690957a
commit 7910670675
2 changed files with 16 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/game.rs
+13 -5
View File
@@ -846,8 +846,6 @@ mod tests {
use super::*;
const MAX_PATH_COMPONENT: usize = 255;
#[cfg(windows)]
fn symlink_dir(original: &Path, link: &Path) {
std::os::windows::fs::symlink_dir(original, link).unwrap();
@@ -926,6 +924,8 @@ mod tests {
}
mod new {
use crate::tests::MAX_PATH_COMPONENT_LENGTH;
use super::*;
#[cfg(windows)]
@@ -973,7 +973,9 @@ mod tests {
fn should_succeed_if_given_a_symlink_path() {
let fixture = Fixture::without_long_paths(GameType::Morrowind);
let symlink_game_path = fixture.root_path().join("a".repeat(MAX_PATH_COMPONENT));
let symlink_game_path = fixture
.root_path()
.join("a".repeat(MAX_PATH_COMPONENT_LENGTH));
symlink_dir(&fixture.game_path, &symlink_game_path);
assert!(symlink_game_path.is_symlink());
@@ -1003,6 +1005,8 @@ mod tests {
}
mod with_local_path {
use crate::tests::MAX_PATH_COMPONENT_LENGTH;
use super::*;
#[parameterized_test(ALL_GAME_TYPES)]
@@ -1053,11 +1057,15 @@ mod tests {
fn should_succeed_if_given_symlink_paths() {
let fixture = Fixture::without_long_paths(GameType::Oblivion);
let symlink_game_path = fixture.root_path().join("a".repeat(MAX_PATH_COMPONENT));
let symlink_game_path = fixture
.root_path()
.join("a".repeat(MAX_PATH_COMPONENT_LENGTH));
symlink_dir(&fixture.game_path, &symlink_game_path);
assert!(symlink_game_path.is_symlink());
let symlink_local_path = fixture.root_path().join("b".repeat(MAX_PATH_COMPONENT));
let symlink_local_path = fixture
.root_path()
.join("b".repeat(MAX_PATH_COMPONENT_LENGTH));
symlink_dir(&fixture.local_path, &symlink_local_path);
assert!(symlink_local_path.is_symlink());
src/tests.rs
+3 -1
View File
@@ -26,6 +26,8 @@ pub(crate) const BLANK_ESL: &str = "Blank.esl";
pub(crate) const NON_PLUGIN_FILE: &str = "NotAPlugin.esm";
pub(crate) const NON_ASCII_ESM: &str = "non\u{00C1}scii.esm";
pub(crate) const MAX_PATH_COMPONENT_LENGTH: usize = 255;
pub(crate) fn source_plugins_path(game_type: GameType) -> PathBuf {
match game_type {
GameType::Morrowind | GameType::OpenMW => {
@@ -283,7 +285,7 @@ impl Fixture {
fn with_tempdir(game_type: GameType, temp_dir: TempDir, use_long_path: bool) -> Self {
let base_path = if use_long_path {
temp_dir.path().join("a".repeat(255))
temp_dir.path().join("a".repeat(MAX_PATH_COMPONENT_LENGTH))
} else {
temp_dir.path().to_path_buf()
};