loot/libloot
0
0
Fork 0
mirror of https://github.com/loot/libloot.git synced 2026-07-27 14:16:01 -07:00
Code Issues Packages Projects Releases Wiki Activity

Replaced unnecessary querySelector usage.

Browse Source 
getElement* has better performance, so this might improve UI
responsiveness ever so slightly.
This commit is contained in:
WrinklyNinja
2014-08-21 22:19:04 +01:00
parent 1f8d0dc488
commit 74e41d2b50
3 changed files with 24 additions and 24 deletions
Download Patch File Download Diff File Expand all files Collapse all files
resources/report/js/custom.js
+14 -14
View File
@@ -46,7 +46,7 @@ var pluginMenuProto = Object.create(HTMLElement.prototype, {
loot.query(request).catch(processCefError);
} else if (evt.target.id == 'clearMetadata') {
showMessageDialog('Clear Plugin Metadata', 'Are you sure you want to clear all existing user-added metadata from "' + pluginCard.querySelector('h1').textContent + '"?', function(result){
showMessageDialog('Clear Plugin Metadata', 'Are you sure you want to clear all existing user-added metadata from "' + pluginCard.getElementsByTagName('h1')[0].textContent + '"?', function(result){
if (result) {
var request = JSON.stringify({
name: 'clearPluginMetadata',
@@ -134,7 +134,7 @@ var pluginCardProto = Object.create(HTMLElement.prototype, {
showEditorTable: {
value: function(evt) {
var tableId = evt.target.getAttribute('data-for');
var tables = evt.target.parentElement.parentElement.querySelectorAll('table');
var tables = evt.target.parentElement.parentElement.getElementsByTagName('table');
for (var i = 0; i < tables.length; ++i) {
if (tables[i].id != tableId) {
hideElement(tables[i]);
@@ -142,7 +142,7 @@ var pluginCardProto = Object.create(HTMLElement.prototype, {
showElement(tables[i]);
}
}
evt.target.parentElement.querySelector('.selected').classList.toggle('selected');
evt.target.parentElement.getElementsByClassName('selected')[0].classList.toggle('selected');
evt.target.classList.toggle('selected');
}
},
@@ -313,10 +313,10 @@ var pluginCardProto = Object.create(HTMLElement.prototype, {
for (var i = 0; i < loot.game.plugins.length; ++i) {
if (loot.game.plugins[i].id == this.id) {
this.shadowRoot.querySelector('#editor h1').textContent = loot.game.plugins[i].name;
this.shadowRoot.querySelector('#editor .version').textContent = loot.game.plugins[i].version;
this.shadowRoot.getElementById('editor').getElementsByTagName('h1')[0].textContent = loot.game.plugins[i].name;
this.shadowRoot.getElementById('editor').getElementsByClassName('version')[0].textContent = loot.game.plugins[i].version;
if (loot.game.plugins[i].crc != '0') {
this.shadowRoot.querySelector('#editor .crc').textContent = loot.game.plugins[i].crc;
this.shadowRoot.getElementById('editor').getElementsByClassName('crc')[0].textContent = loot.game.plugins[i].crc;
}
/* Fill in the editor input values. */
@@ -649,8 +649,8 @@ var messageDialogProto = Object.create(HTMLDialogElement.prototype, {
value: function(evt) {
var dialog = evt.currentTarget.parentElement.parentElement;
dialog.querySelector('.accept').removeEventListener('click', dialog.onButtonClick, false);
dialog.querySelector('.cancel').removeEventListener('click', dialog.onButtonClick, false);
dialog.getElementsByClassName('accept')[0].removeEventListener('click', dialog.onButtonClick, false);
dialog.getElementsByClassName('cancel')[0].removeEventListener('click', dialog.onButtonClick, false);
dialog.close( evt.target.className == 'accept' );
}
@@ -662,15 +662,15 @@ var messageDialogProto = Object.create(HTMLDialogElement.prototype, {
this.closeCallback = closeCallback;
this.querySelector('h1').textContent = title;
this.querySelector('p').textContent = text;
this.getElementsByTagName('h1')[0].textContent = title;
this.getElementsByTagName('p')[0].textContent = text;
this.querySelector('.accept').addEventListener('click', this.onButtonClick, false);
this.querySelector('.cancel').addEventListener('click', this.onButtonClick, false);
this.getElementsByClassName('accept')[0].addEventListener('click', this.onButtonClick, false);
this.getElementsByClassName('cancel')[0].addEventListener('click', this.onButtonClick, false);
if (type == 'error' || type == 'info') {
this.querySelector('.accept').textContent = 'OK';
this.querySelector('.cancel').style.display = 'hidden';
this.getElementsByClassName('accept')[0].textContent = 'OK';
this.getElementsByClassName('cancel')[0].style.display = 'hidden';
}
HTMLDialogElement.prototype.showModal.call(this);
resources/report/js/plugin.js
+8 -8
View File
@@ -143,10 +143,10 @@ function Plugin(obj) {
card.setAttribute('data-edits', this.userlist != undefined);
/* Fill in name, version, CRC. */
card.querySelector('h1').textContent = this.name;
card.querySelector('.version').textContent = this.version;
card.getElementsByTagName('h1')[0].textContent = this.name;
card.getElementsByClassName('version')[0].textContent = this.version;
if (this.crc != 0) {
card.querySelector('.crc').textContent = this.crc;
card.getElementsByClassName('crc')[0].textContent = this.crc;
}
/* Fill in Bash Tag suggestions. */
@@ -162,10 +162,10 @@ function Plugin(obj) {
var li = new PluginListItem();
this.li = li;
li.shadowRoot.querySelector('a').href = '#' + this.id;
li.shadowRoot.getElementsByTagName('a')[0].href = '#' + this.id;
li.querySelector('.name').textContent = this.name;
li.querySelector('.priority').textContent = this.getPriorityString();
li.getElementsByClassName('name')[0].textContent = this.name;
li.getElementsByClassName('priority')[0].textContent = this.getPriorityString();
li.setAttribute('data-dummy', this.isDummy);
li.setAttribute('data-bsa', this.loadsBSA);
@@ -180,10 +180,10 @@ function Plugin(obj) {
change.object.li.setAttribute('data-edits', change.object[change.name] != undefined);
change.object.card.setAttribute('data-edits', change.object[change.name] != undefined);
} else if (change.name == 'modPriority') {
change.object.li.querySelector('.priority').textContent = change.object.getPriorityString();
change.object.li.getElementsByClassName('priority')[0].textContent = change.object.getPriorityString();
change.object.card.shadowRoot.getElementById('priorityValue').value = change.object[change.name];
} else if (change.name == 'isGlobalPriority') {
change.object.li.querySelector('.priority').textContent = change.object.getPriorityString();
change.object.li.getElementsByClassName('priority')[0].textContent = change.object.getPriorityString();
} else if (change.name == 'messages') {
change.object.updateCardMessages();
/* For messages, the card's messages need updating,
resources/report/js/script.js
+2 -2
View File
@@ -229,9 +229,9 @@ function updateSelectedGame() {
var gameMenuItems = document.getElementById('gameMenu').children[0].children;
for (var i = 0; i < gameMenuItems.length; ++i) {
if (gameMenuItems[i].getAttribute('data-target') != loot.game.folder) {
gameMenuItems[i].querySelector('.fa').classList.toggle('fa-angle-double-right', false);
gameMenuItems[i].getElementsByClassName('fa')[0].classList.toggle('fa-angle-double-right', false);
} else {
gameMenuItems[i].querySelector('.fa').classList.toggle('fa-angle-double-right', true);
gameMenuItems[i].getElementsByClassName('fa')[0].classList.toggle('fa-angle-double-right', true);
}
}