loot/libloot
0
0
Fork 0
mirror of https://github.com/loot/libloot.git synced 2026-07-27 14:16:01 -07:00
Code Issues Packages Projects Releases Wiki Activity

Add safety check when translating dropdown selections

Browse Source 
Only update the selected item text if an item is selected, in case
translation runs before the element has finished initialising.
Fixes #732.
This commit is contained in:
Oliver Hamlet
2017-01-06 22:32:49 +00:00
parent c1838fa5e3
commit 6ed04c6f8e
1 changed files with 9 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/gui/html/js/translateStaticText.js
+9 -2
View File
@@ -217,6 +217,13 @@
document.getElementById('searchBar').shadowRoot.getElementById('search').label = l10n.translate('Search cards');
}
function updateDropdownSelectedItemText(dropdownElement) {
const paperDropdownMenu = dropdownElement.shadowRoot.querySelector('paper-dropdown-menu');
if (paperDropdownMenu.selectedItem) {
paperDropdownMenu.shadowRoot.querySelector('paper-input').value = paperDropdownMenu.selectedItem.textContent;
}
}
function translateSidebar(l10n) {
/* Nav items */
document.getElementById('sidebarTabs').firstElementChild.textContent = l10n.translate('Plugins');
@@ -239,7 +246,7 @@
conflictsFilter.label = l10n.translate('Show only conflicting plugins for');
conflictsFilter.firstElementChild.textContent = l10n.translate('No plugin selected');
/* The selected text doesn't update, so force that translation. */
conflictsFilter.shadowRoot.querySelector('paper-dropdown-menu').shadowRoot.querySelector('paper-input').value = conflictsFilter.shadowRoot.querySelector('paper-dropdown-menu').selectedItem.textContent;
updateDropdownSelectedItemText(conflictsFilter);
document.getElementById('hiddenPluginsTxt').textContent = l10n.translate('Hidden plugins:');
document.getElementById('hiddenMessagesTxt').textContent = l10n.translate('Hidden messages:');
@@ -266,7 +273,7 @@
defaultGameSelect.previousElementSibling.textContent = l10n.translate('Default Game');
defaultGameSelect.firstElementChild.textContent = l10n.translate('Autodetect');
/* The selected text doesn't update, so force that translation. */
defaultGameSelect.shadowRoot.querySelector('paper-dropdown-menu').shadowRoot.querySelector('paper-input').value = defaultGameSelect.shadowRoot.querySelector('paper-dropdown-menu').selectedItem.textContent;
updateDropdownSelectedItemText(defaultGameSelect);
document.getElementById('languageLabel').textContent = l10n.translate('Language');
document.getElementById('languageLabel').nextElementSibling.textContent = l10n.translate('Language changes will be applied after LOOT is restarted.');