Removed readonly toggle for editable tables.

This commit is contained in:
WrinklyNinja
2014-07-21 11:19:11 +01:00
parent d7178e41e3
commit 68f416d05f
3 changed files with 17 additions and 48 deletions
-24
View File
@@ -444,12 +444,6 @@ var EditableTableProto = Object.create(HTMLTableElement.prototype, {
var tbody = tr.parentElement
var table = tbody.parentElement;
/* Remove row edit listeners. */
var inputs = tr.getElementsByTagName('input');
for (var i = 0; i < inputs.length; ++i) {
inputs[i].removeEventListener('dblclick', toggleInputRO, false);
}
/* Remove deletion listener. */
evt.target.removeEventListener('click', table.removeRow, false);
@@ -468,12 +462,6 @@ var EditableTableProto = Object.create(HTMLTableElement.prototype, {
table.getElementsByTagName('tbody')[0].insertBefore(row, evt.currentTarget);
row = evt.currentTarget.previousElementSibling;
/* Enable row editing. */
var inputs = row.getElementsByTagName('input');
for (var i = 0; i < inputs.length; ++i) {
inputs[i].removeAttribute('readonly');
inputs[i].addEventListener('dblclick', toggleInputRO, false);
}
/* Add deletion listener. */
row.getElementsByClassName('fa-trash-o')[0].addEventListener('click', table.removeRow, false);
}
@@ -493,11 +481,6 @@ var EditableTableProto = Object.create(HTMLTableElement.prototype, {
row.getElementsByClassName(key)[0].value = tableData[key];
}
/* Enable row editing. */
var inputs = row.getElementsByTagName('input');
for (var i = 0; i < inputs.length; ++i) {
inputs[i].addEventListener('dblclick', toggleInputRO, false);
}
/* Add deletion listener. */
row.getElementsByClassName('fa-trash-o')[0].addEventListener('click', this.removeRow, false);
@@ -519,13 +502,6 @@ var EditableTableProto = Object.create(HTMLTableElement.prototype, {
/* Remove event listeners. */
var tbody = this.getElementsByTagName('tbody')[0];
/* Remove row edit listeners. */
var inputs = tbody.getElementsByTagName('input');
for (var i = 0; i < inputs.length; ++i) {
inputs[i].removeEventListener('dblclick', toggleInputRO, false);
}
/* Remove deletion listener. */
var icons = tbody.getElementsByClassName('fa-trash-o');
for (var i = 0; i < icons.length; ++i) {
-7
View File
@@ -369,13 +369,6 @@ function closeSettingsDialog(evt) {
function showSettingsDialog(evt) {
document.getElementById('settings').showModal();
}
function toggleInputRO(evt) {
if (evt.target.readOnly) {
evt.target.removeAttribute('readonly');
} else {
evt.target.setAttribute('readonly', '');
}
}
function getDialogParent(element) {
var element = element.parentElement;
+17 -17
View File
@@ -335,9 +335,9 @@
<template id="fileRow">
<tr>
<td><input class="name" type="text" readonly required>
<td><input class="display" type="text" readonly>
<td><input class="condition" type="text" readonly>
<td><input class="name" type="text" required>
<td><input class="display" type="text">
<td><input class="condition" type="text">
<td class="fa fa-trash-o fa-fw">
</template>
<template id="messageRow">
@@ -360,32 +360,32 @@
<option value="add">Add</option>
<option value="remove">Remove</option>
</select>
<td><input class="name" type="text" readonly required>
<td><input class="condition" type="text" readonly>
<td><input class="name" type="text" required>
<td><input class="condition" type="text">
<td class="fa fa-trash-o fa-fw">
</template>
<template id="dirtyInfoRow">
<tr>
<td><input class="crc" type="text" maxlength="8" minlength="8" pattern="[0-9A-Fa-f]{8}" readonly required>
<td><input class="itm" type="number" min="0" step="1" readonly>
<td><input class="udr" type="number" min="0" step="1" readonly>
<td><input class="nav" type="number" min="0" step="1" readonly>
<td><input class="util" type="text" readonly required>
<td><input class="crc" type="text" maxlength="8" minlength="8" pattern="[0-9A-Fa-f]{8}" required>
<td><input class="itm" type="number" min="0" step="1">
<td><input class="udr" type="number" min="0" step="1">
<td><input class="nav" type="number" min="0" step="1">
<td><input class="util" type="text" required>
<td class="fa fa-trash-o fa-fw">
</template>
<template id="gameRow">
<tr>
<td><input class="name" type="text" readonly required>
<td><input class="name" type="text" required>
<td>
<select class="type">
<!-- Game <option> elements go here. -->
</select>
<td><input class="folder" type="text" readonly required>
<td><input class="master" type="text" readonly>
<td><input class="repo" type="text" readonly>
<td><input class="branch" type="text" readonly>
<td><input class="path" type="text" readonly>
<td><input class="registry" type="text" readonly>
<td><input class="folder" type="text" required>
<td><input class="master" type="text">
<td><input class="repo" type="text">
<td><input class="branch" type="text">
<td><input class="path" type="text">
<td><input class="registry" type="text">
<td class="fa fa-trash-o fa-fw">
</template>