loot/libloot
0
0
Fork 0
mirror of https://github.com/loot/libloot.git synced 2026-07-27 14:16:01 -07:00
Code Issues Packages Projects Releases Wiki Activity

Remove unnecessary Plugin() constructor

Browse Source
This commit is contained in:
Oliver Hamlet
2015-12-05 10:17:52 +00:00
parent a4f862a6c3
commit 4ba2b095a2
3 changed files with 10 additions and 33 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/backend/plugin/plugin.cpp
-7
View File
@@ -92,13 +92,6 @@ namespace loot {
regex(regex7, regex::ECMAScript | regex::icase)
});
Plugin::Plugin() :
_isEmpty(true),
_loadsBsa(false),
isMaster(false),
crc(0),
numOverrideRecords(0) {}
Plugin::Plugin(const std::string& n) :
PluginMetadata(n),
_isEmpty(true),
src/backend/plugin/plugin.h
-1
View File
@@ -41,7 +41,6 @@ namespace loot {
class Plugin : public PluginMetadata {
public:
Plugin();
Plugin(const std::string& name);
Plugin(Game& game, const std::string& name, const bool headerOnly);
src/tests/backend/plugin/test_plugin.h
+10 -25
View File
@@ -31,16 +31,7 @@ along with LOOT. If not, see
class Plugin : public SkyrimTest {};
TEST_F(Plugin, ConstructorsAndDataAccess) {
loot::Plugin plugin;
EXPECT_EQ("", plugin.Name());
EXPECT_TRUE(plugin.FormIDs().empty());
EXPECT_TRUE(plugin.Masters().empty());
EXPECT_FALSE(plugin.IsMaster());
EXPECT_TRUE(plugin.IsEmpty());
EXPECT_EQ("", plugin.Version());
EXPECT_EQ(0, plugin.Crc());
plugin = loot::Plugin("Blank.esm");
loot::Plugin plugin("Blank.esm");
EXPECT_EQ("Blank.esm", plugin.Name());
EXPECT_TRUE(plugin.FormIDs().empty());
EXPECT_TRUE(plugin.Masters().empty());
@@ -133,12 +124,8 @@ TEST_F(Plugin, IsActive) {
}
TEST_F(Plugin, EqualityOperator) {
loot::Plugin plugin1, plugin2;
EXPECT_TRUE(plugin1 == plugin2);
EXPECT_TRUE(plugin2 == plugin1);
plugin1 = loot::Plugin("Blank.esm");
plugin2 = loot::Plugin("blank.esm");
loot::Plugin plugin1("Blank.esm");
loot::Plugin plugin2("blank.esm");
EXPECT_TRUE(plugin1 == plugin2);
EXPECT_TRUE(plugin2 == plugin1);
@@ -169,12 +156,8 @@ TEST_F(Plugin, EqualityOperator) {
}
TEST_F(Plugin, InequalityOperator) {
loot::Plugin plugin1, plugin2;
EXPECT_FALSE(plugin1 != plugin2);
EXPECT_FALSE(plugin2 != plugin1);
plugin1 = loot::Plugin("Blank.esm");
plugin2 = loot::Plugin("blank.esm");
loot::Plugin plugin1("Blank.esm");
loot::Plugin plugin2("blank.esm");
EXPECT_FALSE(plugin1 != plugin2);
EXPECT_FALSE(plugin2 != plugin1);
@@ -209,7 +192,8 @@ TEST_F(Plugin, DoFormIDsOverlap) {
game.SetGamePath(dataPath.parent_path());
ASSERT_NO_THROW(game.Init(false, localPath));
loot::Plugin plugin1, plugin2;
loot::Plugin plugin1("Blank.esm");
loot::Plugin plugin2("blank.esm");
EXPECT_FALSE(plugin1.DoFormIDsOverlap(plugin2));
EXPECT_FALSE(plugin2.DoFormIDsOverlap(plugin1));
@@ -234,7 +218,8 @@ TEST_F(Plugin, OverlapFormIDs) {
game.SetGamePath(dataPath.parent_path());
ASSERT_NO_THROW(game.Init(false, localPath));
loot::Plugin plugin1, plugin2;
loot::Plugin plugin1("Blank.esm");
loot::Plugin plugin2("blank.esm");
EXPECT_TRUE(plugin1.OverlapFormIDs(plugin2).empty());
EXPECT_TRUE(plugin2.OverlapFormIDs(plugin1).empty());
@@ -269,7 +254,7 @@ TEST_F(Plugin, CheckInstallValidity) {
game.SetGamePath(dataPath.parent_path());
ASSERT_NO_THROW(game.Init(false, localPath));
loot::Plugin plugin;
loot::Plugin plugin("Blank.esm");
EXPECT_FALSE(plugin.CheckInstallValidity(game));
EXPECT_TRUE(plugin.Messages().empty());