Simplify plugin item data binding

This commit is contained in:
Oliver Hamlet
2016-03-06 14:47:53 +00:00
parent 93c634cf8b
commit 39f6cec046
2 changed files with 7 additions and 14 deletions
+6 -3
View File
@@ -97,17 +97,14 @@
priority: {
type: String,
value: '',
reflectToAttribute: true,
},
isPriorityGlobal: {
type: Boolean,
value: false,
reflectToAttribute: true,
},
hasUserEdits: {
type: Boolean,
value: false,
reflectToAttribute: true,
},
},
@@ -120,6 +117,12 @@
evt.dataTransfer.setData('text/plain', evt.currentTarget.getName());
evt.dataTransfer.setDragImage(evt.currentTarget, 325, 175);
},
updateStyling(pluginData) {
this.priority = pluginData.priority;
this.isPriorityGlobal = pluginData.isPriorityGlobal;
this.hasUserEdits = pluginData.hasUserEdits;
},
});
</script>
</dom-module>
+1 -11
View File
@@ -437,17 +437,7 @@
static onItemContentChange(evt) {
const item = document.getElementById('cardsNav').querySelector(`[data-id="${evt.detail.pluginId}"]`);
if (item) {
item.setAttribute('priority', evt.detail.priority);
if (evt.detail.isPriorityGlobal) {
item.setAttribute('is-priority-global', '');
} else {
item.removeAttribute('is-priority-global');
}
if (evt.detail.hasUserEdits) {
item.setAttribute('has-user-edits', '');
} else {
item.removeAttribute('has-user-edits');
}
item.updateStyling(evt.detail);
}
}
};