loot/libloot
0
0
Fork 0
mirror of https://github.com/loot/libloot.git synced 2026-07-27 14:16:01 -07:00
Code Issues Packages Projects Releases Wiki Activity

Tweak masterlist cloning to avoid undefined behaviour

Browse Source 
According to Boost's docs, it's undefined behaviour to add or remove entries in a directory that is being iterated over.
This commit is contained in:
Oliver Hamlet
2018-06-03 16:18:07 +01:00
parent cf9f9556dc
commit 315622bb1f
1 changed files with 6 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/api/helpers/git_helper.cpp
+6 -1
View File
@@ -258,6 +258,7 @@ void GitHelper::Clone(const boost::filesystem::path& path,
GrantWritePermissions(path);
GrantWritePermissions(repoPath);
std::vector<boost::filesystem::path> filenamesToMove;
for (fs::directory_iterator it(repoPath);
it != fs::directory_iterator();
++it) {
@@ -265,7 +266,11 @@ void GitHelper::Clone(const boost::filesystem::path& path,
if (fs::exists(targetPath)) {
fs::remove_all(targetPath);
}
fs::rename(it->path(), targetPath);
filenamesToMove.push_back(it->path().filename());
}
for (const auto& filename : filenamesToMove) {
fs::rename(repoPath / filename, path / filename);
}
fs::remove_all(repoPath);